NetBSD Problem Report #46942

From www@NetBSD.org  Tue Sep 11 11:38:43 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id EC1BB63B9BC
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 11 Sep 2012 11:38:42 +0000 (UTC)
Message-Id: <20120911113841.D973563B86D@www.NetBSD.org>
Date: Tue, 11 Sep 2012 11:38:41 +0000 (UTC)
From: sdaoden@gmail.com
Reply-To: sdaoden@gmail.com
To: gnats-bugs@NetBSD.org
Subject: editline(3): el_get(): fix UNBUFFERED return
X-Send-Pr-Version: www-1.0

>Number:         46942
>Category:       lib
>Synopsis:       editline(3): el_get(): fix UNBUFFERED return
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 11 11:40:00 +0000 2012
>Closed-Date:    Fri Jun 20 12:40:56 +0000 2014
>Last-Modified:  Fri Jun 20 12:40:56 +0000 2014
>Originator:     Steffen Nurpmeso
>Release:        netbsd-6-base
>Organization:
>Environment:
None.  netbsd-6-base as of 08-31, manually patched up.
>Description:
Return value is '!' not '! !'.  Use !=0 though i hate it.
>How-To-Repeat:
Read source.
>Fix:
    el_get(): fix UNBUFFERED return

diff --git a/src/lib/libedit/el.c b/src/lib/libedit/el.c
index 809af41..f44e8a5 100644
--- a/src/lib/libedit/el.c
+++ b/src/lib/libedit/el.c
@@ -439,7 +439,7 @@ FUN(el,get)(EditLine *el, int op, ...)
 		break;

 	case EL_UNBUFFERED:
-		*va_arg(ap, int *) = (!(el->el_flags & UNBUFFERED));
+		*va_arg(ap, int *) = ((el->el_flags & UNBUFFERED) != 0);
 		rv = 0;
 		break;


>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46942 CVS commit: src/lib/libedit
Date: Tue, 11 Sep 2012 07:58:53 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Tue Sep 11 11:58:53 UTC 2012

 Modified Files:
 	src/lib/libedit: el.c

 Log Message:
 PR/46942: Steffen Nurpmeso: editline(3): el_get(): fix UNBUFFERED return


 To generate a diff of this commit:
 cvs rdiff -u -r1.70 -r1.71 src/lib/libedit/el.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Fri, 20 Jun 2014 12:40:56 +0000
State-Changed-Why:
fixed


>Unformatted:

Home	PR Database Search