NetBSD Problem Report #49090

From www@NetBSD.org  Fri Aug  8 03:59:41 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 5AE46AC105
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  8 Aug 2014 03:59:41 +0000 (UTC)
Message-Id: <20140808035940.5329FAC10B@mollari.NetBSD.org>
Date: Fri,  8 Aug 2014 03:59:40 +0000 (UTC)
From: venture37@geeklan.co.uk
Reply-To: venture37@geeklan.co.uk
To: gnats-bugs@NetBSD.org
Subject: Unbreak devel/pango on OS X Tiger
X-Send-Pr-Version: www-1.0

>Number:         49090
>Category:       pkg
>Synopsis:       Unbreak devel/pango on OS X Tiger
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 08 04:00:00 +0000 2014
>Closed-Date:    Fri Aug 08 14:55:38 +0000 2014
>Last-Modified:  Fri Aug 08 15:00:00 +0000 2014
>Originator:     Sevan Janiyan
>Release:        pkgsrc-current
>Organization:
>Environment:
Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc
>Description:
Don't look for CoreText on systems prior to Leopard as you won't find it.
 https://developer.apple.com/library/mac/documentation/Carbon/Reference/CoreText_Utilities_Ref/Reference/reference.html

>How-To-Repeat:

>Fix:
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/devel/pango/options.mk,v
retrieving revision 1.14
diff -u -r1.14 options.mk
--- options.mk  26 Jul 2014 08:30:58 -0000      1.14
+++ options.mk  8 Aug 2014 03:56:48 -0000
@@ -40,8 +40,10 @@
 ### Quartz "support"
 ###
 .if ${OPSYS} == "Darwin"
-### always looks for system CoreText
+.if !empty(MACHINE_PLATFORM:MDarwin-[9-?].*-*)
+### CoreText is only available in 10.5 or newer
 PLIST.coretext=                yes
+.endif
 .  if !empty(PKG_OPTIONS:Mquartz)
 ### installs its coretext header file if cairo was built with "quartz" option
 PLIST.quartz=          yes

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49090: Unbreak devel/pango on OS X Tiger
Date: Fri, 8 Aug 2014 05:19:43 +0000

 On Fri, Aug 08, 2014 at 04:00:00AM +0000, venture37@geeklan.co.uk wrote:
  > +.if !empty(MACHINE_PLATFORM:MDarwin-[9-?].*-*)

 That pattern won't work... would be nice if we had matching logic like
 that, but we don't.

 I think this conditional wants to be

    .if empty(MACHINE_PLATFORM:MDarwin-[1-8].*-*)

 instead. That way the glob will match the versions where it's not
 there.

 -- 
 David A. Holland
 dholland@netbsd.org

From: venture37 <venture37@geeklan.co.uk>
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, 
 gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Cc: 
Subject: Re: pkg/49090: Unbreak devel/pango on OS X Tiger
Date: Fri, 08 Aug 2014 15:48:02 +0100

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --IkoXSmPak60rIqb0o7AowAlmtADGUkifd
 Content-Type: multipart/mixed;
  boundary="------------060508010101040906090509"

 This is a multi-part message in MIME format.
 --------------060508010101040906090509
 Content-Type: text/plain; charset=windows-1252
 Content-Transfer-Encoding: quoted-printable



 On 08/08/2014 06:20, David Holland wrote:
 >  I think this conditional wants to be
 > =20
 >     .if empty(MACHINE_PLATFORM:MDarwin-[1-8].*-*)
 > =20
 >  instead. That way the glob will match the versions where it's not
 >  there.

 That works, updated diff attached.

 --------------060508010101040906090509
 Content-Type: text/plain; charset=UTF-8;
  name="pango.txt"
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: attachment;
  filename="pango.txt"

 Index: options.mk
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/devel/pango/options.mk,v
 retrieving revision 1.14
 diff -u -r1.14 options.mk
 --- options.mk	26 Jul 2014 08:30:58 -0000	1.14
 +++ options.mk	8 Aug 2014 14:46:34 -0000
 @@ -40,8 +40,10 @@
  ### Quartz "support"
  ###
  .if ${OPSYS} =3D=3D "Darwin"
 -### always looks for system CoreText
 +.if empty(MACHINE_PLATFORM:MDarwin-[1-8].*-*)
 +### CoreText is only available in 10.5 or newer
  PLIST.coretext=3D		yes
 +.endif
  .  if !empty(PKG_OPTIONS:Mquartz)
  ### installs its coretext header file if cairo was built with "quartz" o=
 ption
  PLIST.quartz=3D		yes

 --------------060508010101040906090509--

 --IkoXSmPak60rIqb0o7AowAlmtADGUkifd
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG/MacGPG2 v2.0.22 (Darwin)

 iQIcBAEBAgAGBQJT5OMsAAoJENE/+DdOy3tC59EQAJYloB+mJ5PKjhEJ8487vA4I
 A5CkoNi+FEpuAv39ylgZOpFzmApj4577M4yoG3p+4DSR2su7f+cDB/MG4scELboQ
 wet0pGu7Tv//aiIrxNWftOpCapTzgyaWKAfJfEnFPed7D9AFVEmNrh7qbkljR13H
 UvGSvcFkGLsyNqhjQyJxLd3BedoII1LgjtSXCW1mgpeD2uuo3Yoh30Vp3L/3t9D8
 Sy1oGkMEgdAjOzFgtXXWBg8eHlCFJqGFW3rj1ZRVVUrDJkpBalbnEAfjdVPykBsI
 XR+rsG9UpBIG4GkznRHlFMR7FSGWGkXA0ADgLMZVD9VhwNyORbSGUro+GGV4K8Kj
 HCQ4TYAXwooSRM1XG2zPnekEnpTkHwDT6UoXqAguwVtxeiqGr99tD80nDSdYWnU6
 aX34zc32MYNHaBpaD4XPOfn0Ut4d0K6Koeut96gLW0xdvN0sXPWGs1yrzRMZcLuQ
 +NY3KHaKb/fGWt6WgteGDvZhUE2tIYrc4fPHYUY/MxxxJkAo9hHb38GT4e8bY9Jq
 i8qYAeETWoBw2ZOPqY380bZ4dmbqnaUxJW7hVmtXmKCTru64ejEvu/wCJzFkKJj1
 3q7R8wI42uXYP7P3qgZI2lfvpn5Z+EPIjMnHhZSngeKIFEq7HxFwPuUP64qShgts
 z0+N/lDCNSQGO2sffTlK
 =SvUb
 -----END PGP SIGNATURE-----

 --IkoXSmPak60rIqb0o7AowAlmtADGUkifd--

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Fri, 08 Aug 2014 14:55:38 +0000
State-Changed-Why:
Committed, thanks!


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49090 CVS commit: pkgsrc/devel/pango
Date: Fri, 8 Aug 2014 14:55:21 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Fri Aug  8 14:55:21 UTC 2014

 Modified Files:
 	pkgsrc/devel/pango: options.mk

 Log Message:
 Fix build on OS X Tiger. From Sevan Janiyan in PR 49090.


 To generate a diff of this commit:
 cvs rdiff -u -r1.14 -r1.15 pkgsrc/devel/pango/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.