NetBSD Problem Report #49499

From www@NetBSD.org  Wed Dec 24 02:47:26 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D7352A654D
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 24 Dec 2014 02:47:25 +0000 (UTC)
Message-Id: <20141224024724.A0C76A6555@mollari.NetBSD.org>
Date: Wed, 24 Dec 2014 02:47:24 +0000 (UTC)
From: venture37@geeklan.co.uk
Reply-To: venture37@geeklan.co.uk
To: gnats-bugs@NetBSD.org
Subject: Unbreak security/CSP
X-Send-Pr-Version: www-1.0

>Number:         49499
>Category:       pkg
>Synopsis:       Unbreak security/CSP
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 24 02:50:00 +0000 2014
>Closed-Date:    Fri Dec 26 08:50:28 +0000 2014
>Last-Modified:  Fri Dec 26 08:50:28 +0000 2014
>Originator:     Sevan Janiyan
>Release:        pkgsrc-current
>Organization:
>Environment:
Darwin 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc
>Description:
Create the destination directory which will be used by pax prior to use.
>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/security/CSP/Makefile,v
retrieving revision 1.18
diff -u -r1.18 Makefile
--- Makefile    29 May 2014 23:37:18 -0000      1.18
+++ Makefile    24 Dec 2014 02:45:22 -0000
@@ -37,6 +37,7 @@
 SUBST_STAGE.csp=       post-patch

 post-install:
+       ${MKDIR} -p ${DESTDIR}${CSPHOME}
        cd ${WRKSRC}/ca && ${FIND} . -type f | pax -rw ${DESTDIR}${CSPHOME}
        ${INSTALL_DATA} ${DISTDIR}/${CSPGUIDE} ${DESTDIR}${PREFIX}/share/doc/csp


>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/49499: Unbreak security/CSP
Date: Wed, 24 Dec 2014 09:56:50 +0100

 On Wed, Dec 24, 2014 at 02:50:00AM +0000, venture37@geeklan.co.uk wrote:
 > Create the destination directory which will be used by pax prior to use.

 Please use the INSTALLATION_DIRS variable instead.

 Thanks,
  Thomas

From: "OBATA Akio" <obata@lins.jp>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/49499: Unbreak security/CSP
Date: Wed, 24 Dec 2014 20:46:48 +0900

 On Wed, 24 Dec 2014 18:00:00 +0900, Thomas Klausner <wiz@netbsd.org> wrote:

 >  On Wed, Dec 24, 2014 at 02:50:00AM +0000, venture37@geeklan.co.uk wrote:
 >  > Create the destination directory which will be used by pax prior to use.
 > Please use the INSTALLATION_DIRS variable instead.

 ${CSPHOME} is already in INSTALLATION_DIRS.

 but ${CSPHOME} is ${VARBASE}/csp, it will not be in binary package,
 so I feel that doing `pax' in post-install is no effect unless USE_DESTDIR=no.

 -- 
 OBATA Akio / obata@lins.jp

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49499 CVS commit: pkgsrc/security/CSP
Date: Thu, 25 Dec 2014 02:34:53 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Thu Dec 25 02:34:53 UTC 2014

 Modified Files:
 	pkgsrc/security/CSP: Makefile

 Log Message:
 INSTALLATIN_DIRS must be in ${PREFIX}, create ${CSPHOME} manually instead.
 PR pkg/49499 by Sevan Janiyan.


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.19 pkgsrc/security/CSP/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: obache@NetBSD.org
State-Changed-When: Thu, 25 Dec 2014 05:12:15 +0000
State-Changed-Why:
fixed?


State-Changed-From-To: feedback->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Fri, 26 Dec 2014 08:50:28 +0000
State-Changed-Why:
Confirmed fixed via private mail.


>Unformatted:

Home	PR Database Search