NetBSD Problem Report #50174

From martin@duskware.de  Wed Aug 26 09:05:12 2015
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 71AA3A6531
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 26 Aug 2015 09:05:12 +0000 (UTC)
From: martin@NetBSD.org
Reply-To: martin@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: lib/librumphijack/t_tcpip:ssh fails consistently
X-Send-Pr-Version: 3.95

>Number:         50174
>Category:       lib
>Synopsis:       lib/librumphijack/t_tcpip:ssh fails consistently
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 26 09:10:00 +0000 2015
>Closed-Date:    Fri Sep 10 21:25:57 +0000 2021
>Last-Modified:  Fri Sep 10 21:25:57 +0000 2021
>Originator:     Martin Husemann
>Release:        NetBSD 7.99.21
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD unpluged.duskware.de 7.99.21 NetBSD 7.99.21 (UNPLUGED) #83: Tue Aug 25 19:44:20 CEST 2015 martin@seven-days-to-the-wolves.aprisoft.de:/ssd/src/sys/arch/evbarm/compile/UNPLUGED evbarm
Architecture: earm
Machine: evbarm
>Description:

librumphijack (as used in the lib/librumphijack/t_tcpip:ssh test case)
is not able to fully deal with ssh in -current. The test fails consistently.

>How-To-Repeat:
Just try to run that test

>Fix:
n/a

>Release-Note:

>Audit-Trail:
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50174 CVS commit: src/tests/lib/librumphijack
Date: Wed, 26 Aug 2015 09:19:20 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Wed Aug 26 09:19:20 UTC 2015

 Modified Files:
 	src/tests/lib/librumphijack: t_tcpip.sh

 Log Message:
 Mark the ssh test as expected failure pointing to PR lib/50174


 To generate a diff of this commit:
 cvs rdiff -u -r1.14 -r1.15 src/tests/lib/librumphijack/t_tcpip.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->analyzed
State-Changed-By: christos@NetBSD.org
State-Changed-When: Wed, 26 Aug 2015 05:49:18 -0400
State-Changed-Why:
The problem is that the rump emulation of fcntl F_CLOSEM is broken.
sshd fails with  21641      1 sshd     GIO   fd 2 wrote 39 bytes
       "closefrom failed: Bad file descriptor\r\n"
Removing the check for closefrom makes the test work, but it is wrong.


From: Andreas Gustafsson <gson@gson.org>
To: gnats-bugs@NetBSD.org, christos@NetBSD.org
Cc: 
Subject: Re: lib/50174 (lib/librumphijack/t_tcpip:ssh fails consistently)
Date: Sat, 4 Sep 2021 15:42:15 +0300

 Since Christos' ssh commits of September 2, this test case is failing
 differently than before, with a timeout rather than a prompt failure,
 and the atf_expect_fail statement in the test appears to no longer be
 effective as the test is once again reported as an unexpected failure.

 Log output from the last one of the old, expected failures:

   http://releng.netbsd.org/b5reports/i386/2021/2021.09.02.08.02.33/test.html#lib_librumphijack_t_tcpip_ssh

 Log output from the first one of the new, unexpected failures:

   http://releng.netbsd.org/b5reports/i386/2021/2021.09.02.11.28.45/test.html#lib_librumphijack_t_tcpip_ssh

 -- 
 Andreas Gustafsson, gson@gson.org

State-Changed-From-To: analyzed->closed
State-Changed-By: christos@NetBSD.org
State-Changed-When: Fri, 10 Sep 2021 17:25:57 -0400
State-Changed-Why:
Fixed by:
1. making closefrom(3) always succeed in librumphijack
2. implementing pselect(2) in librumphijack. This was the reason that the
   test now times out instead of failing. Since pselect was not hijacked,
   it did not see the data coming from the rump file descriptor.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.