NetBSD Problem Report #56252
From www@netbsd.org Wed Jun 16 23:34:54 2021
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id C5A501A921F
for <gnats-bugs@gnats.NetBSD.org>; Wed, 16 Jun 2021 23:34:54 +0000 (UTC)
Message-Id: <20210616233453.6CC691A923C@mollari.NetBSD.org>
Date: Wed, 16 Jun 2021 23:34:53 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: wg(4) state machine has race conditions
X-Send-Pr-Version: www-1.0
>Number: 56252
>Category: kern
>Synopsis: wg(4) state machine has race conditions
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Jun 16 23:35:00 +0000 2021
>Last-Modified: Fri Nov 26 20:05:01 +0000 2021
>Originator: Taylor R Campbell
>Release: 9.99.x
>Organization:
The NetBSD Floundation
>Environment:
succumbing to climate change
>Description:
The wg(4) session establishment and rekeying state machine has race conditions, and the WireGuard specification it aims to follow isn't clear on how they are to be resolved. Someone needs to figure out an appropriate resolution.
>How-To-Repeat:
atf-run /usr/tests/net/if_wg
>Fix:
Yes, please!
>Audit-Trail:
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/56252 CVS commit: src/tests/net/if_wg
Date: Thu, 17 Jun 2021 12:16:09 +0000
Module Name: src
Committed By: riastradh
Date: Thu Jun 17 12:16:09 UTC 2021
Modified Files:
src/tests/net/if_wg: t_misc.sh
Log Message:
tests/net/if_wg: Mark as flaky (PR kern/56252).
To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/tests/net/if_wg/t_misc.sh
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Andreas Gustafsson <gson@gson.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: kern/56252: wg(4) state machine has race conditions
Date: Thu, 17 Jun 2021 16:17:20 +0300
Duplicate of PR 55729?
--
Andreas Gustafsson, gson@gson.org
From: "Andreas Gustafsson" <gson@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/56252 CVS commit: src/tests/net/if_wg
Date: Fri, 26 Nov 2021 20:02:35 +0000
Module Name: src
Committed By: gson
Date: Fri Nov 26 20:02:35 UTC 2021
Modified Files:
src/tests/net/if_wg: t_misc.sh
Log Message:
The wg_handshake_timeout test case was failing because it contained
atf_fail "failed to trigger PR kern/56252" without a corresponding
atf_expect_fail "PR kern/56252", which makes no sense. Since the
test case does occasionally fail on real hardware, fix this by adding
the atf_expect_fail rather than by removing the atf_fail.
To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/tests/net/if_wg/t_misc.sh
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
(Contact us)
$NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.