NetBSD Problem Report #55640

From ryo@tetera.org  Thu Sep  3 14:42:22 2020
Return-Path: <ryo@tetera.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 9CDB91A9217
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  3 Sep 2020 14:42:22 +0000 (UTC)
Message-Id: <5f5100cb.1c69fb81.ba33b.8465@mx.google.com>
Date: Thu, 03 Sep 2020 23:42:07 +0900
From: ryo@tetera.org
Reply-To: ryo@tetera.org
To: gnats-bugs@NetBSD.org
Subject: libX11 in netbsd-9's xsrc has a bug to break X Input Method (XIM)
X-Send-Pr-Version: 3.95

>Number:         55640
>Category:       xsrc
>Synopsis:       libX11 in netbsd-9's xsrc has a bug to break X Input Method (XIM)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    xsrc-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 03 14:45:00 +0000 2020
>Closed-Date:    Mon Dec 07 20:48:00 +0000 2020
>Last-Modified:  Mon Dec 07 20:48:00 +0000 2020
>Originator:     Ryo ONODERA
>Release:        NetBSD 9
>Organization:
Ryo ONODERA // ryo@tetera.org
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3
>Environment:


System: NetBSD 9 stable
Architecture: x86_64
Machine: amd64
>Description:

As described at upstream bug report:
https://gitlab.freedesktop.org/xorg/lib/libx11/-/issues/117

X Input Method is broken in xsrc of netbsd-9.

Please apply the following upstream patch:
https://gitlab.freedesktop.org/xorg/lib/libx11/-/merge_requests/43/diffs?commit_id=d15c24c8b44be5e4054c8ecd0ff9dcf2c8e18e5b

xsrc of NetBSD-current is already fixed by newer libX11 import.

Originally reported by HIROSE Yuuji on twitter.com.

>How-To-Repeat:

pkgsrc/inputmethod/kinput2 as XIM server
and pkgsrc/www/firefox as XIM client, for example

>Fix:

Apply:
https://gitlab.freedesktop.org/xorg/lib/libx11/-/merge_requests/43/diffs?commit_id=d15c24c8b44be5e4054c8ecd0ff9dcf2c8e18e5b

Index: external/mit/libX11/dist/modules/im/ximcp/imRmAttr.c
===================================================================
RCS file: /cvsroot/xsrc/external/mit/libX11/dist/modules/im/ximcp/imRmAttr.c,v
retrieving revision 1.1.1.8.4.1
diff -u -r1.1.1.8.4.1 imRmAttr.c
--- external/mit/libX11/dist/modules/im/ximcp/imRmAttr.c	5 Aug 2020 13:44:39 -0000	1.1.1.8.4.1
+++ external/mit/libX11/dist/modules/im/ximcp/imRmAttr.c	3 Sep 2020 14:38:27 -0000
@@ -1407,7 +1407,7 @@
     *names_len = 0;
     while (total > min_len) {
 	len = attr[2];
-	if (len >= (total - min_len)) {
+	if (len > (total - min_len)) {
 	    return 0;
 	}
 	*names_len += (len + 1);

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->pending-pullups
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 07 Dec 2020 17:58:19 +0000
State-Changed-Why:
pullup-9 1145, pullup-8 1634. you can request pullups directly btw.


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55640 CVS commit: [netbsd-9] xsrc/external/mit/libX11/dist/modules/im/ximcp
Date: Mon, 7 Dec 2020 20:18:55 +0000

 Module Name:	xsrc
 Committed By:	martin
 Date:		Mon Dec  7 20:18:55 UTC 2020

 Modified Files:
 	xsrc/external/mit/libX11/dist/modules/im/ximcp [netbsd-9]: imRmAttr.c

 Log Message:
 Apply patch, requested by maya in ticket #1145:

 	external/mit/libX11/dist/modules/im/ximcp/imRmAttr.c	(patch)

 PR 55640: fix off by one in X Input Method.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1.1.8.4.1 -r1.1.1.8.4.2 \
     xsrc/external/mit/libX11/dist/modules/im/ximcp/imRmAttr.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55640 CVS commit: [netbsd-8] xsrc/external/mit/libX11/dist/modules/im/ximcp
Date: Mon, 7 Dec 2020 20:20:15 +0000

 Module Name:	xsrc
 Committed By:	martin
 Date:		Mon Dec  7 20:20:15 UTC 2020

 Modified Files:
 	xsrc/external/mit/libX11/dist/modules/im/ximcp [netbsd-8]: imRmAttr.c

 Log Message:
 Apply patch, requested by maya in ticket #1634:

         external/mit/libX11/dist/modules/im/ximcp/imRmAttr.c    (patch)

 PR 55640: fix off by one in X Input Method.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1.1.8.2.1 -r1.1.1.8.2.2 \
     xsrc/external/mit/libX11/dist/modules/im/ximcp/imRmAttr.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 07 Dec 2020 20:48:00 +0000
State-Changed-Why:
pullups done


>Unformatted:

Home	PR Database Search