NetBSD Problem Report #2551

From gnats  Sat Jun 15 10:31:49 1996
Received: from falcon.dol-esa.gov by pain.lcs.mit.edu (8.7.5/8.7.3) with ESMTP id KAA25770 for <gnats-bugs@gnats.netbsd.org>; Sat, 15 Jun 1996 10:22:27 -0400 (EDT)
Message-Id: <199606151422.KAA02010@owl.dol-esa.gov>
Date: Sat, 15 Jun 1996 10:22:17 -0400 (EDT)
From: Kenneth Stailey <kstailey@dol-esa.gov>
Reply-To: kstailey@dol-esa.gov
To: gnats-bugs@NetBSD.ORG
Subject: pppd prints excess "cannot delete pid file" messages
X-Send-Pr-Version: 3.95

>Number:         2551
>Category:       bin
>Synopsis:       pppd prints excess "cannot delete pid file" messages
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    explorer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 15 10:35:01 +0000 1996
>Closed-Date:    Sat Aug 10 20:30:59 +0000 1996
>Last-Modified:  Sat Aug 10 20:31:22 +0000 1996
>Originator:     Kenneth Stailey
>Release:        1.2_ALPHA
>Organization:
DOL/ESA/DASM
>Environment:

System: NetBSD owl 1.2_ALPHA NetBSD 1.2_ALPHA (OWL) #0: Tue Jun 4 18:56:05 EDT 1996 kstailey@owl:/usr/src/sys/arch/i386/compile/OWL i386


>Description:
	pppd will print "cannot delete pid file" when the real problem is
	that the name of the pid file is an empty string.
>How-To-Repeat:
	forgot.  Try using pppd with configurations that cannot connect
	and do not specify demand dialing.
>Fix:

--- /usr/src/usr.sbin/pppd/main.c	Tue May 14 23:52:47 1996
+++ ./main.c	Wed May 15 00:10:11 1996
@@ -503,7 +503,8 @@
 	}

 	if (!demand) {
-	    if (unlink(pidfilename) < 0 && errno != ENOENT) 
+	    if (pidfilename[0] != 0
+		&& unlink(pidfilename) < 0 && errno != ENOENT) 
 		syslog(LOG_WARNING, "unable to delete pid file: %m");
 	    pidfilename[0] = 0;
 	}
>Release-Note:
>Audit-Trail:

From: Mike Long <mike.long@analog.com>
To: gnats-bugs@NetBSD.ORG
Cc:  Subject: Re: bin/2551: pppd prints excess "cannot delete pid file" messages
Date: Mon, 17 Jun 96 09:48:51 EDT

 This PR addresses the same problem as bin/2388.
 -- 
 Mike Long <mike.long@analog.com>     <URL:http://www.shore.net/~mikel>
 VLSI Design Engineer         finger mikel@shore.net for PGP public key
 Analog Devices, CPD Division          CCBF225E7D3F7ECB2C8F7ABB15D9BE7B
 Norwood, MA 02062 USA       (eq (opinion 'ADI) (opinion 'mike)) -> nil
State-Changed-From-To: open->closed 
State-Changed-By: explorer 
State-Changed-When: Sat Aug 10 16:30:59 EDT 1996 
State-Changed-Why:  
Fixed. 


Responsible-Changed-From-To: bin-bug-people->explorer 
Responsible-Changed-By: explorer 
Responsible-Changed-When: Sat Aug 10 16:30:59 EDT 1996 
Responsible-Changed-Why:  
I fixed it. 
>Unformatted:

Home	PR Database Search