NetBSD Problem Report #40643

From jmcneill@black.invisible.ca  Sat Feb 14 18:36:01 2009
Return-Path: <jmcneill@black.invisible.ca>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 1475C63C181
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 14 Feb 2009 18:36:01 +0000 (UTC)
Message-Id: <20090214183559.8C94B7D9FF7@black.invisible.ca>
Date: Sat, 14 Feb 2009 13:35:59 -0500 (EST)
From: jmcneill@invisible.ca
Reply-To: jmcneill@invisible.ca
To: gnats-bugs@gnats.NetBSD.org
Subject: wsfb/genfb doesn't restore palette on switch from X to console
X-Send-Pr-Version: 3.95

>Number:         40643
>Category:       kern
>Synopsis:       wsfb/genfb doesn't restore palette on switch from X to console
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    nat
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 14 18:40:00 +0000 2009
>Closed-Date:    Sat Nov 14 15:07:51 +0000 2026
>Last-Modified:  Sat Nov 14 15:07:51 +0000 2026
>Originator:     Jared D. McNeill
>Release:        NetBSD 5.99.7
>Organization:

>Environment:


System: NetBSD black.invisible.ca 5.99.7 NetBSD 5.99.7 (GENERIC) #8: Sat Feb 14 10:15:46 EST 2009 jmcneill@black.invisible.ca:/export/home/jmcneill/branches/HEAD/src/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
	When switching from X to console with genfb and xf86-video-wsfb, and
	genfb is running in 8bpp paletted mode, the standard rasops palette
	is not restored properly. Shutting down the X server restores the
	palette as expected.
>How-To-Repeat:
	* startx with wsfb driver in 8bpp mode
	* ctrl+alt+F2
>Fix:

>Release-Note:

>Audit-Trail:

From: "Jared D. McNeill" <jmcneill@invisible.ca>
To: gnats-bugs@NetBSD.org
Cc: xsrc-manager@netbsd.org, gnats-admin@netbsd.org, 
 netbsd-bugs@netbsd.org
Subject: Re: kern/40643: wsfb/genfb doesn't restore palette on switch from
 X to console
Date: Sat, 14 Feb 2009 14:29:19 -0500

 jmcneill@invisible.ca wrote:
 >> Description:
 > 	When switching from X to console with genfb and xf86-video-wsfb, and
 > 	genfb is running in 8bpp paletted mode, the standard rasops palette
 > 	is not restored properly. Shutting down the X server restores the
 > 	palette as expected.

 Looks like a genfb issue;

 If the bus glue provides an ioctl callback (as is the case with 
 genfb_pci), the generic WSDISPLAYIO_SMODE path is never called, from 
 genfb.c:genfb_ioctl():

      /* notify the bus backend */
      if (sc->sc_ops.genfb_ioctl)
      	return sc->sc_ops.genfb_ioctl(sc, vs,
      	    cmd, data, flag, l);

 Cheers,
 Jared

Responsible-Changed-From-To: xsrc-manager->nat
Responsible-Changed-By: nat@NetBSD.org
Responsible-Changed-When: Sat, 14 Nov 2026 14:44:01 +0000
Responsible-Changed-Why:
Take.


From: "Nathanial Sloss" <nat@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/40643 CVS commit: src/sys/dev/wsfb
Date: Sat, 14 Nov 2026 14:49:49 +0000

 Module Name:	src
 Committed By:	nat
 Date:		Sat Nov 14 14:49:49 UTC 2026

 Modified Files:
 	src/sys/dev/wsfb: genfb.c

 Log Message:
 Save and restore color palette at 8bpp.

 Patch and testing by Ray Tran.

 Addresses PR/60696.
 Addresses PR/40643.
 Should address PR/46574 also.


 To generate a diff of this commit:
 cvs rdiff -u -r1.94 -r1.95 src/sys/dev/wsfb/genfb.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: nat@NetBSD.org
State-Changed-When: Sat, 14 Nov 2026 15:07:51 +0000
State-Changed-Why:
I believe this should be fixed now.


>Unformatted:

Home	PR Database Search