NetBSD Problem Report #47017

From dholland@netbsd.org  Sat Sep 29 22:42:32 2012
Return-Path: <dholland@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id ED7C463D798
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 29 Sep 2012 22:42:31 +0000 (UTC)
Message-Id: <20120929224233.9F23214A2E6@mail.netbsd.org>
Date: Sat, 29 Sep 2012 22:42:33 +0000 (UTC)
From: dholland@netbsd.org
Reply-To: dholland@netbsd.org
To: gnats-bugs@gnats.NetBSD.org
Subject: mk/jpeg.bl3.mk is order-dependent
X-Send-Pr-Version: 3.95

>Number:         47017
>Category:       pkg
>Synopsis:       mk/jpeg.bl3.mk is order-dependent
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 29 22:45:00 +0000 2012
>Closed-Date:    Thu Jul 14 23:56:12 +0000 2022
>Last-Modified:  Thu Jul 14 23:56:12 +0000 2022
>Originator:     David A. Holland
>Release:        pkgsrc of 20120929
>Organization:
>Environment:
n/a
>Description:

If you include ../../mk/jpeg.buildlink3.mk in your package and it
happens to be after some other package you're using has included it in
its own bl3, you don't get a direct dependence on the jpeg library.

>How-To-Repeat:

Do 'make show-depends' in games/flightgear, examine the results and
the makefile.

>Fix:

The problem is that mk/jpeg.bl3.mk is multiple-include-protected, so
the jpeg library's own bl3 is not included except the first time
through. Moving the jpeg library bl3 inclusions outside the include
protection will fix the problem... but may cause other problems, so
I'd like a second opinion before just fixing it myself.

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/47017: mk/jpeg.bl3.mk is order-dependent
Date: Sun, 30 Sep 2012 21:24:16 +0000

 On Sat, Sep 29, 2012 at 10:45:00PM +0000, dholland@netbsd.org wrote:
  > >How-To-Repeat:
  > 
  > Do 'make show-depends' in games/flightgear, examine the results and
  > the makefile.

 FTR, this no longer works by default -- but it will if you move the
 inclusion to the bottom of the list.

 -- 
 David A. Holland
 dholland@netbsd.org

From: Benny Siegert <bsiegert@gmail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/47017 (mk/jpeg.bl3.mk is order-dependent)
Date: Sat, 8 Aug 2015 14:39:21 +0200

 Is this an actual problem? If you do not get a direct libjpeg
 dependency but an indirect one (via some other package), that should
 be fine, no?

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/47017 (mk/jpeg.bl3.mk is order-dependent)
Date: Sun, 9 Aug 2015 20:45:54 +0000

 On Sat, Aug 08, 2015 at 12:40:00PM +0000, Benny Siegert wrote:
  >  Is this an actual problem? If you do not get a direct libjpeg
  >  dependency but an indirect one (via some other package), that should
  >  be fine, no?

 Yes, it is an actual problem. The dependence information recorded
 should be correct, not partial.

 -- 
 David A. Holland
 dholland@netbsd.org

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47017 CVS commit: pkgsrc/mk
Date: Thu, 14 Jul 2022 23:45:48 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Thu Jul 14 23:45:48 UTC 2022

 Modified Files:
 	pkgsrc/mk: jpeg.buildlink3.mk

 Log Message:
 Fix jpeg.bl3.mk to include bl3 files outside multiple-include protection.

 This makes the library chosen appear in all places it's supposed to in
 the buildlink tree instead of just the first time it's mentioned.

 Closes PR 47017 (mk/jpeg.bl3.mk is order-dependent)


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/mk/jpeg.buildlink3.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Thu, 14 Jul 2022 23:56:12 +0000
State-Changed-Why:
fixed


>Unformatted:

Home	PR Database Search