NetBSD Problem Report #49819

From www@NetBSD.org  Mon Apr  6 12:48:15 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 2BCEFA6562
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  6 Apr 2015 12:48:15 +0000 (UTC)
Message-Id: <20150406124810.D2C61A65BE@mollari.NetBSD.org>
Date: Mon,  6 Apr 2015 12:48:10 +0000 (UTC)
From: k0ga@shike2.com
Reply-To: k0ga@shike2.com
To: gnats-bugs@NetBSD.org
Subject: Add support for SystemBase SB16C1050 card
X-Send-Pr-Version: www-1.0

>Number:         49819
>Category:       kern
>Synopsis:       Add support for SystemBase SB16C1050 card
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 06 12:50:00 +0000 2015
>Closed-Date:    Mon May 04 21:24:49 +0000 2015
>Last-Modified:  Thu Dec 08 08:05:00 +0000 2016
>Originator:     Roberto E. Vargas Caballero
>Release:        6.1.5
>Organization:
>Environment:
NetBSD  6.1.5_PATCH NetBSD 6.1.5_PATCH (K0GA) #12: Mon Apr  6 12:51:13 CEST 2015  k0ga@:/usr/src/sys/arch/i386/compile/K0GA i386
>Description:
NetBSD lacks support for the multiport serial card made by SystemBase with PCI id 0x4d0214a1, although it has support for the related cards with PCI ids 0x000414a1 and
0x000814a1.
>How-To-Repeat:

>Fix:
cvs diff: Diffing .
Index: pcidevs.h
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/pcidevs.h,v
retrieving revision 1.1097.2.11
diff -u -r1.1097.2.11 pcidevs.h
--- pcidevs.h	22 Nov 2012 17:47:10 -0000	1.1097.2.11
+++ pcidevs.h	6 Apr 2015 12:27:55 -0000
@@ -4761,6 +4761,7 @@
 /* System Base products */
 #define	PCI_PRODUCT_SYSTEMBASE_SB16C1054	0x0004		/* SB16C1054 UARTs */
 #define	PCI_PRODUCT_SYSTEMBASE_SB16C1058	0x0008		/* SB16C1058 UARTs */
+#define	PCI_PRODUCT_SYSTEMBASE_SB16C1050	0x4d02		/* SB16C1050 UARTs */

 /* Schneider & Koch (really SysKonnect) products */
 #define	PCI_PRODUCT_SCHNEIDERKOCH_SKNET_FDDI	0x4000		/* SK-NET FDDI-xP */
Index: puc.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/puc.c,v
retrieving revision 1.32
diff -u -r1.32 puc.c
--- puc.c	28 May 2011 10:48:50 -0000	1.32
+++ puc.c	6 Apr 2015 12:27:55 -0000
@@ -249,7 +249,8 @@
 	/* SB16C10xx board specific initialization */
 	if (PCI_VENDOR(pa->pa_id) == PCI_VENDOR_SYSTEMBASE &&
 	    (PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_SYSTEMBASE_SB16C1054 ||
-	    PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_SYSTEMBASE_SB16C1058)) {
+	    PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_SYSTEMBASE_SB16C1058  ||
+	    PCI_PRODUCT(pa->pa_id) == PCI_PRODUCT_SYSTEMBASE_SB16C1050)) {
 		if (!sc->sc_bar_mappings[1].mapped) {
 			aprint_error_dev(self,
 			    "optional register is not mapped\n");
Index: pucdata.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/pucdata.c,v
retrieving revision 1.76.8.1
diff -u -r1.76.8.1 pucdata.c
--- pucdata.c	31 Oct 2012 17:27:01 -0000	1.76.8.1
+++ pucdata.c	6 Apr 2015 12:27:56 -0000
@@ -2412,6 +2412,15 @@
 		{ PUC_PORT_TYPE_COM, 0x10, 0x38, COM_FREQ },
 	    },
 	},
+	/* PCI_PRODUCT_SYSTEMBASE_SB16C1050 */
+	{   "SystemBase SB16C1050",
+	    {   PCI_VENDOR_SYSTEMBASE, PCI_PRODUCT_SYSTEMBASE_SB16C1050, 0, 0 },
+	    {	0xffff,	0xffff,						 0, 0 },
+	    {
+		{ PUC_PORT_TYPE_COM, 0x10, 0x00, COM_FREQ * 8},
+		{ PUC_PORT_TYPE_COM, 0x10, 0x08, COM_FREQ * 8},
+	    },
+	},

 	/*
 	 * VScom PCI 010L

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: ryo@NetBSD.org
State-Changed-When: Mon, 04 May 2015 21:24:49 +0000
State-Changed-Why:
commited.


From: "Ryo Shimizu" <ryo@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49819 CVS commit: src
Date: Mon, 4 May 2015 21:21:39 +0000

 Module Name:	src
 Committed By:	ryo
 Date:		Mon May  4 21:21:39 UTC 2015

 Modified Files:
 	src/share/man/man4: puc.4
 	src/sys/dev/pci: puc.c pucdata.c

 Log Message:
 PR/49819: Roberto E. Vargas Caballero: Add support for SystemBase SB16C1050 PCI serial card


 To generate a diff of this commit:
 cvs rdiff -u -r1.38 -r1.39 src/share/man/man4/puc.4
 cvs rdiff -u -r1.37 -r1.38 src/sys/dev/pci/puc.c
 cvs rdiff -u -r1.94 -r1.95 src/sys/dev/pci/pucdata.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Soren Jacobsen" <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49819 CVS commit: [netbsd-7] src
Date: Thu, 8 Dec 2016 08:03:59 +0000

 Module Name:	src
 Committed By:	snj
 Date:		Thu Dec  8 08:03:59 UTC 2016

 Modified Files:
 	src/share/man/man4 [netbsd-7]: puc.4
 	src/sys/dev/pci [netbsd-7]: pucdata.c

 Log Message:
 Pull up following revision(s) (requested by msaitoh in ticket #1292):
 	sys/dev/pci/pucdata.c: revisions 1.95-1.98
 	share/man/man4/puc.4: revisions 1.39-40
 Add three devices to puc(4):
 - Add support for SystemBase SB16C1050 PCI serial card. PR#49819
   reported by Roberto E. Vargas Caballero.
 - Add another Intel Q45 KT.
 - Add Intel 100 Series Chipset KT.


 To generate a diff of this commit:
 cvs rdiff -u -r1.38 -r1.38.8.1 src/share/man/man4/puc.4
 cvs rdiff -u -r1.93.4.1 -r1.93.4.2 src/sys/dev/pci/pucdata.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search