NetBSD Problem Report #51886

From www@NetBSD.org  Sun Jan 15 20:41:42 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 12A4C7A26F
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 15 Jan 2017 20:41:42 +0000 (UTC)
Message-Id: <20170115204136.64E2A7A2BD@mollari.NetBSD.org>
Date: Sun, 15 Jan 2017 20:41:36 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/libpthread/t_fork: use _exit instead of exit
X-Send-Pr-Version: www-1.0

>Number:         51886
>Category:       bin
>Synopsis:       [PATCH] tests/lib/libpthread/t_fork: use _exit instead of exit
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 15 20:45:00 +0000 2017
>Closed-Date:    Mon Jan 16 18:30:41 +0000 2017
>Last-Modified:  Mon Jan 16 18:30:41 +0000 2017
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
exit(3) flushes file descriptors which can have some unintended side effects with open file descriptors from atf/kyua, so it's best to use _exit instead.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51886: [PATCH] tests/lib/libpthread/t_fork: use _exit instead
 of exit
Date: Sun, 15 Jan 2017 13:00:29 -0800

 --Apple-Mail=_9851A9FF-E15E-4196-A011-670EC34FCA49
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.
 -Ngie

 --Apple-Mail=_9851A9FF-E15E-4196-A011-670EC34FCA49
 Content-Disposition: attachment;
 	filename=t_fork-various-fixes.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="t_fork-various-fixes.patch"
 Content-Transfer-Encoding: 7bit

 Index: lib/libpthread/t_fork.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libpthread/t_fork.c,v
 retrieving revision 1.1
 diff -u -r1.1 t_fork.c
 --- lib/libpthread/t_fork.c	16 Jul 2010 15:42:53 -0000	1.1
 +++ lib/libpthread/t_fork.c	15 Jan 2017 21:00:09 -0000
 @@ -61,7 +61,7 @@

  	thread_survived = 1;
  	if (parent != getpid()) {
 -		exit(1);
 +		_exit(1);
  	}
  	return NULL;
  }
 @@ -95,7 +95,7 @@
  		ATF_REQUIRE_EQ_MSG(WEXITSTATUS(status), 0, "thread survived in child");
  	} else {
  		sleep(5);
 -		exit(thread_survived ? 1 : 0);
 +		_exit(thread_survived ? 1 : 0);
  	}
  }


 --Apple-Mail=_9851A9FF-E15E-4196-A011-670EC34FCA49--

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51886 CVS commit: src/tests/lib/libpthread
Date: Mon, 16 Jan 2017 11:28:27 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Mon Jan 16 16:28:27 UTC 2017

 Modified Files:
 	src/tests/lib/libpthread: t_fork.c

 Log Message:
 PR/51886: Ngie Cooper: Use _exit instead of exit


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libpthread/t_fork.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Mon, 16 Jan 2017 18:30:41 +0000
State-Changed-Why:
christos committed it. thanks!


>Unformatted:

Home	PR Database Search