NetBSD Problem Report #54107

From www@netbsd.org  Mon Apr  8 20:30:12 2019
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id EAC8D7A1B9
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  8 Apr 2019 20:30:11 +0000 (UTC)
Message-Id: <20190408203010.AF0C97A1D6@mollari.NetBSD.org>
Date: Mon,  8 Apr 2019 20:30:10 +0000 (UTC)
From: bernhard@netmuc.net
Reply-To: bernhard@netmuc.net
To: gnats-bugs@NetBSD.org
Subject: pkgsrc-2019Q1/misc/fbreader doesn't build with newer compiler(s)
X-Send-Pr-Version: www-1.0

>Number:         54107
>Category:       pkg
>Synopsis:       pkgsrc-2019Q1/misc/fbreader doesn't build with newer compiler(s)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 08 20:35:00 +0000 2019
>Closed-Date:    Mon Sep 09 13:48:19 +0000 2019
>Last-Modified:  Sat Sep 21 18:45:01 +0000 2019
>Originator:     Bernhard Riedel
>Release:        pkgsrc-2019Q1 as of 2019-04-07
>Organization:
>Environment:
NetBSD tja.crg.de 8.99.36 NetBSD 8.99.36 (GENERIC) #0: Wed Apr  3 18:57:32 CEST 2019  root@wip.crg.de:/sdata/test-current-20190403000000Z/obj/amd64/sys/arch/amd64/compile/GENERIC amd64
>Description:
When trying to bmake build, fails in
$WRKDIR/fbreader-0.99.4/fbreader/src/formats/doc/OleStorage.cpp
with
OleStorage.cpp: In member function 'bool OleStorage::init(shared_ptr<ZLInputStream>, std::size_t)':
OleStorage.cpp:62:83: error: narrowing conversion of '208' from 'int' to 'char' inside { } [-Wnarrowing]
  static const char OLE_SIGN[] = {0xD0, 0xCF, 0x11, 0xE0, 0xA1, 0xB1, 0x1A, 0xE1, 0};
[...]
>How-To-Repeat:
bmake build with environment as above
>Fix:
New patch patch-fbreader_src_formats_doc_OleStorage.cpp

Replaces offending 0xVW ints with '\xVW' char literals

gzipped, base64 encoded:

H4sICP2mq1wCA3BhdGNoLWZicmVhZGVyX3NyY19mb3JtYXRzX2RvY19PbGVTdG9yYWdlLmNw
cACNUdtOAjEQfd5+xZiQANld2KJEXSThIhgTI4m8eQkp3VloUtpNWxRD+He7K+qb2odzZs5M
z6TT2j260fy6RsgDFpJxhDXuWIZcbJgEoRyu0FhYvoN1RqgVSOHQMGnBaWCvWmSAxuiqpLcO
tAKFb2iA600hpL/bIiSOY8iXBr2vaVvD27k2G+ZsO9O8PZM4d9qwFbZ4UbS81SroJLQTUxqf
JkA76RlNO91W8nUgLJGEYfhfUzIYQNy9jM4hrNCnS60l/HSlqVDCNeyaGcwWhTNXj3e3qtg6
AkHAJTLTaPbK2KDbGgW53wCWwoHEgXXMCe5frKwD7i1gdjdZzG9v7p9eoA/7ZHedRJDsxtMS
KS1xUinDKh5VSIeVXsaHHgn/dK0/e9t6BJ7H00+m9JMnR314zEdHpsNjvczLKRCIHBrWZWnq
v1fxTdHQEkfbPPoeFsFFE076kDRh//syPgCG8EchSwIAAA==

P.S.: Feedback to original authors probably doesn't make a lot of sense.
The newest versions 0.10.7 and 0.12.10 seem to have dropped .doc
 support.

>Release-Note:

>Audit-Trail:
From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54107 CVS commit: pkgsrc/misc/fbreader
Date: Mon, 9 Sep 2019 13:31:53 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Mon Sep  9 13:31:53 UTC 2019

 Modified Files:
 	pkgsrc/misc/fbreader: distinfo
 Added Files:
 	pkgsrc/misc/fbreader/patches:
 	    patch-fbreader_src_formats_doc_OleStorage.cpp

 Log Message:
 fbreader: avoid narrowing conversion warning. Taken from gentoo.

 Fixes PR pkg/54107: pkgsrc-2019Q1/misc/fbreader doesn't build with
 newer compiler(s)


 To generate a diff of this commit:
 cvs rdiff -u -r1.12 -r1.13 pkgsrc/misc/fbreader/distinfo
 cvs rdiff -u -r0 -r1.1 \
     pkgsrc/misc/fbreader/patches/patch-fbreader_src_formats_doc_OleStorage.cpp

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 09 Sep 2019 13:48:19 +0000
State-Changed-Why:
fix applied, pullup request. thanks for the report.


From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54107 CVS commit: [pkgsrc-2019Q2] pkgsrc/misc/fbreader
Date: Sat, 21 Sep 2019 18:40:05 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Sat Sep 21 18:40:05 UTC 2019

 Modified Files:
 	pkgsrc/misc/fbreader [pkgsrc-2019Q2]: distinfo
 Added Files:
 	pkgsrc/misc/fbreader/patches [pkgsrc-2019Q2]:
 	    patch-fbreader_src_formats_doc_OleStorage.cpp

 Log Message:
 Pullup ticket #6057 - requested by maya
 misc/fbreader: build fix

 Revisions pulled up:
 - misc/fbreader/distinfo                                        1.13
 - misc/fbreader/patches/patch-fbreader_src_formats_doc_OleStorage.cpp 1.1

 ---
    Module Name:	pkgsrc
    Committed By:	maya
    Date:		Mon Sep  9 13:31:53 UTC 2019

    Modified Files:
    	pkgsrc/misc/fbreader: distinfo
    Added Files:
    	pkgsrc/misc/fbreader/patches:
    	    patch-fbreader_src_formats_doc_OleStorage.cpp

    Log Message:
    fbreader: avoid narrowing conversion warning. Taken from gentoo.

    Fixes PR pkg/54107: pkgsrc-2019Q1/misc/fbreader doesn't build with
    newer compiler(s)


 To generate a diff of this commit:
 cvs rdiff -u -r1.12 -r1.12.24.1 pkgsrc/misc/fbreader/distinfo
 cvs rdiff -u -r0 -r1.1.2.2 \
     pkgsrc/misc/fbreader/patches/patch-fbreader_src_formats_doc_OleStorage.cpp

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search