NetBSD Problem Report #54200

From bjjl@chaos.lorenz.place  Sun May 12 21:26:40 2019
Return-Path: <bjjl@chaos.lorenz.place>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id EF8447A1E4
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 12 May 2019 21:26:39 +0000 (UTC)
Message-Id: <20190512124552.5CF81410833@chaos.lorenz.place>
Date: Sun, 12 May 2019 14:45:52 +0200 (CEST)
From: ben@pocket.services
Reply-To: ben@pocket.services
To: gnats-bugs@NetBSD.org
Subject: devel/talloc build failure
X-Send-Pr-Version: 3.95

>Number:         54200
>Category:       pkg
>Synopsis:       devel/talloc build failure
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          feedback
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun May 12 21:30:00 +0000 2019
>Closed-Date:    
>Last-Modified:  Sat Jun 22 12:58:41 +0000 2019
>Originator:     Benjamin Lorenz
>Release:        NetBSD 8.99.38
>Organization:

>Environment:


System: NetBSD chaos.lorenz.place 8.99.38 NetBSD 8.99.38 (GENERIC) #1: Mon May 6 14:33:41 CEST 2019 bjjl@chaos.lorenz.place:/home/bjjl/8.99/obj/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:

Using PYTHON_VERSION_DEFAULT=37 in case it matters.

===> Building for talloc-2.2.0nb1
--- all ---
PYTHONHASHSEED=1 WAF_MAKE=1 /usr/pkg/bin/python3.7 /home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/buildtools/bin/waf build
Traceback (most recent call last):
  File "/home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/third_party/waf/waflib/Scripting.py", line 158, in waf_entry_point
    run_commands()
  File "/home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/third_party/waf/waflib/Scripting.py", line 247, in run_commands
    parse_options()
  File "/home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/third_party/waf/waflib/Scripting.py", line 216, in parse_options
    ctx.execute()
  File "/home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/third_party/waf/waflib/Options.py", line 340, in execute
    self.parse_args()
  File "/home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/third_party/waf/waflib/Options.py", line 331, in parse_args
    options, commands, envvars = self.parse_cmd_args()
  File "./buildtools/wafsamba/samba_utils.py", line 545, in wafsamba_options_parse_cmd_args
    CHECK_MAKEFLAGS(options)
  File "./buildtools/wafsamba/samba_utils.py", line 536, in CHECK_MAKEFLAGS
    options.jobs = int(jobs)
ValueError: invalid literal for int() with base 10: '_PKGSRCDIR=/home/bjjl/8.99/pkgsrc'
*** [all] Error code 2

make: stopped in /home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0
1 error

make: stopped in /home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0
*** Error code 2

>How-To-Repeat:

>Fix:


>Release-Note:

>Audit-Trail:
From: Leonardo Taccari <leot@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/54200: devel/talloc build failure
Date: Mon, 13 May 2019 14:20:08 +0200

 Hello Benjamin, 

 ben@pocket.services writes:
 >
 > Using PYTHON_VERSION_DEFAULT=37 in case it matters.
 >

 In pkgsrc-current it should not matter: it is already the default.

 > ===> Building for talloc-2.2.0nb1
 > --- all ---
 > PYTHONHASHSEED=1 WAF_MAKE=1 /usr/pkg/bin/python3.7 /home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/buildtools/bin/waf build
 > Traceback (most recent call last):
 >   File "/home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/third_party/waf/waflib/Scripting.py", line 158, in waf_entry_point
 >     run_commands()
 >   File "/home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/third_party/waf/waflib/Scripting.py", line 247, in run_commands
 >     parse_options()
 >   File "/home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/third_party/waf/waflib/Scripting.py", line 216, in parse_options
 >     ctx.execute()
 >   File "/home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/third_party/waf/waflib/Options.py", line 340, in execute
 >     self.parse_args()
 >   File "/home/bjjl/8.99/pkgsrc/devel/talloc/work/talloc-2.2.0/third_party/waf/waflib/Options.py", line 331, in parse_args
 >     options, commands, envvars = self.parse_cmd_args()
 >   File "./buildtools/wafsamba/samba_utils.py", line 545, in wafsamba_options_parse_cmd_args
 >     CHECK_MAKEFLAGS(options)
 >   File "./buildtools/wafsamba/samba_utils.py", line 536, in CHECK_MAKEFLAGS
 >     options.jobs = int(jobs)
 > ValueError: invalid literal for int() with base 10: '_PKGSRCDIR=/home/bjjl/8.99/pkgsrc'
 > *** [all] Error code 2
 > [...]

 Can you please share the value of MAKEFLAGS?:

  % cd pkgsrc/devel/talloc
  % make show-var VARNAME=MAKEFLAGS

 ...and can you please add a debug print() to check if such offending
 options are passed?, i.e.:

  % cd pkgsrc/devel/talloc
  % make patch

 ...and then:

  % $EDITOR `make show-var VARNAME=WRKSRC`/buildtools/wafsamba/samba_utils.py

 modify from:

     543                                       cwd=cwd,
     544                                       allow_unknown=allow_unknown)
     545     CHECK_MAKEFLAGS(options)
     546     if options.jobs == 1:
     547         #

 to (add the extra `print('XXX: ' ...)'):

     543                                       cwd=cwd,
     544                                       allow_unknown=allow_unknown)
     545     print('XXX: ' + str(options))
     546     CHECK_MAKEFLAGS(options)
     547     if options.jobs == 1:
     548         #


 Thanks!


 (JFTR: At least on NetBSD-current and pkgsrc-current I could not
 reproduce that neither with `MAKE_JOBS= 8' nor with `MAKE_JOBS'
 undefined.)

State-Changed-From-To: open->feedback
State-Changed-By: leot@NetBSD.org
State-Changed-When: Mon, 13 May 2019 12:26:37 +0000
State-Changed-Why:
More information requested.


State-Changed-From-To: feedback->open
State-Changed-By: leot@NetBSD.org
State-Changed-When: Sat, 22 Jun 2019 12:57:59 +0000
State-Changed-Why:
Re-open to re-request feedback!


State-Changed-From-To: open->feedback
State-Changed-By: leot@NetBSD.org
State-Changed-When: Sat, 22 Jun 2019 12:58:41 +0000
State-Changed-Why:
Can you please try if:

cvs rdiff -u -r1.24 -r1.25 pkgsrc/devel/talloc/distinfo
cvs rdiff -u -r0 -r1.1 \
    pkgsrc/devel/talloc/patches/patch-buildtools_wafsamba_samba__utils.py

fixes them?


Thank you!


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.