NetBSD Problem Report #54231

From gson@gson.org  Sat May 25 13:52:51 2019
Return-Path: <gson@gson.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 0083D7A188
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 25 May 2019 13:52:50 +0000 (UTC)
Message-Id: <20190525135245.4D283989F84@guava.gson.org>
Date: Sat, 25 May 2019 16:52:45 +0300 (EEST)
From: gson@gson.org (Andreas Gustafsson)
Reply-To: gson@gson.org (Andreas Gustafsson)
To: gnats-bugs@NetBSD.org
Subject: lib/libcurses/t_curses:copywin test regression
X-Send-Pr-Version: 3.95

>Number:         54231
>Category:       lib
>Synopsis:       lib/libcurses/t_curses:copywin test regression
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    blymn
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 25 13:55:00 +0000 2019
>Closed-Date:    Sun May 26 07:29:16 +0000 2019
>Last-Modified:  Sun May 26 07:30:01 +0000 2019
>Originator:     Andreas Gustafsson
>Release:        NetBSD-current, source date >= 2019.05.12.02.37.24
>Organization:

>Environment:
System: NetBSD
Architecture: i386
Machine: i386
>Description:

On May 13, the NetBSD Test Fixture wrote:

  This is an automatically generated notice of a new failure of the
  NetBSD test suite.

  The newly failing test case is:

      lib/libcurses/t_curses:copywin

  The above test failed in each of the last 3 test runs, and passed in
  at least 27 consecutive runs before that.

  The following commits were made between the last successful test and
  the failed test:

      2019.05.12.02.19.23 blymn src/lib/libcurses/refresh.c,v 1.109
      2019.05.12.02.29.00 blymn src/lib/libcurses/addbytes.c,v 1.50
      2019.05.12.02.37.24 blymn src/tests/lib/libcurses/check_files/wprintw_refresh.chk,v 1.2

  Log files can be found at:

      http://releng.NetBSD.org/b5reports/i386/commits-2019.05.html#2019.05.12.02.37.24

The test case is still failing as of source date 2019.05.24.10.37.39.

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: lib-bug-people->blymn
Responsible-Changed-By: gson@NetBSD.org
Responsible-Changed-When: Sat, 25 May 2019 13:57:18 +0000
Responsible-Changed-Why:
Over to committer.


From: blymn <blymn@internode.on.net>
To: gnats-bugs@netbsd.org, blymn@netbsd.org, lib-bug-people@netbsd.org,
 netbsd-bugs@netbsd.org, gnats-admin@netbsd.org, gson@NetBSD.org, "(Andreas
 Gustafsson)" <gson@gson.org>
Cc: 
Subject: Re: lib/54231 (lib/libcurses/t_curses:copywin test regression)
Date: Sun, 26 May 2019 08:20:42 +0930

This is failing because addwch now advances the cursor and line wraps as it should so wprintw fails adding a character to the bottom right corner of the window which,
since scrollok is false, is correct.
To make the window fills work scrollok needs to be true then add the bottom line first, scroll the window back down and then add the rest of the lines to get the window full of characters.
I am partway through making the required changes.
Sent from Samsung tablet.

From: Brett Lymn <blymn@internode.on.net>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: lib/54231 (lib/libcurses/t_curses:copywin test regression)
Date: Sun, 26 May 2019 16:00:03 +0930

 Gah - that will learn me for trusting the android tablet...

 For the sake of the record, here is what I wrote:

 This is failing because addwch now advances the cursor and line wraps as
 it should so wprintw fails adding a character to the bottom right corner
 of the window which, since scrollok is false, is correct.

 To make the window fills work scrollok needs to be true then add the
 bottom line first, scroll the window back down and then add the rest of
 the lines to get the window full of characters.

 I am partway through making the required changes.

 -- 
 Brett Lymn
 --
 Sent from my NetBSD device.

 "We are were wolves",
 "You mean werewolves?",
 "No we were wolves, now we are something else entirely",
 "Oh"

State-Changed-From-To: open->closed
State-Changed-By: blymn@NetBSD.org
State-Changed-When: Sun, 26 May 2019 07:29:16 +0000
State-Changed-Why:
Fixed copywin test.


From: "Brett Lymn" <blymn@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54231 CVS commit: src/tests/lib/libcurses
Date: Sun, 26 May 2019 07:28:15 +0000

 Module Name:	src
 Committed By:	blymn
 Date:		Sun May 26 07:28:15 UTC 2019

 Modified Files:
 	src/tests/lib/libcurses/check_files: copywin10.chk copywin11.chk
 	    copywin12.chk copywin13.chk copywin14.chk copywin2.chk copywin5.chk
 	    copywin6.chk copywin7.chk copywin8.chk copywin9.chk
 	src/tests/lib/libcurses/tests: copywin

 Log Message:
 Adjust copywin test to work correctly with updated curses.
 This fixes PR 54231


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libcurses/check_files/copywin10.chk \
     src/tests/lib/libcurses/check_files/copywin11.chk \
     src/tests/lib/libcurses/check_files/copywin12.chk \
     src/tests/lib/libcurses/check_files/copywin13.chk \
     src/tests/lib/libcurses/check_files/copywin14.chk \
     src/tests/lib/libcurses/check_files/copywin2.chk \
     src/tests/lib/libcurses/check_files/copywin5.chk \
     src/tests/lib/libcurses/check_files/copywin6.chk \
     src/tests/lib/libcurses/check_files/copywin7.chk \
     src/tests/lib/libcurses/check_files/copywin8.chk \
     src/tests/lib/libcurses/check_files/copywin9.chk
 cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libcurses/tests/copywin

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search