NetBSD Problem Report #54475

From bjjl@chaos.lorenz.place  Sat Aug 17 14:49:20 2019
Return-Path: <bjjl@chaos.lorenz.place>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id CA7C97A10E
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 17 Aug 2019 14:49:19 +0000 (UTC)
Message-Id: <20190817144915.EE5A3410BE2@chaos.lorenz.place>
Date: Sat, 17 Aug 2019 16:49:15 +0200 (CEST)
From: ben@pocket.services
To: gnats-bugs@NetBSD.org
Subject: sysutils/libgtop build error
X-Send-Pr-Version: 3.95

>Number:         54475
>Category:       pkg
>Synopsis:       sysutils/libgtop build error
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gutteridge
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Aug 17 14:50:00 +0000 2019
>Closed-Date:    Mon Aug 19 09:48:31 +0000 2019
>Last-Modified:  Mon Aug 19 09:48:31 +0000 2019
>Originator:     Benjamin Lorenz
>Release:        NetBSD 9.0_BETA
>Organization:

>Environment:


System: NetBSD chaos.lorenz.place 9.0_BETA NetBSD 9.0_BETA (GENERIC) #0: Sun Aug 11 00:09:38 CEST 2019 bjjl@chaos.lorenz.place:/home/bjjl/9.0/obj/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:

Due to new perl version?

gmake[2]: Entering directory '/home/bjjl/current/pkgsrc/sysutils/libgtop/work/libgtop-2.28.4/lib'
/usr/pkg/bin/perl ./lib.pl < ../features.def > lib-t
Assigning non-zero to $[ is no longer possible at ./lib.pl line 3.
gmake[2]: *** [Makefile:695: lib.c] Error 255
gmake[2]: Leaving directory '/home/bjjl/current/pkgsrc/sysutils/libgtop/work/libgtop-2.28.4/lib'
gmake[1]: *** [Makefile:471: all-recursive] Error 1
gmake[1]: Leaving directory '/home/bjjl/current/pkgsrc/sysutils/libgtop/work/libgtop-2.28.4'
gmake: *** [Makefile:354: all] Error 2
*** Error code 2

Stop.
make[1]: stopped in /home/bjjl/current/pkgsrc/sysutils/libgtop
*** Error code 1

>How-To-Repeat:

>Fix:


>Release-Note:

>Audit-Trail:
From: "David H. Gutteridge" <david@gutteridge.ca>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/54475: sysutils/libgtop build error
Date: Sat, 17 Aug 2019 18:16:33 -0400

 Yes, as of Perl 5.30, it's no longer permitted to set $[ to a non-zero
 value, so that script breaks. The bigger question is: this package is
 at version 2.40 upstream, and there's a 2.34 version in pkgsrc-wip. I'm
 not familiar with why pkgsrc has kept it at version 2.28.4. Perhaps
 there's a specific reason. If so, lib.pl will need to be converted to
 use zero-based indexing throughout.

 Dave


Responsible-Changed-From-To: pkg-manager->gutteridge
Responsible-Changed-By: gutteridge@NetBSD.org
Responsible-Changed-When: Mon, 19 Aug 2019 01:07:55 +0000
Responsible-Changed-Why:
Take.

From: "David H. Gutteridge" <gutteridge@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54475 CVS commit: pkgsrc/sysutils/libgtop
Date: Mon, 19 Aug 2019 05:59:56 +0000

 Module Name:	pkgsrc
 Committed By:	gutteridge
 Date:		Mon Aug 19 05:59:56 UTC 2019

 Modified Files:
 	pkgsrc/sysutils/libgtop: Makefile distinfo
 Added Files:
 	pkgsrc/sysutils/libgtop/patches: patch-lib_lib.pl

 Log Message:
 libgtop: fix build with Perl >= 5.30

 As of Perl 5.30, it's no longer permitted to set $[ to a non-zero
 value, which was causing the lib.pl script to fail. Adjust the script
 to use zero-based indexing. (Upstream has also changed this script
 accordingly in subsequent releases, but this isn't a straight lift from
 there, as the ingoing features.def input file format has also changed
 in intervening releases, and there were other, unrelated changes
 applied too.) This is a workaround until this package is updated to a
 newer release (that is non-trivial because of the number of local
 patches, etc.). Addresses PR pkg/54475.


 To generate a diff of this commit:
 cvs rdiff -u -r1.59 -r1.60 pkgsrc/sysutils/libgtop/Makefile
 cvs rdiff -u -r1.35 -r1.36 pkgsrc/sysutils/libgtop/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/sysutils/libgtop/patches/patch-lib_lib.pl

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: gutteridge@NetBSD.org
State-Changed-When: Mon, 19 Aug 2019 06:06:59 +0000
State-Changed-Why:
Please advise if this resolves the issue for you. (It works for me.)

From: Benjamin Lorenz <ben@pocket.services>
To: gnats-bugs@netbsd.org, gutteridge@netbsd.org, pkgsrc-bugs@netbsd.org,
 gnats-admin@netbsd.org
Cc: 
Subject: Re: pkg/54475 (sysutils/libgtop build error)
Date: Mon, 19 Aug 2019 09:16:22 +0200

 Works for me as well. Thanks!

State-Changed-From-To: feedback->closed
State-Changed-By: leot@NetBSD.org
State-Changed-When: Mon, 19 Aug 2019 09:48:31 +0000
State-Changed-Why:
Confirmed fixed.  Thank you Benjamin for the PR and feedback
and thanks to David for fixing it!


>Unformatted:

Home	PR Database Search