NetBSD Problem Report #54484

From hf@spg.tu-darmstadt.de  Tue Aug 20 09:35:33 2019
Return-Path: <hf@spg.tu-darmstadt.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 6566A7A1D3
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 20 Aug 2019 09:35:33 +0000 (UTC)
Message-Id: <201908200818.x7K8Ie1D021548@Gstoder.nt.e-technik.tu-darmstadt.de>
Date: Tue, 20 Aug 2019 10:18:40 +0200 (CEST)
From: Hauke Fath <hf@spg.tu-darmstadt.de>
Reply-To: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@NetBSD.org
Subject: lang/newlisp build broken after NetBSD readline.h change
X-Send-Pr-Version: 3.95

>Number:         54484
>Category:       pkg
>Synopsis:       lang/newlisp build broken after NetBSD readline.h change
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ryoon
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 20 09:40:00 +0000 2019
>Closed-Date:    Fri Aug 23 15:42:58 +0000 2019
>Last-Modified:  Fri Aug 23 15:42:58 +0000 2019
>Originator:     Hauke Fath
>Release:        NetBSD 9.0_BETA
>Organization:
Technische Universitaet Darmstadt
>Environment:


System: NetBSD Gstoder 9.0_BETA NetBSD 9.0_BETA (GA-MA770-UD3-$Revision$) #0: Mon Aug 5 16:36:12 CEST 2019 hf@Hochstuhl:/var/obj/netbsd-builds/9/amd64/sys/arch/amd64/compile/GA-MA770-UD3 amd64
Architecture: x86_64
Machine: amd64
>Description:

	The lang/newlisp build currently breaks with

[...]
gcc -m64 -O2 -D_FORTIFY_SOURCE=2 -I/usr/include -I/usr/pkg/include  -Wall -Wno-uninitialized -Wno-long-long -fno-strict-aliasing -O2 -c -DNEWCONFIG nl-list.c
--- newlisp.o ---
newlisp.c:1013:9: error: conflicting types for 'completion_matches'
 char ** completion_matches(const char * text,  char * (*commands)(const char *, int));
         ^~~~~~~~~~~~~~~~~~
In file included from newlisp.c:31:0:
/usr/include/readline/readline.h:183:15: note: previous declaration of 'completion_matches' was here
 char        **completion_matches(/* const */ char *, rl_compentry_func_t *);
               ^~~~~~~~~~~~~~~~~~
newlisp.c: In function 'printString':
newlisp.c:2712:25: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
                         else
                         ^~~~
newlisp.c:2713:45: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
                 varPrintf(device,"%c",chr); break;
                                             ^~~~~
newlisp.c: In function 'p_set':
newlisp.c:5129:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if(params == nilCell)
     ^~
newlisp.c:5131:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  pushResultFlag = TRUE;
  ^~~~~~~~~~~~~~
newlisp.c: In function 'p_new':
newlisp.c:6633:5: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
     else
     ^~~~
newlisp.c:6636:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
         overWriteFlag = (evaluateExpression(next)->type != CELL_NIL);
         ^~~~~~~~~~~~~
--- nl-liststr.o ---
gcc -m64 -O2 -D_FORTIFY_SOURCE=2 -I/usr/include -I/usr/pkg/include  -Wall -Wno-uninitialized -Wno-long-long -fno-strict-aliasing -O2 -c -DNEWCONFIG nl-liststr.c
--- newlisp.o ---
*** [newlisp.o] Error code 1

make[1]: stopped in /var/obj/pkgsrc/lang/newlisp/work/newlisp-10.7.1
1 error

	after the v1.43 commit to NetBSD src/lib/libedit/readline/readline.h.


>How-To-Repeat:

	Build newlisp on netbsd-9.


>Fix:

	De-constifying the prototype will break builds on netbsd-8;
	being unfamiliar with the code, I am not clear about the
	implications either way.

	I tried updating to 10.7.5, which did not make a difference.



>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->ryoon
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Wed, 21 Aug 2019 12:47:23 +0000
Responsible-Changed-Why:
Over to maintainer.


From: "Ryo ONODERA" <ryoon@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54484 CVS commit: pkgsrc/lang/newlisp
Date: Fri, 23 Aug 2019 13:41:32 +0000

 Module Name:	pkgsrc
 Committed By:	ryoon
 Date:		Fri Aug 23 13:41:32 UTC 2019

 Modified Files:
 	pkgsrc/lang/newlisp: Makefile PLIST distinfo
 Removed Files:
 	pkgsrc/lang/newlisp/patches: patch-guiserver_guiserver.lsp

 Log Message:
 Update to 10.7.5

 * GUI in Java was removed in 10.7.2 release.
 * Fix build error related to readline with devel/readline. PR pkg/54484

 Changelog:
 10.7.2
    Fixing out-of-sink of file positions when mixing 'search' and 'seek'
    with 'read-line' on IO-streams introduced a new errror making
    the newlisp-10.x.x/examples/upload.cgi script fail.

 10.7.3
    Supress loading of startup init.lsp when -h option is present. Before
    only the -n and -x options supressed init.lsp.

    Change in modules/gsl.lsp to make it work on locales using comma separator.

    Ability to use 'open', 'rename-file', 'delete-file', 'make-dir' and
    'remove-dir' with UTF16 filenames in UTF8 versions on Windows when
    using the UTF8 version of newLISP. The functions 'file-info', 'file?',
    'change-dir' and 'dir? already worked on UTF16 filenames when using the UTF8
    version of newLISP on Windows.

    Thanks to Michael Sabin who started the work a few years back writing the
    win-path.c file with functions translating between UTF8 and UTF16.

    When using the UTF8 version of newLISP on Windows in a command shell, that
    command shell program also should be able to handle/display UTF8 (not UTF16).
    On Windows and Linux the Java based frontend newLISP-GS handles UTF8.
    On Mac OS the terminal program handles UTF8.

    Fixed a wrong 'symbol protected message' when a protected symbol is
    part of a nested espression, but not a symbol with its content to be
    modified.

    New modules/postscript.lsp changes description of ps:drawto.

    Fixed flushing problem on 'print' to stdout on Mac OS and other BSDs.

    '(read-key true)' with the 'true' parameter is now non-blocking.

    (trim str) on some strings containing 0's would overrun memory and 0's
    where not trimmed from the left. All character <= 32 (space) should
    be trimmed from the left and right ends of the string buffer. When the
    entire string is valid ASCII or UTF-8 with no 0s, ‘trim’ behaves
    like in older versions.

 10.7.4
    When starting newlisp in -http-safe server mode HTTP_PUT and HTTP_DELETE
    requests will not be served. This will cause 'write-file' and 'delete-file'
    in url syntax, 'put-url' and 'delete-url' functions issued from a newLISP
    client to return the text message "Server in safe mode".

    New file qa-specific-tests/qa-share.lsp .

    New guiserver.jar v 1.67 compiled with java 1.6
    Still problems on macOS, some unrelated to change to image/icon load change

    Added REQUEST_URI to environment variables in webserver mode.

    Removed code introduced in 10.7.2 to syncronize file poisitons of C FILE stream
    and raw file handle operations. Syncronization still seem s to work on cases
    tested, but may not work in all cases mixing 'read-line' and 'seek'.

    Changes for separately packaged Java Guiserver and elimination of installers.

    (rotate theList -offsetOfRotation) was buggy

 10.7.5
    In getPutPostDeleteUrl(....) sock wasn't closed when returning with webError(..)

    compareLists() in nl-math.c did not take list lengths into account. Also update
    of qa-dot for relevant cases.


 To generate a diff of this commit:
 cvs rdiff -u -r1.12 -r1.13 pkgsrc/lang/newlisp/Makefile
 cvs rdiff -u -r1.8 -r1.9 pkgsrc/lang/newlisp/PLIST
 cvs rdiff -u -r1.13 -r1.14 pkgsrc/lang/newlisp/distinfo
 cvs rdiff -u -r1.2 -r0 \
     pkgsrc/lang/newlisp/patches/patch-guiserver_guiserver.lsp

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: hauke@NetBSD.org
State-Changed-When: Fri, 23 Aug 2019 15:42:58 +0000
State-Changed-Why:
Build problem fixed, thank you!


>Unformatted:

Home	PR Database Search