NetBSD Problem Report #54556

From www@netbsd.org  Tue Sep 17 20:53:24 2019
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 6BB2F7A1B2
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 17 Sep 2019 20:53:24 +0000 (UTC)
Message-Id: <20190917205323.56C237A1D6@mollari.NetBSD.org>
Date: Tue, 17 Sep 2019 20:53:23 +0000 (UTC)
From: perseant@uw.edu
Reply-To: perseant@uw.edu
To: gnats-bugs@NetBSD.org
Subject: Please update security/ccid to version 1.4.27
X-Send-Pr-Version: www-1.0

>Number:         54556
>Category:       pkg
>Synopsis:       Please update security/ccid to version 1.4.27
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 17 20:55:01 +0000 2019
>Closed-Date:    Tue Sep 17 23:10:13 +0000 2019
>Last-Modified:  Tue Sep 17 23:25:00 +0000 2019
>Originator:     Konrad Schroder
>Release:        current as of 2019-09-16
>Organization:
University of Washington
>Environment:
NetBSD apu1c.bastion.coral.washington.edu 9.99.10 NetBSD 9.99.10 (APU1C_GENERIC) #15: Mon Sep 16 12:57:29 PDT 2019  root@backup.coral.washington.edu:/ovar/src-current/sys/arch/amd64/compile/obj/APU1C_GENERIC amd64

>Description:
Version 1.4.27 of the ccid driver package includes some card reader drivers that are not included in version 1.4.26, and we have one of the new readers (HID Omnikey 5422).  It would be helpful to us, and presumably others, to pull up the latest upstream.  Thanks!
>How-To-Repeat:
<Plug in a HID Omnikey 5422>

# pkgin install pcsc-lite ccid pcsc-tools
# pcsc_scan

<No card readers are shown>
>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/security/ccid/Makefile,v
retrieving revision 1.28
diff -u -r1.28 Makefile
--- Makefile	14 Aug 2019 00:17:43 -0000	1.28
+++ Makefile	17 Sep 2019 20:48:05 -0000
@@ -1,14 +1,14 @@
 # $NetBSD: Makefile,v 1.28 2019/08/14 00:17:43 ryoon Exp $
 #

-DISTNAME=	ccid-1.4.26
+DISTNAME=	ccid-1.4.27
 PKGREVISION=	3
 CATEGORIES=	security
 # Note that the MASTER_SITES URL is not stable with version changes,
 # and one can end up with an old version if DISTNAME is changed but
 # not the magic number in MASTER_SITES.
 # https://alioth.debian.org/frs/?group_id=30105#title_ccid
-MASTER_SITES=	https://alioth.debian.org/frs/download.php/file/4205/
+MASTER_SITES=	https://alioth-archive.debian.org/releases/pcsclite/ccid/1.4.27/
 EXTRACT_SUFX=	.tar.bz2

 MAINTAINER=	gdt@NetBSD.org
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/security/ccid/distinfo,v
retrieving revision 1.15
diff -u -r1.15 distinfo
--- distinfo	16 Feb 2017 14:30:50 -0000	1.15
+++ distinfo	17 Sep 2019 20:48:05 -0000
@@ -4,3 +4,6 @@
 RMD160 (ccid-1.4.26.tar.bz2) = cfc7760604c4a568f7e4dd903fdfe4bf5e6e4885
 SHA512 (ccid-1.4.26.tar.bz2) = 4a2e5e9412f2aa4870e14114e54da96fd8b3418ea6d3a236b83e19d6349adb20a94ef7f48628c108f8459f008c10b0606bbf4d797ae4be9183e1acde032c618c
 Size (ccid-1.4.26.tar.bz2) = 628038 bytes
+SHA1 (ccid-1.4.27.tar.bz2) = d72ee816422183a86006e0083ccd643236b4e12a
+RMD160 (ccid-1.4.27.tar.bz2) = 876019fd46530e4404f483b0e20dd22abd5be84a
+Size (ccid-1.4.27.tar.bz2) = 632817 bytes

>Release-Note:

>Audit-Trail:
From: coypu@sdf.org
To: gnats-bugs@netbsd.org, perseant@uw.edu
Cc: 
Subject: Re: pkg/54556: Please update security/ccid to version 1.4.27
Date: Tue, 17 Sep 2019 21:09:11 +0000

 LGTM! please commit it.
 Add PKG_DEVELOPER=yes
 and run 'make cce' after you commit it :_)

From: coypu@sdf.org
To: gnats-bugs@netbsd.org, perseant@uw.edu
Cc: 
Subject: Re: pkg/54556: Please update security/ccid to version 1.4.27
Date: Tue, 17 Sep 2019 21:12:14 +0000

 On Tue, Sep 17, 2019 at 09:09:11PM +0000, coypu@sdf.org wrote:
 > LGTM! please commit it.
 > Add PKG_DEVELOPER=yes
 > and run 'make cce' after you commit it :_)

 Also, delete the PKGREVISION= 3 line :-)

From: coypu@sdf.org
To: gnats-bugs@netbsd.org, perseant@uw.edu
Cc: 
Subject: Re: pkg/54556: Please update security/ccid to version 1.4.27
Date: Tue, 17 Sep 2019 21:20:55 +0000

 On Tue, Sep 17, 2019 at 09:12:15PM +0000, coypu@sdf.org wrote:
 > On Tue, Sep 17, 2019 at 09:09:11PM +0000, coypu@sdf.org wrote:
 > > LGTM! please commit it.
 > > Add PKG_DEVELOPER=yes
 > > and run 'make cce' after you commit it :_)
 > 
 > Also, delete the PKGREVISION= 3 line :-)

 Also run 'make distinfo' before commit, not manually edit the distinfo
 file as you did - it is wrong. The old lines need to be deleted.

 (Thanks sevan, I didn't notice.)

From: coypu@sdf.org
To: Konrad Schroder <perseant@uw.edu>
Cc: gnats-bugs@netbsd.org
Subject: Re: pkg/54556: Please update security/ccid to version 1.4.27
Date: Tue, 17 Sep 2019 22:29:21 +0000

 On Tue, Sep 17, 2019 at 02:54:05PM -0700, Konrad Schroder wrote:
 > 
 > On 9/17/19 2:20 PM, coypu@sdf.org wrote:
 > > On Tue, Sep 17, 2019 at 09:12:15PM +0000, coypu@sdf.org wrote:
 > > > On Tue, Sep 17, 2019 at 09:09:11PM +0000, coypu@sdf.org wrote:
 > > > > LGTM! please commit it.
 > > > > Add PKG_DEVELOPER=yes
 > > > > and run 'make cce' after you commit it :_)
 > > > Also, delete the PKGREVISION= 3 line :-)
 > > Also run 'make distinfo' before commit, not manually edit the distinfo
 > > file as you did - it is wrong. The old lines need to be deleted.
 > > 
 > > (Thanks sevan, I didn't notice.)
 > 
 > 
 > After adding PKG_DEVELOPER=YES the build process told me that I should also
 > change the requirements of the pcsc-lite library, so the full patch now
 > looks like this:

 I've never seen that warning. Weird.


 I mean in /etc/mk.conf :-) Please leave this part out.
 > +PKG_DEVELOPER=    YES

 Besides this one line, please do commit!

State-Changed-From-To: open->closed
State-Changed-By: perseant@NetBSD.org
State-Changed-When: Tue, 17 Sep 2019 23:10:13 +0000
State-Changed-Why:
Patch applied.


From: "Konrad Schroder" <perseant@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54556 CVS commit: pkgsrc/security
Date: Tue, 17 Sep 2019 23:09:42 +0000

 Module Name:	pkgsrc
 Committed By:	perseant
 Date:		Tue Sep 17 23:09:42 UTC 2019

 Modified Files:
 	pkgsrc/security/ccid: Makefile distinfo
 	pkgsrc/security/pcsc-lite: buildlink3.mk

 Log Message:
 Update ccid to version 1.4.27, including link requirement in pcsc-lite.
 Closes PR security/54556.


 To generate a diff of this commit:
 cvs rdiff -u -r1.28 -r1.29 pkgsrc/security/ccid/Makefile
 cvs rdiff -u -r1.15 -r1.16 pkgsrc/security/ccid/distinfo
 cvs rdiff -u -r1.8 -r1.9 pkgsrc/security/pcsc-lite/buildlink3.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Konrad Schroder <perseant@uw.edu>
To: coypu@sdf.org, gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/54556: Please update security/ccid to version 1.4.27
Date: Tue, 17 Sep 2019 14:54:05 -0700

 On 9/17/19 2:20 PM, coypu@sdf.org wrote:
 > On Tue, Sep 17, 2019 at 09:12:15PM +0000, coypu@sdf.org wrote:
 >> On Tue, Sep 17, 2019 at 09:09:11PM +0000, coypu@sdf.org wrote:
 >>> LGTM! please commit it.
 >>> Add PKG_DEVELOPER=yes
 >>> and run 'make cce' after you commit it :_)
 >> Also, delete the PKGREVISION= 3 line :-)
 > Also run 'make distinfo' before commit, not manually edit the distinfo
 > file as you did - it is wrong. The old lines need to be deleted.
 >
 > (Thanks sevan, I didn't notice.)


 After adding PKG_DEVELOPER=YES the build process told me that I should 
 also change the requirements of the pcsc-lite library, so the full patch 
 now looks like this:

 Index: pcsc-lite/buildlink3.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/security/pcsc-lite/buildlink3.mk,v
 retrieving revision 1.8
 diff -u -r1.8 buildlink3.mk
 --- pcsc-lite/buildlink3.mk    7 Jan 2018 13:04:30 -0000    1.8
 +++ pcsc-lite/buildlink3.mk    17 Sep 2019 21:48:55 -0000
 @@ -5,7 +5,7 @@
   .if !defined(PCSC_LITE_BUILDLINK3_MK)
   PCSC_LITE_BUILDLINK3_MK:=

 -BUILDLINK_API_DEPENDS.pcsc-lite+=    pcsc-lite>=1.6.5
 +BUILDLINK_API_DEPENDS.pcsc-lite+=    pcsc-lite>=1.8.3
   BUILDLINK_PKGSRCDIR.pcsc-lite?= ../../security/pcsc-lite

   .endif # PCSC_LITE_BUILDLINK3_MK
 Index: ccid/Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/security/ccid/Makefile,v
 retrieving revision 1.28
 diff -u -r1.28 Makefile
 --- ccid/Makefile    14 Aug 2019 00:17:43 -0000    1.28
 +++ ccid/Makefile    17 Sep 2019 21:48:55 -0000
 @@ -1,14 +1,14 @@
   # $NetBSD: Makefile,v 1.28 2019/08/14 00:17:43 ryoon Exp $
   #

 -DISTNAME=    ccid-1.4.26
 -PKGREVISION=    3
 +DISTNAME=    ccid-1.4.27
 +PKG_DEVELOPER=    YES
   CATEGORIES=    security
   # Note that the MASTER_SITES URL is not stable with version changes,
   # and one can end up with an old version if DISTNAME is changed but
   # not the magic number in MASTER_SITES.
   # https://alioth.debian.org/frs/?group_id=30105#title_ccid
 -MASTER_SITES= https://alioth.debian.org/frs/download.php/file/4205/
 +MASTER_SITES= 
 https://alioth-archive.debian.org/releases/pcsclite/ccid/1.4.27/
   EXTRACT_SUFX=    .tar.bz2

   MAINTAINER=    gdt@NetBSD.org
 Index: ccid/distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/security/ccid/distinfo,v
 retrieving revision 1.15
 diff -u -r1.15 distinfo
 --- ccid/distinfo    16 Feb 2017 14:30:50 -0000    1.15
 +++ ccid/distinfo    17 Sep 2019 21:48:55 -0000
 @@ -1,6 +1,5 @@
   $NetBSD: distinfo,v 1.15 2017/02/16 14:30:50 gdt Exp $

 -SHA1 (ccid-1.4.26.tar.bz2) = 20e22c23b8458548a6b572b044e5dbe4ecdc42e5
 -RMD160 (ccid-1.4.26.tar.bz2) = cfc7760604c4a568f7e4dd903fdfe4bf5e6e4885
 -SHA512 (ccid-1.4.26.tar.bz2) = 
 4a2e5e9412f2aa4870e14114e54da96fd8b3418ea6d3a236b83e19d6349adb20a94ef7f48628c108f8459f008c10b0606bbf4d797ae4be9183e1acde032c618c
 -Size (ccid-1.4.26.tar.bz2) = 628038 bytes
 +SHA1 (ccid-1.4.27.tar.bz2) = d72ee816422183a86006e0083ccd643236b4e12a
 +RMD160 (ccid-1.4.27.tar.bz2) = 876019fd46530e4404f483b0e20dd22abd5be84a
 +Size (ccid-1.4.27.tar.bz2) = 632817 bytes

 Any other changes, or OK to commit?

 Thanks,

 -- 
 -----------------------------------------------------------------------
 Konrad Schroder             Box 352143 -or- 115D Fluke Hall, Mason Road
 Software Developer and System Administrator    University of Washington
 College of Engineering                          Seattle, WA, 98195, USA

>Unformatted:

Home	PR Database Search