NetBSD Problem Report #54848

From www@netbsd.org  Thu Jan  9 21:53:09 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 03C037A15D
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  9 Jan 2020 21:53:09 +0000 (UTC)
Message-Id: <20200109215308.363F27A1E0@mollari.NetBSD.org>
Date: Thu,  9 Jan 2020 21:53:08 +0000 (UTC)
From: dasricht@gmail.com
Reply-To: dasricht@gmail.com
To: gnats-bugs@NetBSD.org
Subject: editors/emacs-snapshot jansson option mistakenly depend on x11 option
X-Send-Pr-Version: www-1.0

>Number:         54848
>Category:       pkg
>Synopsis:       editors/emacs-snapshot jansson option mistakenly depend on x11 option
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    mef
>State:          feedback
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 09 21:55:00 +0000 2020
>Closed-Date:    
>Last-Modified:  Sat Jan 11 13:15:01 +0000 2020
>Originator:     Richard
>Release:        stable
>Organization:
>Environment:
Linux HOSTNAME 3.10.0-1062.4.1.el7.x86_64 #1 SMP Fri Oct 18 17:15:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
>Description:
The jansson option is checked for within the ".if" block of the x11 option. The jansson library, however, doesn't really have x11 as a dependency, and the option will work just fine without x11. But if you disable the x11 option, the jansson option will be ignored.
>How-To-Repeat:
Build the emacs-snapshot package without the x11 option, but with the jansson option.
>Fix:
Move the check for the jansson option outside of the x11 block in options.mk

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->mef
Responsible-Changed-By: mef@NetBSD.org
Responsible-Changed-When: Sat, 11 Jan 2020 10:40:52 +0000
Responsible-Changed-Why:
I'll take it, thanks for the report


From: "Makoto Fujiwara" <mef@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54848 CVS commit: pkgsrc/editors/emacs-snapshot
Date: Sat, 11 Jan 2020 11:43:04 +0000

 Module Name:	pkgsrc
 Committed By:	mef
 Date:		Sat Jan 11 11:43:04 UTC 2020

 Modified Files:
 	pkgsrc/editors/emacs-snapshot: Makefile options.mk

 Log Message:
 PR pkg/54848 jansson option should not be related to (should not depend on) x11 option.
 Thanks  dasricht@gmail.com for the report. (Now always enabled by the way)
 So PKGREVISION++


 To generate a diff of this commit:
 cvs rdiff -u -r1.93 -r1.94 pkgsrc/editors/emacs-snapshot/Makefile
 cvs rdiff -u -r1.13 -r1.14 pkgsrc/editors/emacs-snapshot/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: mef@NetBSD.org
State-Changed-When: Sat, 11 Jan 2020 11:58:08 +0000
State-Changed-Why:
Fix applied. Please cvs update and give us a report if OK, thanks


From: "Makoto Fujiwara" <mef@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54848 CVS commit: pkgsrc/editors/emacs-snapshot
Date: Sat, 11 Jan 2020 12:15:15 +0000

 Module Name:	pkgsrc
 Committed By:	mef
 Date:		Sat Jan 11 12:15:15 UTC 2020

 Modified Files:
 	pkgsrc/editors/emacs-snapshot: options.mk

 Log Message:
 (editors/emacs-snapshot) PR pkg/54848 Fix again, logic moved down outside of if x11 .. endif clause


 To generate a diff of this commit:
 cvs rdiff -u -r1.14 -r1.15 pkgsrc/editors/emacs-snapshot/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Makoto Fujiwara <makoto@if.t.u-tokyo.ac.jp>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/54848 (editors/emacs-snapshot jansson option mistakenly depend on x11 option)
Date: Sat, 11 Jan 2020 20:25:31 +0900

 Hi, thanks for the report, and how-to-fix:
 I don't know how to check if jansson option is enabled, so
 just I've checked the system-configuration-options variable.

 Anyway, I'll commit the fix.
 Following lines show how to confirm the change. (Am I right ?)

 - check exisiting emacs
 - cd /usr/pkgsrc/editors/emacs-snapshot
   make clean
   make replace
   (start)  emacs=20
   M-x describe-variable
       system-configuration-options
       and '--without-json' found

 - Apply the patch
   make clean
   env PKG_OPTIONS.emacs=3D'jansson -x11' make replace
   '--without-json' NOT found

 (before)
 --------------------------------------------
 system-configuration-options is a variable defined in íC source codeó.
 Its value is

 "--srcdir=3D/tmp/editors/emacs-snapshot/work/emacs-27.0.60
 --localstatedir=3D/var
 --without-rsvg
 --without-imagemagick
 --without-json
 --x-includes=3D/usr/X11R7/include
 --x-libraries=3D/usr/X11R7/lib
 --with-x-toolkit=3Dgtk3
 --prefix=3D/usr/pkg
 --build=3Dx86_64--netbsd
 --host=3Dx86_64--netbsd
 --infodir=3D/usr/pkg/info
 --mandir=3D/usr/pkg/man
 --enable-option-checking=3Dyes
 'CFLAGS=3D-O2
 -D_FORTIFY_SOURCE=3D2
 -I/usr/pkg/include
 -I/usr/include
 -I/usr/pkg/include/glib-2.0
 -I/usr/pkg/include/gio-unix-2.0
 -I/usr/pkg/lib/glib-2.0/include
 -I/usr/X11R7/include
 -I/usr/X11R7/include/freetype2
 -I/usr/X11R7/include/libdrm'
 'CPPFLAGS=3D-I/usr/pkg/include
 -I/usr/include
 -I/usr/pkg/include/glib-2.0
 -I/usr/pkg/include/gio-unix-2.0
 -I/usr/pkg/lib/glib-2.0/include
 -I/usr/X11R7/include
 -I/usr/X11R7/include/freetype2
 -I/usr/X11R7/include/libdrm'
 'LDFLAGS=3D-L/usr/pkg/lib
 -Wl,-R/usr/pkg/lib
 -L/usr/lib -Wl,-R/usr/lib
 -L/usr/X11R7/lib
 -Wl,-R/usr/X11R7/lib'"
 --------------------------------------------


 (after)
 --------------------------------------------

 system-configuration-options is a variable defined in `C source code'.     =
                                                 =20
 Its value is                                                               =
                                                 =20

 "--srcdir=3D/tmp/editors/emacs-snapshot/work/emacs-27.0.60
 --localstatedir=3D/var
 --without-dbus
 --without-xml2
 --without-gnutl\ s
 --without-x --without-xpm
 --without-jpeg
 --without-tiff
 --without-gif
 --without-png
 --x-includes=3D/usr/X11R7/include
 --x-l\
 ibraries=3D/usr/X11R7/lib
 --prefix=3D/usr/pkg
 --build=3Dx86_64--netbsd
 --host=3Dx86_64--netbsd
 --infodir=3D/usr/pkg/info
 --mandir=3D/us\ r/pkg/man
 --enable-option-checking=3Dyes
 'CFLAGS=3D-O2
 -D_FORTIFY_SOURCE=3D2
 -I/usr/pkg/include
 -I/usr/pkg/include/glib-2.0
 -I/us\
 r/pkg/include/gio-unix-2.0
 -I/usr/pkg/lib/glib-2.0/include
 -I/usr/include
 -I/usr/X11R7/include/freetype2'
 'CPPFLAGS=3D-I/usr/\
 pkg/include
 -I/usr/pkg/include/glib-2.0
 -I/usr/pkg/include/gio-unix-2.0
 -I/usr/pkg/lib/glib-2.0/include
 -I/usr/include -I/u\
 sr/X11R7/include/freetype2'
 'LDFLAGS=3D-L/usr/pkg/lib
 -Wl,-R/usr/pkg/lib
 -L/usr/lib -Wl,-R/usr/lib
 -L/usr/X11R7/lib
 -Wl,-R/us\ r/X11R7/lib'"
                                                                            =
                                                 =20
 Documentation:                                                             =
                                                 =20
 String containing the configuration options Emacs was built with.          =
                                                 =20

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.