NetBSD Problem Report #54944

From kardel@kardel.name  Thu Feb  6 12:25:28 2020
Return-Path: <kardel@kardel.name>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 3A0451A9213
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  6 Feb 2020 12:25:28 +0000 (UTC)
Message-Id: <20200206122523.5AE83DA0D9C@pip.kardel.name>
Date: Thu,  6 Feb 2020 13:25:23 +0100 (CET)
From: kardel@netbsd.org
Reply-To: kardel@netbsd.org
To: gnats-bugs@NetBSD.org
Subject: sysinst SIGSEGV with gpt partitioned disk
X-Send-Pr-Version: 3.95

>Number:         54944
>Category:       bin
>Synopsis:       sysinst SIGSEGV when access a gpt partitions disk
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 06 12:30:00 +0000 2020
>Last-Modified:  Mon Feb 10 21:40:03 +0000 2020
>Originator:     Frank Kardel
>Release:        NetBSD 9.99.45
>Organization:

>Environment:


System: NetBSD pip.kardel.name 9.99.45 NetBSD 9.99.45 (PIPGEN) #7: Wed Feb 5 19:24:51 CET 2020 kardel@pip.kardel.name:/src/NetBSD/act/src/obj.amd64/sys/arch/amd64/compile/PIPGEN amd64
Architecture: x86_64
Machine: amd64
>Description:
	Run sysinst on live 9.99.45 system:
	b) Upgrade NetBSD on a hard disk
	b) Yes
          ┌─────────────────────────┐                                                                                                                                                                                                                   │ Available disks         │                                                                                                                                                                                                                   │                         │                                                                                                                                                                                                                   │>a: current system       │                                                                                                          
          │ b: ld0 (954G)           │                                                                                                                                                                                                                   │ c: EFI System (dk0@ld0) │                                                                                                                                                                                                                   │ d: NVME root (dk1@ld0)  │                                                                                                                                                                                                                   │ e: NVME user (dk2@ld0)  │                                                                                                                                                                                                                   │ f: wd0 (2.7T)   
         │                                                                                                                                                                                                                   │ g: boot00 (dk3@wd0)     │                                                                                                                                                                                                                   │ h: root00 (dk4@wd0)     │                                                                                                                                                                                                                   │ i: swap00 (dk5@wd0)     │                                                                                                                                                                                                                   │ j: raid00 (dk6@wd0)     │                  
                                                                                                                                                                                                  │ k: wd1 (932G)           │                                                                                                                                                                                                                   │ l: wd2 (932G)           │                                                                                                                                                                                                                   │ m: wd3 (2.7T)           │                                                                                                                                                                                                                   │ n: boot01 (dk7@wd3)     │                                               
                                                                                                                                                                     │ o: root01 (dk8@wd3)     │                                                                                                                                                                                                                   │ p: swap01 (dk9@wd3)     │                                                                                                                                                                                                                   │ x: Exit                 │                                                                                                                                                                                                                   └─────────────────────────┘                          

 	b) => SIGSEGV

[New process 1]
Core was generated by `sysinst'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00000001f221f35b in target_already_root () at /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../target.c:187
187             for (ptn = 0; ptn < parts->num_part; ptn++) {
(gdb) bt
#0  0x00000001f221f35b in target_already_root () at /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../target.c:187
#1  0x00000001f2218013 in mount_disks (install=install@entry=0x7f7fffcda1a8) at /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../disks.c:1833
#2  0x00000001f2212385 in do_upgrade () at /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../upgrade.c:90
#3  0x00000001f220e5f3 in opt_act_2_1 (m=<optimized out>, arg=<optimized out>) at menu_defs.c:251
#4  0x00000001f22100e5 in process_menu (num=<optimized out>, arg=0x0) at menu_defs.c:3114
#5  0x00000001f2233649 in main (argc=<optimized out>, argv=<optimized out>) at /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../main.c:267

# gpt show -a ld0
       start        size  index  contents
           0           1         PMBR
           1           1         Pri GPT header
           2          32         Pri GPT table
          34        2014         Unused
        2048       32768      1  GPT part - EFI System
                                 Type: efi
                                 TypeID: c12a7328-f81f-11d2-ba4b-00a0c93ec93b
                                 GUID: ab6a672d-87b3-472c-84ef-06218f8cbe5c
                                 Size: 16384 K
                                 Label: EFI System
                                 Attributes: None
       34816   419430400      2  GPT part - NetBSD FFSv1/FFSv2
                                 Type: ffs
                                 TypeID: 49f48d5a-b10e-11dc-b99b-0019d1879648
                                 GUID: 17bbbb05-fc33-4598-af59-28e65eae4d26
                                 Size: 200 G
                                 Label: NVME root
                                 Attributes: bootme
   419465216  1580944015      3  GPT part - NetBSD FFSv1/FFSv2
                                 Type: ffs
                                 TypeID: 49f48d5a-b10e-11dc-b99b-0019d1879648
                                 GUID: 8de05891-7cb5-4754-b915-84bd3dd0e745
                                 Size: 754 G
                                 Label: NVME user
                                 Attributes: None
  2000409231          32         Sec GPT table
  2000409263           1         Sec GPT header

64k label information is available on request.

Additionally when I try dk1@ld0 I get "No root partition defined.  Cannot continue".
The fstab on dk1 is fine though for normal boot (parsing issue?):
/etc/fstab:
NAME=NVME\ root         /               ffs     rw               1 1
NAME=NVME\ user         /fs/nvme0user   ffs     rw               1 2
kernfs                  /kern           kernfs  rw
ptyfs                   /dev/pts        ptyfs   rw
procfs                  /proc           procfs  rw
/dev/cd0a               /cdrom          cd9660  ro,noauto
tmpfs                   /var/shm        tmpfs   rw,-m1777,-sram%25

>How-To-Repeat:
	see above...
>Fix:
	check for NULL pointer in parts?

>Audit-Trail:
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54944 CVS commit: src/usr.sbin/sysinst
Date: Thu, 6 Feb 2020 16:28:10 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Thu Feb  6 16:28:10 UTC 2020

 Modified Files:
 	src/usr.sbin/sysinst: disks.c txtwalk.c

 Log Message:
 PR bin/54944: deal with escaped spaces in NAME= syntax in /etc/fstab.


 To generate a diff of this commit:
 cvs rdiff -u -r1.63 -r1.64 src/usr.sbin/sysinst/disks.c
 cvs rdiff -u -r1.2 -r1.3 src/usr.sbin/sysinst/txtwalk.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/54944: sysinst SIGSEGV with gpt partitioned disk
Date: Thu, 6 Feb 2020 17:32:20 +0100

 On Thu, Feb 06, 2020 at 12:30:00PM +0000, kardel@netbsd.org wrote:
 > Core was generated by `sysinst'.
 > Program terminated with signal SIGSEGV, Segmentation fault.
 > #0  0x00000001f221f35b in target_already_root () at /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../target.c:187
 > 187             for (ptn = 0; ptn < parts->num_part; ptn++) {
 > (gdb) bt
 > #0  0x00000001f221f35b in target_already_root () at /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../target.c:187

 I can not reproduce nor explain it - parts comes from pm->parts and that is
 checked for being NULL earlier in do_upgrade.

 If you still have the core, can you print "*pm" and "parts" in this frame?

 > Additionally when I try dk1@ld0 I get "No root partition defined.  Cannot continue".
 > The fstab on dk1 is fine though for normal boot (parsing issue?):
 > /etc/fstab:
 > NAME=NVME\ root         /               ffs     rw               1 1

 Yep, it was confused by the "\ ", should be fixed.

 Martin

From: Frank Kardel <kardel@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/54944: sysinst SIGSEGV with gpt partitioned disk
Date: Thu, 6 Feb 2020 17:40:04 +0100

 #0  0x000000016181f35b in target_already_root () at 
 /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../target.c:187
 187             for (ptn = 0; ptn < parts->num_part; ptn++) {
 (gdb) print *pm
 $1 = {refdev = 0x0, diskdev = "ld0", '\000' <repeats 26 times>, 
 diskdev_descr = "ld0 (954G)\000dk1@ld0)", '\000' <repeats 235 times>, 
 parts = 0x76e7fc597380, no_mbr = false, no_part = false, cur_system = 
 false, sectorsize = 512,
    dlcyl = 124519, dlhead = 255, dlsec = 63, dlcylsize = 16065, 
 current_cylsize = 0, dlsize = 2000409264, ptstart = 0, ptsize = 0, 
 max_chs = 0, bootstart = 0, bootsize = 0, mounted = 0x0, unsaved = 
 false, found = true, blocked = 0, l = {
      sle_next = 0x0}}
 (gdb) print pm->parts
 $2 = (struct disk_partitions *) 0x76e7fc597380
 (gdb) print *pm->parts
 $3 = {pscheme = 0x161a4abe0 <mbr_parts>, disk = 0x76e7fc8470c8 "ld0", 
 bytes_per_sector = 512, num_part = 1, disk_start = 0, disk_size = 
 2000409264, free_space = 0, parent = 0x0}
 (gdb)


 On 02/06/20 17:35, Martin Husemann wrote:
 > The following reply was made to PR bin/54944; it has been noted by GNATS.
 >
 > From: Martin Husemann <martin@duskware.de>
 > To: gnats-bugs@netbsd.org
 > Cc:
 > Subject: Re: bin/54944: sysinst SIGSEGV with gpt partitioned disk
 > Date: Thu, 6 Feb 2020 17:32:20 +0100
 >
 >   On Thu, Feb 06, 2020 at 12:30:00PM +0000, kardel@netbsd.org wrote:
 >   > Core was generated by `sysinst'.
 >   > Program terminated with signal SIGSEGV, Segmentation fault.
 >   > #0  0x00000001f221f35b in target_already_root () at /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../target.c:187
 >   > 187             for (ptn = 0; ptn < parts->num_part; ptn++) {
 >   > (gdb) bt
 >   > #0  0x00000001f221f35b in target_already_root () at /src/NetBSD/act/src/usr.sbin/sysinst/arch/amd64/../../target.c:187
 >   
 >   I can not reproduce nor explain it - parts comes from pm->parts and that is
 >   checked for being NULL earlier in do_upgrade.
 >   
 >   If you still have the core, can you print "*pm" and "parts" in this frame?
 >   
 >   > Additionally when I try dk1@ld0 I get "No root partition defined.  Cannot continue".
 >   > The fstab on dk1 is fine though for normal boot (parsing issue?):
 >   > /etc/fstab:
 >   > NAME=NVME\ root         /               ffs     rw               1 1
 >   
 >   Yep, it was confused by the "\ ", should be fixed.
 >   
 >   Martin
 >   

From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/54944: sysinst SIGSEGV with gpt partitioned disk
Date: Thu, 6 Feb 2020 18:06:40 +0100

 On Thu, Feb 06, 2020 at 04:45:02PM +0000, Frank Kardel wrote:
 >  (gdb) print pm->parts
 >  $2 = (struct disk_partitions *) 0x76e7fc597380
 >  (gdb) print *pm->parts
 >  $3 = {pscheme = 0x161a4abe0 <mbr_parts>, disk = 0x76e7fc8470c8 "ld0", 
 >  bytes_per_sector = 512, num_part = 1, disk_start = 0, disk_size = 
 >  2000409264, free_space = 0, parent = 0x0}

 Huh, why does it think there are MBR partitions on that disk?
 ld0 was the correct disk, wasn't it?

 It should try gpt first, can you show the output of

 	gpt -rq header ld0

 please?

 Martin

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54944 CVS commit: src/usr.sbin/sysinst
Date: Thu, 6 Feb 2020 18:07:22 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Thu Feb  6 18:07:22 UTC 2020

 Modified Files:
 	src/usr.sbin/sysinst: mbr.c

 Log Message:
 PR bin/54944: explicitly reject GPT protective MBRs.


 To generate a diff of this commit:
 cvs rdiff -u -r1.30 -r1.31 src/usr.sbin/sysinst/mbr.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Frank Kardel <kardel@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/54944: sysinst SIGSEGV with gpt partitioned disk
Date: Thu, 6 Feb 2020 19:11:11 +0100

 # gpt -rq header ld0
 Media Size: 1024209543168 (954G)
 Sector Size: 512
 Number of Sectors: 2000409264 (2G)

 Header Information:
 - GPT Header Revision: 1.0
 - First Data Sector: 34 (34B)
 - Last Data Sector: 2000409230 (2G)
 - Media GUID: 45f43c24-e64a-4bd4-8720-12e1646e9617
 - Number of GPT Entries: 128


 On 02/06/20 18:10, Martin Husemann wrote:
 > gpt -rq header ld0

From: Frank Kardel <kardel@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: PR/54944 CVS commit: src/usr.sbin/sysinst
Date: Thu, 6 Feb 2020 19:35:34 +0100

 That made the SISEGV go away.
 I still get "No root partition defined.  Cannot continue" for ld0 or 
 dk1@ld0.

 dk1@ld0:/etc/fstab in "vi set list mode"
 # NetBSD /etc/fstab$
 # See /usr/share/examples/fstab/ for more examples.$
 NAME=NVME\ root^I^I/^I^Iffs^Irw^I^I 1 1$
 NAME=NVME\ user^I^I/fs/nvme0user^Iffs^Irw^I^I 1 2$
 kernfs^I^I^I/kern^I^Ikernfs^Irw$
 ptyfs^I^I^I/dev/pts^Iptyfs^Irw$
 procfs^I^I^I/proc^I^Iprocfs^Irw$
 /dev/cd0a^I^I/cdrom^I^Icd9660^Iro,noauto$
 tmpfs^I^I^I/var/shm^Itmpfs^Irw,-m1777,-sram%25$


 On 02/06/20 19:10, Martin Husemann wrote:
 > The following reply was made to PR bin/54944; it has been noted by GNATS.
 >
 > From: "Martin Husemann" <martin@netbsd.org>
 > To: gnats-bugs@gnats.NetBSD.org
 > Cc:
 > Subject: PR/54944 CVS commit: src/usr.sbin/sysinst
 > Date: Thu, 6 Feb 2020 18:07:22 +0000
 >
 >   Module Name:	src
 >   Committed By:	martin
 >   Date:		Thu Feb  6 18:07:22 UTC 2020
 >   
 >   Modified Files:
 >   	src/usr.sbin/sysinst: mbr.c
 >   
 >   Log Message:
 >   PR bin/54944: explicitly reject GPT protective MBRs.
 >   
 >   
 >   To generate a diff of this commit:
 >   cvs rdiff -u -r1.30 -r1.31 src/usr.sbin/sysinst/mbr.c
 >   
 >   Please note that diffs are not public domain; they are subject to the
 >   copyright notices on the relevant files.
 >   


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54944 CVS commit: src/usr.sbin/sysinst
Date: Thu, 6 Feb 2020 19:08:38 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Thu Feb  6 19:08:38 UTC 2020

 Modified Files:
 	src/usr.sbin/sysinst: disks.c upgrade.c

 Log Message:
 PR bin/54944: make the "explicit single wedge" selection also work for
 upgrades.


 To generate a diff of this commit:
 cvs rdiff -u -r1.64 -r1.65 src/usr.sbin/sysinst/disks.c
 cvs rdiff -u -r1.14 -r1.15 src/usr.sbin/sysinst/upgrade.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Frank Kardel <kardel@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: PR/54944 CVS commit: src/usr.sbin/sysinst
Date: Thu, 6 Feb 2020 20:28:17 +0100

 Now selection of dk1@ld0 progresses to set selection.

 Is the installer expected to manage the update of gpt ld0 with EFI and a 
 root partition automagically? Or is the
 "No root partition defined.  Cannot continue" the expected behavior?

From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: PR/54944 CVS commit: src/usr.sbin/sysinst
Date: Thu, 6 Feb 2020 20:51:55 +0100

 On Thu, Feb 06, 2020 at 07:30:01PM +0000, Frank Kardel wrote:
 >  Is the installer expected to manage the update of gpt ld0 with EFI and a 
 >  root partition automagically? Or is the
 >  "No root partition defined.  Cannot continue" the expected behavior?

 No, of course not, but I have been unable to reproduce that locally yet.

 Hmm, far fetch, but was that filesystem last mounted somewhere else?

 Martin

From: Frank Kardel <kardel@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: PR/54944 CVS commit: src/usr.sbin/sysinst
Date: Thu, 6 Feb 2020 21:04:57 +0100

 The labels exist for ~2 years. The file system was always mounted in 
 -current variants of NetBSD only.

 It was formatted for normal bios boot in the beginning and later changed 
 to EFI boot.

 I did send you the first 64k of the NVME stick.

 Frank

 On 02/06/20 20:55, Martin Husemann wrote:
 > The following reply was made to PR bin/54944; it has been noted by GNATS.
 >
 > From: Martin Husemann <martin@duskware.de>
 > To: gnats-bugs@netbsd.org
 > Cc:
 > Subject: Re: PR/54944 CVS commit: src/usr.sbin/sysinst
 > Date: Thu, 6 Feb 2020 20:51:55 +0100
 >
 >   On Thu, Feb 06, 2020 at 07:30:01PM +0000, Frank Kardel wrote:
 >   >  Is the installer expected to manage the update of gpt ld0 with EFI and a
 >   >  root partition automagically? Or is the
 >   >  "No root partition defined.  Cannot continue" the expected behavior?
 >   
 >   No, of course not, but I have been unable to reproduce that locally yet.
 >   
 >   Hmm, far fetch, but was that filesystem last mounted somewhere else?
 >   
 >   Martin
 >   

From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: PR/54944 CVS commit: src/usr.sbin/sysinst
Date: Thu, 6 Feb 2020 21:15:43 +0100

 On Thu, Feb 06, 2020 at 08:10:01PM +0000, Frank Kardel wrote:
 >  The labels exist for ~2 years. The file system was always mounted in 
 >  -current variants of NetBSD only.

 No, I mean has it last been mounted on, say, /mnt2 or whatever?

 Can you try mounting it manually on /targetroot, unmounting again and then
 repeat the sysinst test?

 Martin

From: Frank Kardel <kardel@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: PR/54944 CVS commit: src/usr.sbin/sysinst
Date: Thu, 6 Feb 2020 21:29:10 +0100

 Same root not found.

 I do run the tests with a current 9.99.45 kernel but with a chroot into 
 the BUILD directory with devices

 created and ptyfs mounted. But I think that should not make a difference.

 Anything else I can help with debugging?

 Frank


 On 02/06/20 21:20, Martin Husemann wrote:
 > The following reply was made to PR bin/54944; it has been noted by GNATS.
 >
 > From: Martin Husemann <martin@duskware.de>
 > To: gnats-bugs@netbsd.org
 > Cc:
 > Subject: Re: PR/54944 CVS commit: src/usr.sbin/sysinst
 > Date: Thu, 6 Feb 2020 21:15:43 +0100
 >
 >   On Thu, Feb 06, 2020 at 08:10:01PM +0000, Frank Kardel wrote:
 >   >  The labels exist for ~2 years. The file system was always mounted in
 >   >  -current variants of NetBSD only.
 >   
 >   No, I mean has it last been mounted on, say, /mnt2 or whatever?
 >   
 >   Can you try mounting it manually on /targetroot, unmounting again and then
 >   repeat the sysinst test?
 >   
 >   Martin
 >   

From: Frank Kardel <kardel@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: PR/54944 CVS commit: src/usr.sbin/sysinst
Date: Sat, 8 Feb 2020 09:38:52 +0100

 Mount a file system from within a chroot environment will leak the
 actual path.

 #pip: 9:27 / [30]# mount /dev/dk1 /targetroot
 #pip: 9:28 / [31]# umount /targetroot/
 #pip: 9:29 / [32]# fsdb -nf /dev/rdk1
 ** /dev/rdk1 (NO WRITE)
 ** File system is already clean
 Editing file system `/dev/rdk1'
 Last Mounted on /targetroot
 current inode: directory
 I=2 MODE=40755 SIZE=2048
          MTIME=Feb  2 10:15:11 2020 [0 nsec]
          CTIME=Feb  5 21:37:33 2020 [233878482 nsec]
          ATIME=Feb  5 21:43:52 2020 [313125735 nsec]
 OWNER=root GRP=wheel LINKCNT=33 FLAGS=0x0 BLKCNT=0x8 GEN=0x58ed0e25
 fsdb (inum: 2)> q
 Exit 255
 #pip: 9:29 / [33]# chroot /src/NetBSD/act/BUILD.amd64
 pip# fsdb -nf /dev/rdk1
 ** /dev/rdk1 (NO WRITE)
 ** File system is already clean
 Editing file system `/dev/rdk1'
 Last Mounted on /targetroot
 current inode: directory
 I=2 MODE=40755 SIZE=2048
          MTIME=Feb  2 09:15:11 2020 [0 nsec]
          CTIME=Feb  5 20:37:33 2020 [233878482 nsec]
          ATIME=Feb  5 20:43:52 2020 [313125735 nsec]
 OWNER=root GRP=wheel LINKCNT=33 FLAGS=0x0 BLKCNT=0x8 GEN=0x58ed0e25
 fsdb (inum: 2)> q
 pip# mount /dev/dk1 /targetroot
 pip# umount /targetroot
 pip# fsdb -nf /dev/rdk1
 ** /dev/rdk1 (NO WRITE)
 Editing file system `/dev/rdk1'
 Last Mounted on /src/NetBSD/act/BUILD.amd64/targetroot
 current inode: directory
 I=2 MODE=40755 SIZE=2048
          MTIME=Feb  2 09:15:11 2020 [0 nsec]
          CTIME=Feb  5 20:37:33 2020 [233878482 nsec]
          ATIME=Feb  5 20:43:52 2020 [313125735 nsec]
 OWNER=root GRP=wheel LINKCNT=33 FLAGS=0x0 BLKCNT=0x8 GEN=0x58ed0e25
 fsdb (inum: 2)> q
 pip#

From: "Manuel Bouyer" <bouyer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54944 CVS commit: [netbsd-9] src/usr.sbin/sysinst
Date: Mon, 10 Feb 2020 21:39:38 +0000

 Module Name:	src
 Committed By:	bouyer
 Date:		Mon Feb 10 21:39:38 UTC 2020

 Modified Files:
 	src/usr.sbin/sysinst [netbsd-9]: bsddisklabel.c defs.h disklabel.c
 	    disks.c mbr.c msg.mi.de msg.mi.en msg.mi.es msg.mi.fr msg.mi.pl
 	    partman.c target.c txtwalk.c upgrade.c
 	src/usr.sbin/sysinst/arch/hp300 [netbsd-9]: md.c
 	src/usr.sbin/sysinst/arch/i386 [netbsd-9]: md.c
 	src/usr.sbin/sysinst/arch/mac68k [netbsd-9]: md.c
 	src/usr.sbin/sysinst/arch/mvme68k [netbsd-9]: md.c msg.md.de msg.md.en
 	    msg.md.es msg.md.fr msg.md.pl
 	src/usr.sbin/sysinst/arch/x68k [netbsd-9]: md.c msg.md.en

 Log Message:
 Pull up following revision(s) (requested by martin in ticket #693):
 	usr.sbin/sysinst/arch/x68k/msg.md.en: revision 1.2
 	usr.sbin/sysinst/arch/x68k/md.c: revision 1.10
 	usr.sbin/sysinst/arch/mvme68k/msg.md.fr: revision 1.2
 	usr.sbin/sysinst/arch/x68k/msg.md.en: revision 1.3
 	usr.sbin/sysinst/arch/mvme68k/msg.md.fr: revision 1.3
 	usr.sbin/sysinst/msg.mi.en: revision 1.28
 	usr.sbin/sysinst/arch/hp300/md.c: revision 1.10
 	usr.sbin/sysinst/msg.mi.es: revision 1.22
 	usr.sbin/sysinst/target.c: revision 1.12
 	usr.sbin/sysinst/arch/mvme68k/md.c: revision 1.10
 	usr.sbin/sysinst/arch/i386/md.c: revision 1.30
 	usr.sbin/sysinst/arch/mvme68k/msg.md.pl: revision 1.2
 	usr.sbin/sysinst/arch/mvme68k/msg.md.pl: revision 1.3
 	usr.sbin/sysinst/bsddisklabel.c: revision 1.39
 	usr.sbin/sysinst/arch/mvme68k/msg.md.de: revision 1.2
 	usr.sbin/sysinst/arch/mac68k/md.c: revision 1.9
 	usr.sbin/sysinst/disklabel.c: revision 1.35
 	usr.sbin/sysinst/arch/mvme68k/msg.md.de: revision 1.3
 	usr.sbin/sysinst/defs.h: revision 1.55
 	usr.sbin/sysinst/disks.c: revision 1.63
 	usr.sbin/sysinst/disks.c: revision 1.64
 	usr.sbin/sysinst/mbr.c: revision 1.31
 	usr.sbin/sysinst/disks.c: revision 1.65
 	usr.sbin/sysinst/txtwalk.c: revision 1.3
 	usr.sbin/sysinst/txtwalk.c: revision 1.4
 	usr.sbin/sysinst/arch/mvme68k/msg.md.en: revision 1.2
 	usr.sbin/sysinst/arch/mvme68k/msg.md.en: revision 1.3
 	usr.sbin/sysinst/msg.mi.fr: revision 1.26
 	usr.sbin/sysinst/msg.mi.pl: revision 1.29
 	usr.sbin/sysinst/arch/mvme68k/msg.md.es: revision 1.2
 	usr.sbin/sysinst/upgrade.c: revision 1.15
 	usr.sbin/sysinst/arch/mvme68k/msg.md.es: revision 1.3
 	usr.sbin/sysinst/upgrade.c: revision 1.16
 	usr.sbin/sysinst/partman.c: revision 1.50
 	usr.sbin/sysinst/msg.mi.de: revision 1.21
 remove unused "emptypart" message (or moved to ifdef notyet area)
 PR install/54921: message "ordering" takes a %s argument.
 PR install/54921: skip non-user partitions when checking for overlaps
 bootxx_name() - fix oversight in previous change (do not assume first
 partition is the root partition)
 PR install/54934: always use -f on the installboot invocation. We come
 here post-newfs (and maybe should have dd'd zeros to the start of the
 disk before newfs instead).
 Remove a bogus assert: when reading disklabel partitions and the outer
 (MBR) partitioning has changed, but the changes have not yet been written
 back to disk, we need to ignore the kernels idea of the disklabel and
 instead continue with an empty one.
 Deal with partitioning schemes having no inner counterpart.
 Avoid NULL derefs.
 Do not assum a partitioning scheme that supports innner partitions always
 needs to actually have such partitions defined.
 PR bin/54944: deal with escaped spaces in NAME= syntax in /etc/fstab.
 PR bin/54944: explicitly reject GPT protective MBRs.
 PR bin/54944: make the "explicit single wedge" selection also work for
 upgrades.
 Reformat a query to add an automatically detected swap partition
 so it fits on narrow screens.
 Make re-install sets also work for an explicit selected root wedge
 Fix copy&pasto in previous - from kre.
 Only a single partition can ever have the "extend" flag (grow to available
 size).
 Do not use -P for tar extractions - the in tree tar has been fixed.
 Finish conversion to generic partitioning backend


 To generate a diff of this commit:
 cvs rdiff -u -r1.23.2.9 -r1.23.2.10 src/usr.sbin/sysinst/bsddisklabel.c
 cvs rdiff -u -r1.42.2.6 -r1.42.2.7 src/usr.sbin/sysinst/defs.h
 cvs rdiff -u -r1.10.2.8 -r1.10.2.9 src/usr.sbin/sysinst/disklabel.c
 cvs rdiff -u -r1.44.2.13 -r1.44.2.14 src/usr.sbin/sysinst/disks.c
 cvs rdiff -u -r1.19.2.5 -r1.19.2.6 src/usr.sbin/sysinst/mbr.c
 cvs rdiff -u -r1.13.2.6 -r1.13.2.7 src/usr.sbin/sysinst/msg.mi.de
 cvs rdiff -u -r1.19.2.7 -r1.19.2.8 src/usr.sbin/sysinst/msg.mi.en
 cvs rdiff -u -r1.14.2.6 -r1.14.2.7 src/usr.sbin/sysinst/msg.mi.es
 cvs rdiff -u -r1.17.2.7 -r1.17.2.8 src/usr.sbin/sysinst/msg.mi.fr
 cvs rdiff -u -r1.20.2.7 -r1.20.2.8 src/usr.sbin/sysinst/msg.mi.pl
 cvs rdiff -u -r1.41.2.4 -r1.41.2.5 src/usr.sbin/sysinst/partman.c
 cvs rdiff -u -r1.8.2.3 -r1.8.2.4 src/usr.sbin/sysinst/target.c
 cvs rdiff -u -r1.1.30.1 -r1.1.30.2 src/usr.sbin/sysinst/txtwalk.c
 cvs rdiff -u -r1.12.2.2 -r1.12.2.3 src/usr.sbin/sysinst/upgrade.c
 cvs rdiff -u -r1.8.2.1 -r1.8.2.2 src/usr.sbin/sysinst/arch/hp300/md.c
 cvs rdiff -u -r1.20.2.5 -r1.20.2.6 src/usr.sbin/sysinst/arch/i386/md.c
 cvs rdiff -u -r1.8 -r1.8.2.1 src/usr.sbin/sysinst/arch/mac68k/md.c
 cvs rdiff -u -r1.8.2.1 -r1.8.2.2 src/usr.sbin/sysinst/arch/mvme68k/md.c
 cvs rdiff -u -r1.1 -r1.1.30.1 src/usr.sbin/sysinst/arch/mvme68k/msg.md.de \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.en \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.es \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.fr \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.pl
 cvs rdiff -u -r1.8.2.1 -r1.8.2.2 src/usr.sbin/sysinst/arch/x68k/md.c
 cvs rdiff -u -r1.1 -r1.1.30.1 src/usr.sbin/sysinst/arch/x68k/msg.md.en

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.