NetBSD Problem Report #55215

From tsutsui@ceres.dti.ne.jp  Mon Apr 27 21:06:07 2020
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 7F9BE1A9217
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 27 Apr 2020 21:06:07 +0000 (UTC)
Message-Id: <202004272105.03RL5vZw005922@ceres.dti.ne.jp>
Date: Tue, 28 Apr 2020 06:05:57 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: firefox-l10n-74.0 and later langpacks are no longer loaded
X-Send-Pr-Version: 3.95

>Number:         55215
>Category:       pkg
>Synopsis:       firefox-l10n-74.0 and later langpacks are no longer loaded
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ryoon
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 27 21:10:00 +0000 2020
>Closed-Date:    Tue Apr 28 16:09:50 +0000 2020
>Last-Modified:  Tue Apr 28 16:09:50 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0 + pkgsrc-2020Q1 (and firefox-75.0 from HEAD)
>Organization:
>Environment:
System: NetBSD mirage 9.0 NetBSD 9.0 (GENERIC)
Architecture: i386
Machine: i386
>Description:
After firefox is updated to 74.0, language packs provided by
firefox-l10n package are no longer loaded by default and default
en-US is always used even LANG is set as ja_JP.UTF-8 etc.
[Tools] -> [Add-ons] menu does not show "language packs" either.

>How-To-Repeat:
See above.

>Fix:
Maybe this upstream's "extension sideloading" change on
firefox 74 affects this:
 https://blog.mozilla.org/addons/2019/10/31/firefox-to-discontinue-sideloaded-extensions/

It looks working to move all langpack xpi files
from current ${PREFIX}/lib/firefox/browser/extensions
to ${PREFIX}/lib/firefox/distributions/extensions
as upstream scripts do:
 https://searchfox.org/mozilla-central/source/taskcluster/docker/firefox-flatpak/runme.sh#120
 https://searchfox.org/mozilla-central/source/taskcluster/docker/firefox-snap/runme.sh#56 

---

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/www/firefox-l10n/Makefile,v
retrieving revision 1.173
diff -u -p -d -r1.173 Makefile
--- Makefile	9 Apr 2020 14:02:15 -0000	1.173
+++ Makefile	27 Apr 2020 20:55:55 -0000
@@ -1,6 +1,7 @@
 # $NetBSD: Makefile,v 1.173 2020/04/09 14:02:15 ryoon Exp $

 FIREFOX_VER=	75.0
+PKGREVISION=	1
 PKGNAME=	firefox-l10n-${FIREFOX_VER:S/esr//}
 DISTNAME=	# empty
 CATEGORIES=	www
@@ -19,7 +20,7 @@ DISTFILES=	${FIREFOX_LOCALES:=.xpi}

 NO_BUILD=	yes

-INSTALLATION_DIRS=	lib/firefox/browser/extensions
+INSTALLATION_DIRS=	lib/firefox/distribution/extensions

 FIREFOX_LOCALES= \
 	ach af an ar ast az be bg bn br bs ca cak cs cy da de dsb	\


---
Izumi Tsutsui

>Release-Note:

>Audit-Trail:
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@netbsd.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: Re: pkg/55215: firefox-l10n-74.0 and later langpacks are no longer
	 loaded
Date: Tue, 28 Apr 2020 06:33:07 +0900

 The attached patch in the PR is incomplete:

 ---

 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/www/firefox-l10n/Makefile,v
 retrieving revision 1.173
 diff -u -p -d -r1.173 Makefile
 --- Makefile	9 Apr 2020 14:02:15 -0000	1.173
 +++ Makefile	27 Apr 2020 21:30:29 -0000
 @@ -1,6 +1,7 @@
  # $NetBSD: Makefile,v 1.173 2020/04/09 14:02:15 ryoon Exp $

  FIREFOX_VER=	75.0
 +PKGREVISION=	1
  PKGNAME=	firefox-l10n-${FIREFOX_VER:S/esr//}
  DISTNAME=	# empty
  CATEGORIES=	www
 @@ -19,7 +20,7 @@ DISTFILES=	${FIREFOX_LOCALES:=.xpi}

  NO_BUILD=	yes

 -INSTALLATION_DIRS=	lib/firefox/browser/extensions
 +INSTALLATION_DIRS=	lib/firefox/distribution/extensions

  FIREFOX_LOCALES= \
  	ach af an ar ast az be bg bn br bs ca cak cs cy da de dsb	\
 @@ -30,7 +31,7 @@ FIREFOX_LOCALES= \
  	pa-IN pl pt-BR pt-PT rm ro ru si sk sl son sq sr sv-SE		\
  	ta te th tr uk uz vi xh zh-CN zh-TW

 -EXTENSIONS_DIR=		${PREFIX}/lib/firefox/browser/extensions
 +EXTENSIONS_DIR=		${PREFIX}/lib/firefox/distribution/extensions

  do-install:
  .for locale in ${FIREFOX_LOCALES}

From: coypu@sdf.org
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/55215: firefox-l10n-74.0 and later langpacks are no longer
 loaded
Date: Mon, 27 Apr 2020 23:37:22 +0000

 LGTM

Responsible-Changed-From-To: pkg-manager->ryoon
Responsible-Changed-By: ryoon@NetBSD.org
Responsible-Changed-When: Tue, 28 Apr 2020 12:11:59 +0000
Responsible-Changed-Why:
I will take this.


From: "Ryo ONODERA" <ryoon@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55215 CVS commit: pkgsrc/www/firefox-l10n
Date: Tue, 28 Apr 2020 12:17:08 +0000

 Module Name:	pkgsrc
 Committed By:	ryoon
 Date:		Tue Apr 28 12:17:08 UTC 2020

 Modified Files:
 	pkgsrc/www/firefox-l10n: Makefile PLIST

 Log Message:
 firefox-l10n: Load languagae packs properly, bump PKGREVISION

 * Fix PR pkg/55215: firefox-l10n-74.0 and later langpacks are
   no longer loaded.


 To generate a diff of this commit:
 cvs rdiff -u -r1.173 -r1.174 pkgsrc/www/firefox-l10n/Makefile
 cvs rdiff -u -r1.64 -r1.65 pkgsrc/www/firefox-l10n/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Tue, 28 Apr 2020 16:09:50 +0000
State-Changed-Why:
Confirmed fixed (pkgsrc-2020Q1 + pulled firefox 75.0).


>Unformatted:

Home	PR Database Search