NetBSD Problem Report #56077
From tsutsui@ceres.dti.ne.jp Sun Mar 28 02:05:41 2021
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 844B01A9217
for <gnats-bugs@gnats.NetBSD.org>; Sun, 28 Mar 2021 02:05:41 +0000 (UTC)
Message-Id: <202103280205.12S25W3L024133@ceres.dti.ne.jp>
Date: Sun, 28 Mar 2021 11:05:32 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: netbsd-9 sparc GENERIC has options DIAGNOSTIC
X-Send-Pr-Version: 3.95
>Number: 56077
>Category: port-sparc
>Synopsis: netbsd-9 sparc GENERIC has options DIAGNOSTIC
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: port-sparc-maintainer
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sun Mar 28 02:10:00 +0000 2021
>Closed-Date: Thu Apr 22 15:37:13 +0000 2021
>Last-Modified: Thu Apr 22 15:37:13 +0000 2021
>Originator: Izumi Tsutsui
>Release: NetBSD 9.1
>Organization:
>Environment:
System: NetBSD 9.1 (GENERIC) #0: Sun Oct 18 19:24:30 UTC 2020
mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/sparc/compile/GENERIC
Architecture: sparc
Machine: sparc
>Description:
sys/arch/sparc/compile/GENERIC in netbsd-9 has
options DIAGNOSTIC
line, but it seems missed in the following commit:
https://mail-index.netbsd.org/source-changes/2019/11/21/msg111044.html
>> Log Message:
>> In preparation for the upcoming release, turn off DIAGNOSTIC in most
>> kernel configs, modules and libc.
Note sys/arch/zaurus/conf/GENERIC_C700 has it too.
>How-To-Repeat:
Code inspection. (no netbsd-9 changes)
(or audioplay(1) on audioamd(4) triggers KASSERT)
>Fix:
Just comment out it?
---
Izumi Tsutsui
>Release-Note:
>Audit-Trail:
From: matthew green <mrg@eterna.com.au>
To: gnats-bugs@netbsd.org, Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Cc: port-sparc-maintainer@netbsd.org, gnats-admin@netbsd.org,
netbsd-bugs@netbsd.org
Subject: re: port-sparc/56077: netbsd-9 sparc GENERIC has options DIAGNOSTIC
Date: Sun, 28 Mar 2021 14:20:19 +1100
> >How-To-Repeat:
> Code inspection. (no netbsd-9 changes)
> (or audioplay(1) on audioamd(4) triggers KASSERT)
what's the KASSERT? is it fixed in -current? can we pullup
the fix? :-)
> >Fix:
> Just comment out it?
IMO, we should both fix the bug *and* comment it in -9.
please send a pullup for this (and the GENERIC_C700 one
too) to be disabled.
thanks.
.mrg.
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: mrg@eterna.com.au
Cc: gnats-bugs@netbsd.org, tsutsui@ceres.dti.ne.jp
Subject: Re: port-sparc/56077: netbsd-9 sparc GENERIC has options DIAGNOSTIC
Date: Sun, 28 Mar 2021 13:18:10 +0900
mrg@ wrote:
> what's the KASSERT?
Filed as PR/56078 ;-)
> is it fixed in -current? can we pullup
> the fix? :-)
audioamd(4) (and all am7930 audio devices including
bba(4) on alpha and vsaudio(4) on vax) were overhauled'ed
in -current.
http://www.nerv.org/netbsd/?q=id:20200912T051916Z.e3238134d8e846b3fdc2c04ed4e77227e17ac90a
A suggested simple diff for netbsd-9 is attached in the PR.
---
Izumi Tsutsui
State-Changed-From-To: open->needs-pullups
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Mon, 29 Mar 2021 13:38:48 +0000
State-Changed-Why:
sparc confirmed working without DIAGONSTIC.
I will have to dig out my zaurus SL-C700 soon.
State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Tue, 20 Apr 2021 16:55:23 +0000
State-Changed-Why:
[pullup-9 #1249]
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/56077 CVS commit: [netbsd-9] src/sys/arch/sparc/conf
Date: Wed, 21 Apr 2021 18:11:06 +0000
Module Name: src
Committed By: martin
Date: Wed Apr 21 18:11:06 UTC 2021
Modified Files:
src/sys/arch/sparc/conf [netbsd-9]: GENERIC
Log Message:
Apply patch, requested by tsutsui in ticket #1249:
sys/arch/sparc/conf/GENERIC (apply patch)
PR 56077: remove DIAGNOSTIC from sparc kernel.
To generate a diff of this commit:
cvs rdiff -u -r1.267 -r1.267.2.1 src/sys/arch/sparc/conf/GENERIC
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: pending-pullups->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Thu, 22 Apr 2021 15:37:13 +0000
State-Changed-Why:
Applied.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.