NetBSD Problem Report #57038

From triaxx@netbsd.org  Fri Sep 30 13:21:32 2022
Return-Path: <triaxx@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E93151A923C
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 30 Sep 2022 13:21:31 +0000 (UTC)
Message-Id: <20220930132130.765D61A923D@mollari.NetBSD.org>
Date: Fri, 30 Sep 2022 13:21:30 +0000 (UTC)
From: triaxx@netbsd.org
Reply-To: triaxx@netbsd.org
To: gnats-bugs@NetBSD.org
Subject: pkglint warns missing definitions that are actually in PLIST_VARS
X-Send-Pr-Version: 3.95

>Number:         57038
>Category:       pkg
>Synopsis:       pkglint warns missing definitions that are actually in PLIST_VARS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rillig
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 30 13:25:00 +0000 2022
>Closed-Date:    Sun Oct 02 15:12:04 +0000 2022
>Last-Modified:  Thu Oct 06 22:34:00 +0000 2022
>Originator:     Frédéric Fauberteau
>Release:        Darwin 21.6.0
>Organization:

>Environment:
System: Darwin arbiter.local 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:20:05 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T8101 arm64
Architecture: arm64
Machine: arm64
>Description:
In audio/cmus, an optional group "mod" defines mikmod and modplug variables. Pkglint doesn't seem to see them in PLIST_VARS while they actually are according to make show-var.
>How-To-Repeat:
% cd pkgsrc/audio/cmus
% pkglint --version
22.2.7
% pkglint
WARN: options.mk:140: PLIST.mikmod is defined, but "mikmod" is not added to PLIST_VARS in this file.
WARN: options.mk:146: PLIST.modplug is defined, but "modplug" is not added to PLIST_VARS in this file.
NOTE: Please only commit changes that ahoka@NetBSD.org would approve.
2 warnings and 1 note found.
(Run "pkglint -e" to show explanations.)
% bmake show-var VARNAME=PLIST_VARS
coreaudio sunaudio oss alsa flac mad vorbis libao musepack faad wavpack ffmpeg opus jack pulseaudio modplug mikmod
>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: gnats-admin->rillig
Responsible-Changed-By: rillig@NetBSD.org
Responsible-Changed-When: Sun, 02 Oct 2022 13:26:01 +0000
Responsible-Changed-Why:
Over to maintainer.


From: "Roland Illig" <rillig@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57038 CVS commit: pkgsrc/pkgtools/pkglint
Date: Sun, 2 Oct 2022 14:39:37 +0000

 Module Name:	pkgsrc
 Committed By:	rillig
 Date:		Sun Oct  2 14:39:37 UTC 2022

 Modified Files:
 	pkgsrc/pkgtools/pkglint: Makefile
 	pkgsrc/pkgtools/pkglint/files: mklines.go options_test.go pkgsrc.go
 	    substcontext.go tools.go util.go varalignblock.go vardefs.go

 Log Message:
 pkgtools/pkglint: update to 22.3.0

 Changes since 22.2.7:

 Pkglint no longer wrongly warns about package options from optional or
 required option groups. Fixes PR 57038.


 To generate a diff of this commit:
 cvs rdiff -u -r1.730 -r1.731 pkgsrc/pkgtools/pkglint/Makefile
 cvs rdiff -u -r1.74 -r1.75 pkgsrc/pkgtools/pkglint/files/mklines.go
 cvs rdiff -u -r1.25 -r1.26 pkgsrc/pkgtools/pkglint/files/options_test.go \
     pkgsrc/pkgtools/pkglint/files/tools.go
 cvs rdiff -u -r1.66 -r1.67 pkgsrc/pkgtools/pkglint/files/pkgsrc.go
 cvs rdiff -u -r1.39 -r1.40 pkgsrc/pkgtools/pkglint/files/substcontext.go
 cvs rdiff -u -r1.83 -r1.84 pkgsrc/pkgtools/pkglint/files/util.go
 cvs rdiff -u -r1.19 -r1.20 pkgsrc/pkgtools/pkglint/files/varalignblock.go
 cvs rdiff -u -r1.105 -r1.106 pkgsrc/pkgtools/pkglint/files/vardefs.go

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: rillig@NetBSD.org
State-Changed-When: Sun, 02 Oct 2022 15:12:04 +0000
State-Changed-Why:
Fixed in pkglint 22.3.0, released a few minutes ago.
Thanks for the PR.


>Unformatted:

Home	PR Database Search