NetBSD Problem Report #58200

From www@netbsd.org  Fri Apr 26 15:33:27 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 23FBE1A9238
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 26 Apr 2024 15:33:27 +0000 (UTC)
Message-Id: <20240426153325.B31B11A923B@mollari.NetBSD.org>
Date: Fri, 26 Apr 2024 15:33:25 +0000 (UTC)
From: hashikaw@mail.ru
Reply-To: hashikaw@mail.ru
To: gnats-bugs@NetBSD.org
Subject: ./makeobsolete uses platform's sed
X-Send-Pr-Version: www-1.0

>Number:         58200
>Category:       toolchain
>Synopsis:       ./makeobsolete uses platform's sed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 26 15:35:00 +0000 2024
>Closed-Date:    Fri Apr 26 19:21:31 +0000 2024
>Last-Modified:  Sun Apr 28 13:45:01 +0000 2024
>Originator:     Kouichi Hashikawa
>Release:        NetBSD-current, 10
>Organization:
>Environment:
>Description:
When building, src/distrib/set/makeobsolete uses platform's sed.
(actual place of using sed is at src/distrib/set/sets.subr).


do-obsolete ===> .
install-obsolete-lists ===> etc
mkdir -p /usr/obj/buildobs/obj/usr/obj/c/src/etc/obsolete.dir
(cd /usr/src/c/src/distrib/sets &&  AWK=/usr/obj/c/buildobs/tools/bin/nbawk MAKE=/usr/obj/c/buildobs/tools/bin/nbmake /bin/sh ./makeobsolete -b -t /usr/obj/c/buildobs/obj/current/netbsd/c/src/etc/obsolete.dir)
>How-To-Repeat:
always.
>Fix:
I think,

--- src/etc/Makefile-146621	2023-12-01 12:32:36.507114386 +0900
+++ src/etc/Makefile	2024-04-26 08:35:02.282337963 +0900
@@ -393,10 +393,10 @@
 	mkdir -p ${OBSOLETE.dir}
 .if ${MKX11} != "no"
 	(cd ${NETBSDSRCDIR}/distrib/sets && \
-	    AWK=${TOOL_AWK:Q} MAKE=${MAKE:Q} ${HOST_SH} ./makeobsolete -b -t ${OBSOLETE.dir})
+	    AWK=${TOOL_AWK:Q} SED=${TOOL_SED:Q} MAKE=${MAKE:Q} ${HOST_SH} ./makeobsolete -b -t ${OBSOLETE.dir})
 .else
 	(cd ${NETBSDSRCDIR}/distrib/sets && \
-	    AWK=${TOOL_AWK:Q} MAKE=${MAKE:Q} ${HOST_SH} ./makeobsolete -t ${OBSOLETE.dir})
+	    AWK=${TOOL_AWK:Q} SED=${TOOL_SED:Q} MAKE=${MAKE:Q} ${HOST_SH} ./makeobsolete -t ${OBSOLETE.dir})
 .endif
 .for file in ${OBSOLETE.files}
 	${_MKMSG_INSTALL} ${DESTDIR}/var/db/obsolete/${file}

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58200 CVS commit: src/etc
Date: Fri, 26 Apr 2024 14:06:02 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Fri Apr 26 18:06:02 UTC 2024

 Modified Files:
 	src/etc: Makefile

 Log Message:
 PR/58200: Kouichi Hashikawa: ./makeobsolete uses platform's sed


 To generate a diff of this commit:
 cvs rdiff -u -r1.469 -r1.470 src/etc/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Fri, 26 Apr 2024 19:21:31 +0000
State-Changed-Why:
Fixed by christos, thanks!


From: Kouichi Hashikawa <hashikaw@mail.ru>
To: gnats-bugs@netbsd.org
Cc: toolchain-manager@netbsd.org, gnats-admin@netbsd.org,
 netbsd-bugs@netbsd.org
Subject: Re: PR/58200 CVS commit: src/etc
Date: Sat, 27 Apr 2024 21:58:54 +0900

 > From: "Christos Zoulas" <christos@netbsd.org>
 > To: gnats-bugs@gnats.NetBSD.org
 > Cc: 
 > Subject: PR/58200 CVS commit: src/etc
 > Date: Fri, 26 Apr 2024 14:06:02 -0400
 > 
 > Module Name:    src
 > Committed By:    christos
 > Date:        Fri Apr 26 18:06:02 UTC 2024
 > 
 > Modified Files:
 >    src/etc: Makefile
 > 
 > Log Message:
 > PR/58200: Kouichi Hashikawa: ./makeobsolete uses platform's sed

 Thank you for applying the patch.

 Please pull-up to release branch.

 -- 
 Kouichi Hashikawa

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58200 CVS commit: [netbsd-10] src/etc
Date: Sun, 28 Apr 2024 13:42:44 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sun Apr 28 13:42:44 UTC 2024

 Modified Files:
 	src/etc [netbsd-10]: Makefile

 Log Message:
 Pull up following revision(s) (requested by christos in ticket #681):

 	etc/Makefile: revision 1.470

 PR/58200: Kouichi Hashikawa: ./makeobsolete uses platform's sed


 To generate a diff of this commit:
 cvs rdiff -u -r1.466.2.1 -r1.466.2.2 src/etc/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search