NetBSD Problem Report #58202

From mdehling@gmail.com  Fri Apr 26 17:44:37 2024
Return-Path: <mdehling@gmail.com>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 24B771A9238
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 26 Apr 2024 17:44:37 +0000 (UTC)
Message-Id: <CAP+FTfX1nqhZiGYWOPNVJt=cuyuRoCzKdi-d5Xrk3_H-XeQnFg@mail.gmail.com>
Date: Fri, 26 Apr 2024 10:44:34 -0700
From: Malte Dehling <mdehling@gmail.com>
To: NetBSD Bugs <gnats-bugs@netbsd.org>
Subject: fstyp(8): Don't link libzfs
X-Send-Pr-Version: 3.95

>Number:         58202
>Category:       kern
>Synopsis:       fstyp(8): Don't link libzfs
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 26 17:45:00 +0000 2024
>Closed-Date:    Fri Apr 26 19:21:53 +0000 2024
>Last-Modified:  Fri Apr 26 19:21:53 +0000 2024
>Originator:     Malte Dehling
>Release:        NetBSD 10.0, -current
>Organization:
>Environment:
    NetBSD 10.0 (GENERIC) #4: Wed Apr 24 12:21:26 PDT 2024
    mdehling@nb-base-dev:/scratch/obj/sys/arch/amd64/compile/GENERIC amd64

>Description:

fstyp(8) is linked against libzfs for no reason -- it only needs
libnvpair.

>How-To-Repeat:

>Fix:

fstyp(8): Don't link libzfs
---
 usr.sbin/fstyp/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usr.sbin/fstyp/Makefile b/usr.sbin/fstyp/Makefile
index 27482d2ee47..03d4ed9c199 100644
--- a/usr.sbin/fstyp/Makefile
+++ b/usr.sbin/fstyp/Makefile
@@ -17,7 +17,7 @@ WARNS?=	6
 COPTS.zfs.c+=	-Wno-unknown-pragmas
 COPTS.zfs.c+=	-Wno-sign-conversion
 COPTS.zfs.c+=	-Wno-strict-prototypes
-LDADD+=	-lnvpair -lzfs
+LDADD+=	-lnvpair

 OSNET=${NETBSDSRCDIR}/external/cddl/osnet
 CPPFLAGS+=	-DHAVE_ZFS

-- 
Malte Dehling

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58202 CVS commit: src/usr.sbin/fstyp
Date: Fri, 26 Apr 2024 14:21:25 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Fri Apr 26 18:21:25 UTC 2024

 Modified Files:
 	src/usr.sbin/fstyp: Makefile

 Log Message:
 PR/58202: Malte Dehling: Don't link libzfs


 To generate a diff of this commit:
 cvs rdiff -u -r1.14 -r1.15 src/usr.sbin/fstyp/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Fri, 26 Apr 2024 19:21:53 +0000
State-Changed-Why:
Fixed by christos, thanks!



>Unformatted:

Home	PR Database Search