NetBSD Problem Report #58931

From wiz@exadelic.gatalith.at  Sun Dec 22 10:40:08 2024
Return-Path: <wiz@exadelic.gatalith.at>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E5A211A9238
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 22 Dec 2024 10:40:07 +0000 (UTC)
Message-Id: <20241222104001.D64822EBBACC@exadelic.gatalith.at>
Date: Sun, 22 Dec 2024 11:40:01 +0100 (CET)
From: Thomas Klausner <wiz@NetBSD.org>
Reply-To: Thomas Klausner <wiz@NetBSD.org>
To: gnats-bugs@NetBSD.org
Subject: qsort_r() missing
X-Send-Pr-Version: 3.95

>Number:         58931
>Category:       lib
>Synopsis:       qsort_r() missing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 22 10:45:00 +0000 2024
>Last-Modified:  Sun Mar 02 23:15:01 +0000 2025
>Originator:     Thomas Klausner
>Release:        NetBSD 10.99.12
>Organization:

>Environment:


Architecture: x86_64
Machine: amd64
>Description:
qsort_r() is missing.
https://pubs.opengroup.org/onlinepubs/9799919799/functions/qsort_r.html
describes it as

"The qsort_r() function shall be identical to qsort() except that the
comparison function compar takes a third argument. The arg opaque
pointer passed to qsort_r() shall in turn be passed as the third
argument to the comparison function."

>How-To-Repeat:
man qsort_r
grep -r qsort_r /usr/include
>Fix:
Yes, please.

>Audit-Trail:
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58931 CVS commit: src
Date: Sun, 2 Mar 2025 16:35:42 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sun Mar  2 16:35:41 UTC 2025

 Modified Files:
 	src/common/lib/libc/stdlib: heapsort.c
 	src/distrib/sets/lists/comp: mi
 	src/distrib/sets/lists/debug: mi
 	src/distrib/sets/lists/tests: mi
 	src/include: stdlib.h
 	src/lib/libc/include: namespace.h
 	src/lib/libc/stdlib: Makefile.inc merge.c qsort.3 qsort.c
 	src/sys/lib/libkern: libkern.h
 	src/tests/lib/libc/stdlib: Makefile
 	src/tools/compat: compat_defs.h
 Added Files:
 	src/tests/lib/libc/stdlib: h_sort.c t_sort.sh

 Log Message:
 libc: New _r variants of heapsort, mergesort, qsort.

 Also kheapsort_r for kernel/standalone use.

 These variants allow the caller to pass a cookie through to the
 comparison function, e.g. if you want to sort an array of indices
 into a buffer.

 qsort_r is new in POSIX.1-2024; the others are obvious analogues of
 our nonstandard extensions for heapsort and mergesort.

 PR lib/58931: qsort_r() missing


 To generate a diff of this commit:
 cvs rdiff -u -r1.3 -r1.4 src/common/lib/libc/stdlib/heapsort.c
 cvs rdiff -u -r1.2485 -r1.2486 src/distrib/sets/lists/comp/mi
 cvs rdiff -u -r1.466 -r1.467 src/distrib/sets/lists/debug/mi
 cvs rdiff -u -r1.1359 -r1.1360 src/distrib/sets/lists/tests/mi
 cvs rdiff -u -r1.129 -r1.130 src/include/stdlib.h
 cvs rdiff -u -r1.205 -r1.206 src/lib/libc/include/namespace.h
 cvs rdiff -u -r1.103 -r1.104 src/lib/libc/stdlib/Makefile.inc
 cvs rdiff -u -r1.16 -r1.17 src/lib/libc/stdlib/merge.c
 cvs rdiff -u -r1.14 -r1.15 src/lib/libc/stdlib/qsort.3
 cvs rdiff -u -r1.23 -r1.24 src/lib/libc/stdlib/qsort.c
 cvs rdiff -u -r1.147 -r1.148 src/sys/lib/libkern/libkern.h
 cvs rdiff -u -r1.34 -r1.35 src/tests/lib/libc/stdlib/Makefile
 cvs rdiff -u -r0 -r1.1 src/tests/lib/libc/stdlib/h_sort.c \
     src/tests/lib/libc/stdlib/t_sort.sh
 cvs rdiff -u -r1.123 -r1.124 src/tools/compat/compat_defs.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58931 CVS commit: src/tests/lib/libc/stdlib
Date: Sun, 2 Mar 2025 20:00:32 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sun Mar  2 20:00:32 UTC 2025

 Modified Files:
 	src/tests/lib/libc/stdlib: h_sort.c t_sort.sh

 Log Message:
 t_sort: Test mergesort for stability too.

 These test cases are trivial, but they're enough to trigger unstable
 heapsort and qsort.

 Fix some error branches while here.

 PR lib/58931: qsort_r() missing


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libc/stdlib/h_sort.c \
     src/tests/lib/libc/stdlib/t_sort.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58931 CVS commit: src/tests/lib/libc/stdlib
Date: Sun, 2 Mar 2025 23:11:19 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sun Mar  2 23:11:19 UTC 2025

 Modified Files:
 	src/tests/lib/libc/stdlib: h_sort.c

 Log Message:
 tests/lib/libc/stdlib/h_sort: Reserve room for a NUL byte.

 PR lib/58931: qsort_r() missing


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libc/stdlib/h_sort.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search