NetBSD Problem Report #58979

From wiz@exadelic.gatalith.at  Fri Jan 10 13:40:08 2025
Return-Path: <wiz@exadelic.gatalith.at>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E9F8C1A9238
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 10 Jan 2025 13:40:07 +0000 (UTC)
Message-Id: <20250110134001.DD9AB2EBBAA8@exadelic.gatalith.at>
Date: Fri, 10 Jan 2025 14:40:01 +0100 (CET)
From: Thomas Klausner <wiz@NetBSD.org>
Reply-To: Thomas Klausner <wiz@NetBSD.org>
To: gnats-bugs@NetBSD.org
Subject: twm vs. firefox: menus unusable
X-Send-Pr-Version: 3.95

>Number:         58979
>Category:       xsrc
>Synopsis:       twm vs. firefox: menus unusable
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    xsrc-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 10 13:45:00 +0000 2025
>Closed-Date:    Sat Jan 11 14:39:06 +0000 2025
>Last-Modified:  Sat Jan 11 14:50:01 +0000 2025
>Originator:     Thomas Klausner
>Release:        NetBSD 10.99.12
>Organization:

>Environment:


Architecture: x86_64
Machine: amd64
>Description:
This is a forwarded bug report from a user who didn't want to report it themselves.

The problem is that when running firefox in twm (and, I'm told but
haven't tried, vtwm), the menus (e.g. File, but also in the firefox
toolbar) do not stay open when the cursor leaves the position where it
was when it opened them - which makes it impossible to use the menus,
because you can't click on the menu entries, since they disappear when
you move their way.

This works fine in i3 or ctwm, so it looks like a bug in twm.

I'm told it's also broken in wm/vtwm, but haven't tried that yet.
>How-To-Repeat:
Run firefox (133.0.3, but I'm told other versions are also affected) inside twm.

>Fix:
Please.

>Release-Note:

>Audit-Trail:
From: RVP <rvp@SDF.ORG>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: xsrc/58979: twm vs. firefox: menus unusable
Date: Sat, 11 Jan 2025 08:18:30 +0000 (UTC)

 On Fri, 10 Jan 2025, Thomas Klausner wrote:

 > The problem is that when running firefox in twm (and, I'm told but
 > haven't tried, vtwm), the menus (e.g. File, but also in the firefox
 > toolbar) do not stay open when the cursor leaves the position where it
 > was when it opened them - which makes it impossible to use the menus,
 > because you can't click on the menu entries, since they disappear when
 > you move their way.
 >

 Can you try this patch:

 ```
 diff -urN a/xsrc/external/mit/twm/dist/src/events.c b/xsrc/external/mit/twm/dist/src/events.c
 --- a/xsrc/external/mit/twm/dist/src/events.c	2022-07-11 09:08:07.000000000 +0000
 +++ b/xsrc/external/mit/twm/dist/src/events.c	2025-01-11 08:14:11.283414703 +0000
 @@ -2185,7 +2185,9 @@
           }
           if (Scr->FocusRoot) {

 -            if (Event.xcrossing.detail != NotifyInferior) {
 +            if (Event.xcrossing.detail != NotifyInferior &&
 +                Event.xcrossing.detail != NotifyVirtual &&
 +                Event.xcrossing.detail != NotifyNonlinearVirtual) {

                   /*
                    * Scan for EnterNotify events to see if we can avoid some
 ```

 -RVP

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sat, 11 Jan 2025 14:39:06 +0000
State-Changed-Why:
I've committed RVP's patch. Thank you, RVP!


From: Thomas Klausner <wiz@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc: RVP <rvp@SDF.ORG>
Subject: Re: xsrc/58979: twm vs. firefox: menus unusable
Date: Sat, 11 Jan 2025 15:36:27 +0100

 Hi!

 I've forwarded the patch to the user, and they confirmed that it fixes the problem.
 Thank you!
  Thomas

From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58979 CVS commit: xsrc/external/mit/twm/dist/src
Date: Sat, 11 Jan 2025 14:38:39 +0000

 Module Name:	xsrc
 Committed By:	wiz
 Date:		Sat Jan 11 14:38:39 UTC 2025

 Modified Files:
 	xsrc/external/mit/twm/dist/src: events.c

 Log Message:
 twm: fix sub-menu handling

 Patch from RVP.

 Fixes PR 58979.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1.1.5 -r1.2 xsrc/external/mit/twm/dist/src/events.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58979 CVS commit: pkgsrc/wm/vtwm
Date: Sat, 11 Jan 2025 14:47:07 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Sat Jan 11 14:47:07 UTC 2025

 Modified Files:
 	pkgsrc/wm/vtwm: Makefile distinfo
 Added Files:
 	pkgsrc/wm/vtwm/patches: patch-events.c patch-menus.c

 Log Message:
 vtwm: apply fix PR 58979 (twm) for vtwm

 Bump PKGREVISION.


 To generate a diff of this commit:
 cvs rdiff -u -r1.16 -r1.17 pkgsrc/wm/vtwm/Makefile
 cvs rdiff -u -r1.6 -r1.7 pkgsrc/wm/vtwm/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/wm/vtwm/patches/patch-events.c \
     pkgsrc/wm/vtwm/patches/patch-menus.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search