NetBSD Problem Report #58981

From www@netbsd.org  Fri Jan 10 17:46:10 2025
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 6F6861A9238
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 10 Jan 2025 17:46:10 +0000 (UTC)
Message-Id: <20250110174609.4E9711A923B@mollari.NetBSD.org>
Date: Fri, 10 Jan 2025 17:46:09 +0000 (UTC)
From: rwhitlock22@gmail.com
Reply-To: rwhitlock22@gmail.com
To: gnats-bugs@NetBSD.org
Subject: cad/kicad: use wayland/platform.mk
X-Send-Pr-Version: www-1.0

>Number:         58981
>Category:       pkg
>Synopsis:       cad/kicad: use wayland/platform.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 10 17:50:00 +0000 2025
>Closed-Date:    Fri Jan 10 22:50:12 +0000 2025
>Last-Modified:  Fri Jan 10 22:50:12 +0000 2025
>Originator:     Robert Whitlock
>Release:        pkgsrc current, Jan 4, 2025
>Organization:
>Environment:
NetBSD/amd64 current 10.99.12, Nov 9, 2024
>Description:
Examination of other packages that have a wayland option (like gtk3) show that wayland is in PKG_SUGGESTED_OPTIONS only if wayland/platform.mk says to do so. This patch adapts cad/kicad to follow that practice, so that the wayland option is not suggested to be used on platforms that don't support wayland.
>How-To-Repeat:
be on a platform that doesn't support wayland
cd cad/kicad
make show-options
see that wayland is suggested
>Fix:
Use wayland/platform.mk in cad/kicad/options.mk.

Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/cad/kicad/options.mk,v
retrieving revision 1.5
diff -u -r1.5 options.mk
--- options.mk  16 Dec 2024 07:44:51 -0000      1.5
+++ options.mk  10 Jan 2025 17:37:06 -0000
@@ -2,7 +2,12 @@

 PKG_OPTIONS_VAR=       PKG_OPTIONS.kicad
 PKG_SUPPORTED_OPTIONS= ng-spice wayland
-PKG_SUGGESTED_OPTIONS= ng-spice wayland
+PKG_SUGGESTED_OPTIONS= ng-spice
+
+.include "../../devel/wayland/platform.mk"
+.if ${PLATFORM_SUPPORTS_WAYLAND} == "yes"
+PKG_SUGGESTED_OPTIONS+=        wayland
+.endif

 .include "../../mk/bsd.options.mk"


>Release-Note:

>Audit-Trail:
From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58981 CVS commit: pkgsrc/cad/kicad
Date: Fri, 10 Jan 2025 22:49:54 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Fri Jan 10 22:49:54 UTC 2025

 Modified Files:
 	pkgsrc/cad/kicad: Makefile options.mk

 Log Message:
 kicad: add wayland to default options when its supported

 Checked using its platform.mk.

 From Robert Whitlock in PR 58981.

 Bump PKGREVISION due to the default change (on some platforms).


 To generate a diff of this commit:
 cvs rdiff -u -r1.107 -r1.108 pkgsrc/cad/kicad/Makefile
 cvs rdiff -u -r1.5 -r1.6 pkgsrc/cad/kicad/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Fri, 10 Jan 2025 22:50:12 +0000
State-Changed-Why:
Committed, thanks!


>Unformatted:

Home	PR Database Search