NetBSD Problem Report #59187

From www@netbsd.org  Mon Mar 17 06:25:46 2025
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 83FCF1A9239
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 17 Mar 2025 06:25:46 +0000 (UTC)
Message-Id: <20250317062544.C1AC61A923C@mollari.NetBSD.org>
Date: Mon, 17 Mar 2025 06:25:44 +0000 (UTC)
From: rwhitlock22@gmail.com
Reply-To: rwhitlock22@gmail.com
To: gnats-bugs@NetBSD.org
Subject: x11/py-qt5: disabling dbus options seems to not disable dbus
X-Send-Pr-Version: www-1.0

>Number:         59187
>Category:       pkg
>Synopsis:       x11/py-qt5: disabling dbus options seems to not disable dbus
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 17 06:30:00 +0000 2025
>Closed-Date:    Sun May 25 17:56:16 +0000 2025
>Last-Modified:  Sun May 25 18:00:02 +0000 2025
>Originator:     Robert Whitlock
>Release:        pkgsrc current, March 14, 2025
>Organization:
>Environment:
NetBSD current, amd64, March 7, 2025
>Description:
Disabling the dbus option for py-qt5 and compiling it ends with the following error:

=> Checking file-check results for py312-qt5-5.15.11nb5
ERROR: ************************************************************
ERROR: The following files are in /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg but not in the PLIST:
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/QtDBus.abi3.so
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/QtDBus.toml
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/QtDBusmod.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbusabstractadaptor.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbusabstractinterface.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbusargument.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbusconnection.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbusconnectioninterface.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbuserror.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbusextratypes.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbusinterface.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbusmessage.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbuspendingcall.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbusservicewatcher.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qdbusunixfiledescriptor.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qpydbuspendingreply.sip
ERROR:         /usr/pkg-work/x11/py-qt5/work/.destdir/usr/pkg/lib/python3.12/site-packages/PyQt5/bindings/QtDBus/qpydbusreply.sip
*** Error code 1

Stop.
make[2]: stopped making "package-install" in /usr/pkgsrc/x11/py-qt5
*** Error code 1

Stop.
make[1]: stopped making "package-install" in /usr/pkgsrc/x11/py-qt5
*** Error code 1

Stop.
make: stopped making "package" in /usr/pkgsrc/geography/qgis



Looking in the project.py file, there is an option for disabling dbus that the makefile doesn't seem to employ. I didn't see an obvious way to invoke that option, but maybe somebody who is more familiar with the python infrastructure would know how to do that.
>How-To-Repeat:
disable dbus for x11/py-qt5
cd x11/py-qt5
make install
>Fix:
make use of the build script's dbus option in the pkgsrc makefile

>Release-Note:

>Audit-Trail:
From: Rob Whitlock <rwhitlock22@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org,
 gnats-admin@netbsd.org,
 pkgsrc-bugs@netbsd.org
Subject: Re: pkg/59187: x11/py-qt5: disabling dbus options seems to not
 disable dbus
Date: Fri, 23 May 2025 00:11:14 -0400

 It seems like the following patch should fix it, but it doesn't. I know =
 this is the right option because when I misspell it, the build stops =
 with an error saying it's an incorrect option, and it lists =
 --no-dbus-python as an option. But when I build it, the dbus files still =
 get built and it still ends with a PLIST error.

 Any ideas about what might be going wrong?

 Index: options.mk
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/x11/py-qt5/options.mk,v
 retrieving revision 1.1
 diff -u -r1.1 options.mk
 --- options.mk	2 Dec 2022 15:31:58 -0000	1.1
 +++ options.mk	23 May 2025 04:03:35 -0000
 @@ -11,4 +11,6 @@
  PLIST.dbus=3D		yes
  .include "../../sysutils/dbus-python-common/buildlink3.mk"
  .include "../../sysutils/py-dbus/buildlink3.mk"
 +.else
 +WHEEL_ARGS+=3D	-C=3D--no-dbus-python
  .endif

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/59187: x11/py-qt5: disabling dbus options seems to not
 disable dbus
Date: Fri, 23 May 2025 08:25:37 +0200

 On Fri, May 23, 2025 at 12:11:14AM -0400, Rob Whitlock wrote:
 > It seems like the following patch should fix it, but it doesn't. I know this is the right option because when I misspell it, the build stops with an error saying it's an incorrect option, and it lists --no-dbus-python as an option. But when I build it, the dbus files still get built and it still ends with a PLIST error.
 > 
 > Any ideas about what might be going wrong?

 Your change follows the documentation:

 https://www.riverbankcomputing.com/static/Docs/PyQt5/installation.html#building-and-installing-from-source

 and I see the same, so I suggest contacting upstream - perhaps it's a
 bug in their build system.
  Thomas

From: Rob Whitlock <rwhitlock22@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org,
 gnats-admin@netbsd.org,
 pkgsrc-bugs@netbsd.org
Subject: Re: pkg/59187: x11/py-qt5: disabling dbus options seems to not
 disable dbus
Date: Sat, 24 May 2025 19:13:27 -0400

 > On May 23, 2025, at 2:30 AM, Thomas Klausner via gnats =
 <gnats-admin@NetBSD.org> wrote:
 >=20
 > The following reply was made to PR pkg/59187; it has been noted by =
 GNATS.
 >=20
 > From: Thomas Klausner <wiz@NetBSD.org>
 > To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
 > Cc:=20
 > Subject: Re: pkg/59187: x11/py-qt5: disabling dbus options seems to =
 not
 > disable dbus
 > Date: Fri, 23 May 2025 08:25:37 +0200
 >=20
 > On Fri, May 23, 2025 at 12:11:14AM -0400, Rob Whitlock wrote:
 >> It seems like the following patch should fix it, but it doesn't. I =
 know this is the right option because when I misspell it, the build =
 stops with an error saying it's an incorrect option, and it lists =
 --no-dbus-python as an option. But when I build it, the dbus files still =
 get built and it still ends with a PLIST error.
 >>=20
 >> Any ideas about what might be going wrong?
 >=20
 > Your change follows the documentation:
 >=20
 > =
 https://www.riverbankcomputing.com/static/Docs/PyQt5/installation.html#bui=
 lding-and-installing-from-source
 >=20
 > and I see the same, so I suggest contacting upstream - perhaps it's a
 > bug in their build system.

 According to upstream I was using the wrong option. I was using the =
 option to disable
 support for the dbus-python package whereas I wanted to disable support =
 for Qt's
 QtDBus module. Here's a patch that works:

 Index: options.mk
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/x11/py-qt5/options.mk,v
 retrieving revision 1.1
 diff -u -r1.1 options.mk
 --- options.mk	2 Dec 2022 15:31:58 -0000	1.1
 +++ options.mk	24 May 2025 23:05:42 -0000
 @@ -11,4 +11,6 @@
  PLIST.dbus=3D		yes
  .include "../../sysutils/dbus-python-common/buildlink3.mk"
  .include "../../sysutils/py-dbus/buildlink3.mk"
 +.else
 +WHEEL_ARGS+=3D	-C=3D--disable=3DQtDBus
  .endif=

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 25 May 2025 17:56:16 +0000
State-Changed-Why:
Committed, thanks!


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59187 CVS commit: pkgsrc/x11/py-qt5
Date: Sun, 25 May 2025 17:56:01 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Sun May 25 17:56:01 UTC 2025

 Modified Files:
 	pkgsrc/x11/py-qt5: options.mk

 Log Message:
 py-qt5: fix case where dbus option is turned off

 from Rob Whitlock in PR 59187.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/x11/py-qt5/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search