NetBSD Problem Report #59278

From www@netbsd.org  Fri Apr 11 13:37:40 2025
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D65D01A9239
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 11 Apr 2025 13:37:40 +0000 (UTC)
Message-Id: <20250411133739.66F9E1A923E@mollari.NetBSD.org>
Date: Fri, 11 Apr 2025 13:37:39 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: tests/lib/librumphijack/t_tcpip:ssh failing since openssh 10.0 update
X-Send-Pr-Version: www-1.0

>Number:         59278
>Category:       bin
>Synopsis:       tests/lib/librumphijack/t_tcpip:ssh failing since openssh 10.0 update
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    christos
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 11 13:40:00 +0000 2025
>Last-Modified:  Wed Apr 16 01:10:01 +0000 2025
>Originator:     Taylor R Campbell
>Release:        
>Organization:
The RumpBSD Sshldaptation
>Environment:
>Description:
Termination reason

FAILED: atf-check failed; see the output of the test for details
Standard output stream

Executing command [ rump_server -lrumpnet -lrumpnet_net -lrumpnet_netinet unix://csock ]
Setting up SSH server configuration
Executing command [ cp /usr/tests/lib/librumphijack/ssh_host_key . ]
Executing command [ cp /usr/tests/lib/librumphijack/ssh_host_key.pub . ]
Executing command [ chmod 400 ssh_host_key ]
Executing command [ chmod 444 ssh_host_key.pub ]
Setting up SSH client configuration
Executing command [ ssh-keygen -f ssh_user_key -t rsa -b 1024 -N  -q ]
Executing command [ cp ssh_user_key.pub authorized_keys ]
Executing command [ chmod 600 authorized_keys ]
sshd running
Executing command [ env LD_PRELOAD=/usr/lib/librumphijack.so ssh -T -F ssh_config 127.0.0.1 env BLOCKSIZE=512 ls -li /tmp/atf-run.j2Kzne/testdir ]

Standard error stream

[LDAP] could not initialize ldap connection
Fail: incorrect exit status: 255, expected: 0
stdout:

stderr:
Connection closed by 127.0.0.1 port 22

https://releng.netbsd.org/b5reports/i386/2025/2025.04.09.21.59.17/test.html#lib_librumphijack_t_tcpip_ssh

Unclear why there is any ldap involved in this at all!  The text `ldap' appears nowhere under src/tests/lib/librumphijack.
>How-To-Repeat:
cd /usr/tests/lib/librumphijack
atf-run t_tcpip:ssh | atf-report
>Fix:
Yes, please!

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: bin-bug-people->christos
Responsible-Changed-By: riastradh@NetBSD.org
Responsible-Changed-When: Fri, 11 Apr 2025 13:45:05 +0000
Responsible-Changed-Why:
Can you please take a look?  It's bad that a test is failing, and
alarming that it seems to be trying to do ldap stuff unprompted.


From: Christos Zoulas <christos@zoulas.com>
To: gnats-bugs@netbsd.org
Cc: christos@netbsd.org,
 gnats-admin@netbsd.org,
 netbsd-bugs@netbsd.org,
 "riastradh@netbsd.org" <riastradh@NetBSD.org>,
 campbell+netbsd@mumble.net
Subject: Re: bin/59278 (tests/lib/librumphijack/t_tcpip:ssh failing since
 openssh 10.0 update)
Date: Fri, 11 Apr 2025 13:53:43 -0400

 --Apple-Mail=_B4B2CBC7-8D1C-4CC3-9FA4-2B69F0FE87EE
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii

 The LDAP problem has been fixed, but the new sshd-session wants to exec =
 sshd-auth with stdin/out the network socket so the hijack
 code tries to dup(128, 0) and fails in:

         if (fd_isrump(oldd)) {
                 int (*op_close)(int) =3D GETSYSCALL(host, CLOSE);
        =20
                 /* only allow fd 0-2 for cross-kernel dup */
                 if (!(newd >=3D 0 && newd <=3D 2 && !fd_isrump(newd))) {
                         errno =3D EBADF; <-----
                         return -1;
                 }

 The server client portion of the test works without rump...

 christos



 --Apple-Mail=_B4B2CBC7-8D1C-4CC3-9FA4-2B69F0FE87EE
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP

 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - http://gpgtools.org

 iF0EARECAB0WIQS+BJlbqPkO0MDBdsRxESqxbLM7OgUCZ/lXJwAKCRBxESqxbLM7
 OulyAKCLCsYWA3V+z5+LjK3T//6bf7XiXwCg77YszwfVrReC1pDukGPhMTju0Pk=
 =A9Ax
 -----END PGP SIGNATURE-----

 --Apple-Mail=_B4B2CBC7-8D1C-4CC3-9FA4-2B69F0FE87EE--

From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59278 CVS commit: src/tests/lib/librumphijack
Date: Wed, 16 Apr 2025 01:06:16 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Wed Apr 16 01:06:16 UTC 2025

 Modified Files:
 	src/tests/lib/librumphijack: t_tcpip.sh

 Log Message:
 t_tcpip: Mark ssh test xfail.

 PR bin/59278: tests/lib/librumphijack/t_tcpip:ssh failing since
 openssh 10.0 update


 To generate a diff of this commit:
 cvs rdiff -u -r1.24 -r1.25 src/tests/lib/librumphijack/t_tcpip.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search