NetBSD Problem Report #59301

From www@netbsd.org  Wed Apr 16 01:44:53 2025
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 0081C1A9239
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 16 Apr 2025 01:44:52 +0000 (UTC)
Message-Id: <20250416014451.940B61A923D@mollari.NetBSD.org>
Date: Wed, 16 Apr 2025 01:44:51 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: riscv: missing MKPROFILE=yes support
X-Send-Pr-Version: www-1.0

>Number:         59301
>Category:       port-riscv
>Synopsis:       riscv: missing MKPROFILE=yes support
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-riscv-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 16 01:45:00 +0000 2025
>Closed-Date:    Fri Apr 03 06:10:57 +0000 2026
>Last-Modified:  Fri Apr 03 06:10:57 +0000 2026
>Originator:     Taylor R Campbell
>Release:        current
>Organization:
The ProfileBSD Riscvation
>Environment:
>Description:
We always set MKPROFILE=no on riscv:

    930 # No profiling for or1k or risc-v (yet)
    931 MKPROFILE.or1k=	no
    932 MKPROFILE.riscv32=no
    933 MKPROFILE.riscv64=no

https://nxr.netbsd.org/xref/src/share/mk/bsd.own.mk?r=1.1414#930
>How-To-Repeat:
cc -pg

cd /usr/tests/usr.bin/cc
atf-run t_hello:hello_profile | atf-report
>Fix:
Yes, please!

>Release-Note:

>Audit-Trail:
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59301 CVS commit: src/tests/usr.bin
Date: Wed, 16 Apr 2025 01:52:42 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Wed Apr 16 01:52:42 UTC 2025

 Modified Files:
 	src/tests/usr.bin/c++: t_call_once.sh t_cxxruntime.sh t_hello.sh
 	    t_pthread_once.sh t_static_destructor.sh
 	src/tests/usr.bin/cc: t_hello.sh

 Log Message:
 tests/usr.bin/*: Mark profiling tests xfail on riscv.

 PR port-riscv/59301: riscv: missing MKPROFILE=yes support


 To generate a diff of this commit:
 cvs rdiff -u -r1.6 -r1.7 src/tests/usr.bin/c++/t_call_once.sh \
     src/tests/usr.bin/c++/t_pthread_once.sh \
     src/tests/usr.bin/c++/t_static_destructor.sh
 cvs rdiff -u -r1.7 -r1.8 src/tests/usr.bin/c++/t_cxxruntime.sh \
     src/tests/usr.bin/c++/t_hello.sh
 cvs rdiff -u -r1.12 -r1.13 src/tests/usr.bin/cc/t_hello.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Nick Hudson" <skrll@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59301 CVS commit: src/sys/arch/riscv/include
Date: Mon, 9 Mar 2026 20:26:36 +0000

 Module Name:	src
 Committed By:	skrll
 Date:		Mon Mar  9 20:26:36 UTC 2026

 Modified Files:
 	src/sys/arch/riscv/include: asm.h profile.h

 Log Message:
 risc-v: Add profiling support

 PR/59301 riscv: missing MKPROFILE=yes support
  CVS: ----------------------------------------------------------------------


 To generate a diff of this commit:
 cvs rdiff -u -r1.11 -r1.12 src/sys/arch/riscv/include/asm.h
 cvs rdiff -u -r1.1 -r1.2 src/sys/arch/riscv/include/profile.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Nick Hudson" <skrll@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59301 CVS commit: src/tests/usr.bin
Date: Mon, 9 Mar 2026 20:29:26 +0000

 Module Name:	src
 Committed By:	skrll
 Date:		Mon Mar  9 20:29:25 UTC 2026

 Modified Files:
 	src/tests/usr.bin/c++: t_call_once.sh t_cxxruntime.sh t_hello.sh
 	    t_pthread_once.sh t_static_destructor.sh
 	src/tests/usr.bin/cc: t_hello.sh

 Log Message:
 risc-v: remove atf_expect_fail "PR port-riscv/59301"

 Now that risc-v has MKPROFILE support run the tests that exercise it.

 PR/59301 riscv: missing MKPROFILE=yes support


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 src/tests/usr.bin/c++/t_call_once.sh \
     src/tests/usr.bin/c++/t_pthread_once.sh
 cvs rdiff -u -r1.8 -r1.9 src/tests/usr.bin/c++/t_cxxruntime.sh \
     src/tests/usr.bin/c++/t_hello.sh
 cvs rdiff -u -r1.11 -r1.12 src/tests/usr.bin/c++/t_static_destructor.sh
 cvs rdiff -u -r1.13 -r1.14 src/tests/usr.bin/cc/t_hello.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->pending-pullups
State-Changed-By: skrll@NetBSD.org
State-Changed-When: Wed, 11 Mar 2026 06:33:39 +0000
State-Changed-Why:
[pullup-11 #210] PR/59301 riscv: missing MKPROFILE=yes support


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59301 CVS commit: [netbsd-11] src
Date: Thu, 2 Apr 2026 16:00:00 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Thu Apr  2 15:59:59 UTC 2026

 Modified Files:
 	src/share/mk [netbsd-11]: bsd.own.mk
 	src/sys/arch/riscv/include [netbsd-11]: asm.h profile.h
 	src/tests/usr.bin/c++ [netbsd-11]: t_call_once.sh t_cxxruntime.sh
 	    t_hello.sh t_pthread_once.sh t_static_destructor.sh
 	src/tests/usr.bin/cc [netbsd-11]: t_hello.sh

 Log Message:
 Pull up following revision(s) (requested by skrll in ticket #210):

 	tests/usr.bin/c++/t_pthread_once.sh: revision 1.8
 	tests/usr.bin/c++/t_static_destructor.sh: revision 1.12 (via patch)
 	sys/arch/riscv/include/asm.h: revision 1.12
 	tests/usr.bin/c++/t_cxxruntime.sh: revision 1.9
 	tests/usr.bin/c++/t_call_once.sh: revision 1.8
 	tests/usr.bin/cc/t_hello.sh: revision 1.14
 	share/mk/bsd.own.mk: revision 1.1468
 	tests/usr.bin/c++/t_hello.sh: revision 1.9
 	sys/arch/riscv/include/profile.h: revision 1.2

 risc-v: Add profiling support
 PR/59301 riscv: missing MKPROFILE=yes support

 risc-v: MKPROFILE=yes
 PR/59301 riscv: missing MKPROFILE=yes support

 risc-v: remove atf_expect_fail "PR port-riscv/59301"
 Now that risc-v has MKPROFILE support run the tests that exercise it.

 PR/59301 riscv: missing MKPROFILE=yes support


 To generate a diff of this commit:
 cvs rdiff -u -r1.1428.2.1 -r1.1428.2.2 src/share/mk/bsd.own.mk
 cvs rdiff -u -r1.11 -r1.11.2.1 src/sys/arch/riscv/include/asm.h
 cvs rdiff -u -r1.1 -r1.1.60.1 src/sys/arch/riscv/include/profile.h
 cvs rdiff -u -r1.7 -r1.7.2.1 src/tests/usr.bin/c++/t_call_once.sh \
     src/tests/usr.bin/c++/t_pthread_once.sh \
     src/tests/usr.bin/c++/t_static_destructor.sh
 cvs rdiff -u -r1.8 -r1.8.2.1 src/tests/usr.bin/c++/t_cxxruntime.sh \
     src/tests/usr.bin/c++/t_hello.sh
 cvs rdiff -u -r1.13 -r1.13.2.1 src/tests/usr.bin/cc/t_hello.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: skrll@NetBSD.org
State-Changed-When: Fri, 03 Apr 2026 06:10:57 +0000
State-Changed-Why:
pullup(s) done


>Unformatted:

Home	PR Database Search