NetBSD Problem Report #59775

From www@netbsd.org  Wed Nov 19 07:47:32 2025
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 687611A9239
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 19 Nov 2025 07:47:32 +0000 (UTC)
Message-Id: <20251119074730.1C3571A923A@mollari.NetBSD.org>
Date: Wed, 19 Nov 2025 07:47:30 +0000 (UTC)
From: jun@soum.co.jp
Reply-To: jun@soum.co.jp
To: gnats-bugs@NetBSD.org
Subject: pkgsrc/www/firefox  patch-js_src_jit_arm64_vixl_Registers-vixl.h
X-Send-Pr-Version: www-1.0

>Number:         59775
>Category:       pkg
>Synopsis:       pkgsrc/www/firefox  patch-js_src_jit_arm64_vixl_Registers-vixl.h
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ryoon
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 19 07:50:01 +0000 2025
>Closed-Date:    Wed Sep 02 02:00:06 +0000 2026
>Last-Modified:  Wed Sep 02 02:00:06 +0000 2026
>Originator:     Jun Ebihara
>Release:        NetBSD 11.99.3 and pkgsrc 2025 Nov.19
>Organization:
SOUM Corporation
>Environment:
NetBSD arm64 11.99.3 NetBSD 11.99.3 (GENERIC64) #0: Mon Oct  6 07:51:44 UTC 2025  mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/evbarm/compile/GENERIC64 evbarm

>Description:
pkgsrc/www/firefox build failed on NetBSD/aarch64. 

/mnt/aarch64/pkgsrc/www/firefox/work.aarch64/firefox-145.0/js/src/jit/arm64/vixl/Registers-vixl.h: In member function 'constexpr bool vixl::CPURegister::IsMerging() const':
/mnt/aarch64/pkgsrc/www/firefox/work.aarch64/firefox-145.0/js/src/jit/arm64/vixl/Registers-vixl.h:378:56: error: call to non-'constexpr' function 'bool vixl
::CPURegister::IsPRegister() const'
  378 |   constexpr bool IsMerging() const { return IsPRegister() && (qualifiers_ == kMerging); }
      |                                             ~~~~~~~~~~~^~^
/mnt/aarch64/pkgsrc/www/firefox/work.aarch64/firefox-145.0/js/src/jit/arm64/vixl/Registers-vixl.h:191:8: note: 'bool vixl::CPURegister::IsPRegister() const'
 declared here
  191 |   bool IsPRegister() const { return GetType() == kPRegister; }
      |        ^~~~~~~~~~~

>How-To-Repeat:
1. Boot NetBSD/aarch64 on RPI4:
https://cdn.netbsd.org/pub/NetBSD/misc/jun/raspberry-pi/2025-10-07-aarch64/2025-10-07-netbsd-raspi-aarch64.img.gz
2. make pkgsrc/www/firefox


>Fix:
https://github.com/ebijun/NetBSD/blob/master/pkgsrc/firefox/patch-js_src_jit_arm64_vixl_Registers-vixl.h

$NetBSD$

Add constexpr keyword to the member function.

--- js/src/jit/arm64/vixl/Registers-vixl.h.orig	2025-11-19 07:12:36.568771038 +0000
+++ js/src/jit/arm64/vixl/Registers-vixl.h
@@ -188,13 +188,13 @@ class CPURegister {
   bool IsRegister() const { return GetType() == kRegister; }
   bool IsVRegister() const { return GetType() == kVRegister; }
   bool IsZRegister() const { return GetType() == kZRegister; }
-  bool IsPRegister() const { return GetType() == kPRegister; }
+  constexpr bool IsPRegister() const { return GetType() == kPRegister; }

   bool IsNone() const { return GetType() == kNoRegister; }

   // `GetType() == kNoRegister` implies IsNone(), and vice-versa.
   // `GetType() == k<Foo>Register` implies Is<Foo>Register(), and vice-versa.
-  RegisterType GetType() const {
+  constexpr RegisterType GetType() const {
     switch (bank_) {
       case kNoRegisterBank:
         return kNoRegister;

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->ryoon
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Wed, 19 Nov 2025 09:25:27 +0000
Responsible-Changed-Why:
Ryo, can you please give it a look?
Thank you!

(over to MAINTAINER)


From: "John Klos" <jklos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59775 CVS commit: pkgsrc/www/firefox
Date: Thu, 9 Jul 2026 20:07:10 +0000

 Module Name:	pkgsrc
 Committed By:	jklos
 Date:		Thu Jul  9 20:07:10 UTC 2026

 Modified Files:
 	pkgsrc/www/firefox: distinfo
 Added Files:
 	pkgsrc/www/firefox/patches:
 	    patch-js_src_jit_arm64_vixl_Registers-vixl.h

 Log Message:
 PR pkg/59775

 Installed suggested patch to fix compiling on NetBSD/aarch64.
 https://gnats.netbsd.org/59775


 To generate a diff of this commit:
 cvs rdiff -u -r1.582 -r1.583 pkgsrc/www/firefox/distinfo
 cvs rdiff -u -r0 -r1.1 \
     pkgsrc/www/firefox/patches/patch-js_src_jit_arm64_vixl_Registers-vixl.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 02 Sep 2026 02:00:06 +0000
State-Changed-Why:
Applied by jklos, thanks.


>Unformatted:

Home	PR Database Search