NetBSD Problem Report #59878

From www@netbsd.org  Fri Jan  2 06:54:27 2026
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 6C7F61A923C
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  2 Jan 2026 06:54:27 +0000 (UTC)
Message-Id: <20260102065426.668471A923D@mollari.NetBSD.org>
Date: Fri,  2 Jan 2026 06:54:26 +0000 (UTC)
From: rwhitlock22@gmail.com
Reply-To: rwhitlock22@gmail.com
To: gnats-bugs@NetBSD.org
Subject: net/ada-polyorb: don't evaluate variable in empty()
X-Send-Pr-Version: www-1.0

>Number:         59878
>Category:       pkg
>Synopsis:       net/ada-polyorb: don't evaluate variable in empty()
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    dkazankov
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 02 06:55:00 +0000 2026
>Closed-Date:    Sun Jan 11 17:24:36 +0000 2026
>Last-Modified:  Sun Jan 11 17:24:36 +0000 2026
>Originator:     Robert Whitlock
>Release:        pkgsrc current, Dec 31, 2025
>Organization:
>Environment:
NetBSD 10.99.14
>Description:
Any invocation of the pkgsrc Makefile for net/ada-polyorb results in the following warning:

make: /usr/pkgsrc/net/ada-polyorb/Makefile:53: warning: Invalid character " " in variable name "event ir naming notification time"

and --with-corba-services=... not being set in CONFIGURE_ARGS. This appears to be because line 53

.if !empty(${CORBA_SERVICES})

shouldn't evaluate its argument, and instead it should be

.if !empty(CORBA_SERVICES)
>How-To-Repeat:
cd net/ada-polyorb
make show-var VARNAME=CORBA_SERVICES
>Fix:
--- Makefile.orig       2026-01-01 18:19:07.158050778 -0500
+++ Makefile    2026-01-02 01:41:10.950289563 -0500
@@ -2,6 +2,7 @@

 DISTNAME=      polyorb-${PKGVERSION_NOREV}
 PKGNAME=       polyorb-${GNAT_NAME}-25.0.0
+PKGREVISION=   1
 CATEGORIES=    net devel
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=AdaCore/}
 GITHUB_PROJECT=        PolyORB
@@ -50,7 +51,7 @@

 CONFIGURE_ARGS+=       --with-appli-perso=${APP_PERSONALITIES:Q}
 CONFIGURE_ARGS+=       --with-proto-perso=${PROTOCOL_PERSONALITIES:Q}
-.if !empty(${CORBA_SERVICES})
+.if !empty(CORBA_SERVICES)
 CONFIGURE_ARGS+=       --with-corba-services=${CORBA_SERVICES:Q}
 .endif
 EXTRA_GNATMAKE_FLAGS+= -eL -R -largs $${LDFLAGS} -margs

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->dkazankov
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Fri, 02 Jan 2026 07:12:26 +0000
Responsible-Changed-Why:
Over to maintainer.


From: "Dmytro Kazankov" <dkazankov@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/59878 CVS commit: pkgsrc/net/ada-polyorb
Date: Wed, 7 Jan 2026 18:08:33 +0000

 Module Name:	pkgsrc
 Committed By:	dkazankov
 Date:		Wed Jan  7 18:08:33 UTC 2026

 Modified Files:
 	pkgsrc/net/ada-polyorb: Makefile

 Log Message:
 net/ada-polyorb: fix incorrect var usage

 PR pkg/59878: don't evaluate variable in empty()
 https://gnats.netbsd.org/59878


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/net/ada-polyorb/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Rob Whitlock <rwhitlock22@gmail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: PR/59878 CVS commit: pkgsrc/net/ada-polyorb
Date: Sun, 11 Jan 2026 06:25:46 -0500

 > On Jan 7, 2026, at 1:10 PM, Dmytro Kazankov <dkazankov@netbsd.org> wrote:
 > 
 > The following reply was made to PR pkg/59878; it has been noted by GNATS.
 > 
 > From: "Dmytro Kazankov" <dkazankov@netbsd.org>
 > To: gnats-bugs@gnats.NetBSD.org
 > Cc: 
 > Subject: PR/59878 CVS commit: pkgsrc/net/ada-polyorb
 > Date: Wed, 7 Jan 2026 18:08:33 +0000
 > 
 > Module Name:	pkgsrc
 > Committed By:	dkazankov
 > Date:		Wed Jan  7 18:08:33 UTC 2026
 > 
 > Modified Files:
 > 	pkgsrc/net/ada-polyorb: Makefile
 > 
 > Log Message:
 > net/ada-polyorb: fix incorrect var usage
 > 
 > PR pkg/59878: don't evaluate variable in empty()
 > https://gnats.netbsd.org/59878
 > 
 > 
 > To generate a diff of this commit:
 > cvs rdiff -u -r1.1 -r1.2 pkgsrc/net/ada-polyorb/Makefile
 > 
 > Please note that diffs are not public domain; they are subject to the
 > copyright notices on the relevant files.
 > 

 That fixed it. This PR can be closed. Thanks!

State-Changed-From-To: open->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Sun, 11 Jan 2026 17:24:36 +0000
State-Changed-Why:
Confirmed fixed


>Unformatted:

Home	PR Database Search