NetBSD Problem Report #60351

From www@netbsd.org  Tue Jun 23 04:03:00 2026
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "mail.netbsd.org", Issuer "R13" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BDCB81A923A
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 23 Jun 2026 04:02:59 +0000 (UTC)
Message-Id: <20260623040258.B2C771A923B@mollari.NetBSD.org>
Date: Tue, 23 Jun 2026 04:02:58 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: l2tp(4): panic: kernel diagnostic assertion "!simplehook_has_hooks(ifp->if_linkstate_hooks)" failed: file "/home/riastradh/netbsd/11/src/sys/net/if.c", line 1544
X-Send-Pr-Version: www-1.0
X-From4GNATS: "campbell+netbsd@mumble.net via gnats" <gnats-admin@NetBSD.org>

>Number:         60351
>Category:       kern
>Synopsis:       l2tp(4): panic: kernel diagnostic assertion "!simplehook_has_hooks(ifp->if_linkstate_hooks)" failed: file "/home/riastradh/netbsd/11/src/sys/net/if.c", line 1544
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    yamaguchi
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 23 04:05:00 +0000 2026
>Closed-Date:    Sun Jul 26 14:16:16 +0000 2026
>Last-Modified:  Sun Jul 26 14:16:16 +0000 2026
>Originator:     Taylor R Campbell
>Release:        11
>Organization:
The NetL2TP Crashination, Inc.
>Environment:
>Description:

[ 670764.019095] panic: kernel diagnostic assertion "!simplehook_has_hooks(ifp->if_linkstate_hooks)" failed: file "/home/riastradh/netbsd/11/src/sys/net/if.c", line 1544
[ 670764.019095] cpu0: Begin traceback...
[ 670764.020095] vpanic() at netbsd:vpanic+0x171
[ 670764.021095] kern_assert() at netbsd:kern_assert+0x4b
[ 670764.022095] if_detach() at netbsd:if_detach+0x799
[ 670764.024095] l2tp_clone_destroy() at netbsd:l2tp_clone_destroy+0xe5
[ 670764.025095] doifioctl() at netbsd:doifioctl+0xb90
[ 670764.026095] sys_ioctl() at netbsd:sys_ioctl+0x4ca
[ 670764.028095] syscall() at netbsd:syscall+0x9d
[ 670764.028095] --- syscall (number 54) ---
[ 670764.029095] netbsd:syscall+0x9d:
[ 670764.029095] cpu0: End traceback...

>How-To-Repeat:

	ifconfig bridge1 create up
	ifconfig l2tp1 create up
	brconfig bridge1 add l2tp1
	ifconfig l2tp1 destroy

>Fix:

	Yes, please!

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->yamaguchi
Responsible-Changed-By: riastradh@NetBSD.org
Responsible-Changed-When: Mon, 29 Jun 2026 16:32:16 +0000
Responsible-Changed-Why:
Thanks, can I trouble you to add an automatic test for this too?


State-Changed-From-To: open->needs-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Mon, 29 Jun 2026 16:32:16 +0000
State-Changed-Why:
fixed in HEAD, needs pullups to 11, 10, and 9, probably

https://mail-index.netbsd.org/source-changes/2026/06/29/msg162671.html

Module Name:    src
Committed By:   yamaguchi
Date:           Mon Jun 29 06:07:21 UTC 2026

Modified Files:
        src/sys/net: if_ethersubr.c

Log Message:
Properly add a hook to ec->ec_ifdetach_hooks for l2tp(4)

Fixes kern/60351


To generate a diff of this commit:
cvs rdiff -u -r1.335 -r1.336 src/sys/net/if_ethersubr.c


From: Shoichi Yamaguchi <yamaguchi@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: yamaguchi@netbsd.org, kern-bug-people@netbsd.org, netbsd-bugs@netbsd.org, 
	gnats-admin@netbsd.org, riastradh@netbsd.org, campbell+netbsd@mumble.net
Subject: Re: kern/60351 (l2tp(4): panic: kernel diagnostic assertion
 "!simplehook_has_hooks(ifp->if_linkstate_hooks)" failed: file
 "/home/riastradh/netbsd/11/src/sys/net/if.c", line 1544)
Date: Tue, 30 Jun 2026 09:41:16 +0900

 On Tue, Jun 30, 2026 at 1:32=E2=80=AFAM <riastradh@netbsd.org> wrote:
 >
 > Synopsis: l2tp(4): panic: kernel diagnostic assertion "!simplehook_has_ho=
 oks(ifp->if_linkstate_hooks)" failed: file "/home/riastradh/netbsd/11/src/s=
 ys/net/if.c", line 1544
 >
 > Responsible-Changed-From-To: kern-bug-people->yamaguchi
 > Responsible-Changed-By: riastradh@NetBSD.org
 > Responsible-Changed-When: Mon, 29 Jun 2026 16:32:16 +0000
 > Responsible-Changed-Why:
 > Thanks, can I trouble you to add an automatic test for this too?

 Not at all. I'd be happy to. I'll get on it as soon as I finish
 investigating the current PPP issue on SPARC.

State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Thu, 02 Jul 2026 13:44:56 +0000
State-Changed-Why:
fixed in HEAD
pullup-11 #363 https://releng.netbsd.org/cgi-bin/req-11.cgi?show=363
pullup-10 #1303 https://releng.netbsd.org/cgi-bin/req-10.cgi?show=1303
(inapplicable <10?)


State-Changed-From-To: pending-pullups->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Sun, 26 Jul 2026 14:16:16 +0000
State-Changed-Why:
fixed in HEAD, pulled up to 11 and 10, inapplicable(?) <10


>Unformatted:

Home	PR Database Search