NetBSD Problem Report #60468

From www@netbsd.org  Mon Jul 20 13:20:20 2026
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.netbsd.org", Issuer "YR2" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 21E711A923B
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 20 Jul 2026 13:20:20 +0000 (UTC)
Message-Id: <20260720132019.074D31A923D@mollari.NetBSD.org>
Date: Mon, 20 Jul 2026 13:20:19 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: external/mpl/bind/lib: misuse of build_install, missing MKBIND conditionals
X-Send-Pr-Version: www-1.0
X-From4GNATS: "campbell+netbsd@mumble.net via gnats" <gnats-admin@NetBSD.org>

>Number:         60468
>Category:       toolchain
>Synopsis:       external/mpl/bind/lib: misuse of build_install, missing MKBIND conditionals
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 20 13:25:00 +0000 2026
>Last-Modified:  Mon Jul 20 18:50:01 +0000 2026
>Originator:     Taylor R Campbell
>Release:        current, 11, 10, 9, ...
>Organization:
The NotBIND Foundation
>Environment:
>Description:

	external/mpl/bind/lib/Makefile has included
	<bsd.buildinstall.mk> since 2022, but it doesn't actually do
	anything unless you use the `build_install' target, which
	nothing does.

      3 SUBDIR+= libisc .WAIT libdns libisccc .WAIT libisccfg
      4 SUBDIR+= libns .WAIT plugins
      5 
      6 .include <bsd.buildinstall.mk>
      7 .include <bsd.subdir.mk>

https://nxr.NetBSD.org/xref/src/external/mpl/bind/lib/Makefile?r=1.5

	Instead, lib/Makefile descends into it with dependall and
	install _via_ the build_install target _of lib/Makefile_ like
	every other library:

    279 SUBDIR+=	../crypto/external/bsd/netpgp/bindings/lua  # depends on netpgp/lib
 => 280 SUBDIR+=	../external/mpl/bind/lib	# depends on heimdal, libcrypto
    281 						# libuv, userspace-rcu
    282 .if ${MKUNBOUND} != "no"
    283 SUBDIR+=	../external/bsd/unbound/lib	# depends on libcrypto
    284 .endif

https://nxr.NetBSD.org/xref/src/lib/Makefile?r=1.316#280

	Also, it's missing a test for MKBIND, as a result of which we
	ship all the BIND libraries in MKBIND=no builds, as you can see
	from the set lists, comparing base/mi (conditional on `bind')
	to base/shl.mi (not conditional on `bind'):

    597 ./usr/bin/dig					base-netutil-bin	bind

https://nxr.netbsd.org/xref/src/distrib/sets/lists/base/mi?r=1.1387#597

    400 ./usr/lib/libisc.so				base-bind-shlib		compatfile

https://nxr.netbsd.org/xref/src/distrib/sets/lists/base/shl.mi?r=1.1046#400

>How-To-Repeat:

	code inspection, and/or build MKBIND=no

>Fix:

	Makefile.subdir like external/bsd/libevent/lib uses

>Audit-Trail:
From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/60468 CVS commit: src
Date: Mon, 20 Jul 2026 18:45:39 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Mon Jul 20 18:45:39 UTC 2026

 Modified Files:
 	src/distrib/sets/lists/base: shl.mi
 	src/distrib/sets/lists/comp: mi
 	src/distrib/sets/lists/debug: shl.mi
 	src/lib: Makefile

 Log Message:
 bind: Conditionalize libraries on MKBIND.

 PR toolchain/60468: external/mpl/bind/lib: misuse of build_install,
 missing MKBIND conditionals


 To generate a diff of this commit:
 cvs rdiff -u -r1.1046 -r1.1047 src/distrib/sets/lists/base/shl.mi
 cvs rdiff -u -r1.2526 -r1.2527 src/distrib/sets/lists/comp/mi
 cvs rdiff -u -r1.410 -r1.411 src/distrib/sets/lists/debug/shl.mi
 cvs rdiff -u -r1.317 -r1.318 src/lib/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home	PR Database Search