NetBSD Problem Report #60483

From www@netbsd.org  Thu Jul 23 15:39:45 2026
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.netbsd.org", Issuer "YR2" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 102131A923B
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 23 Jul 2026 15:39:45 +0000 (UTC)
Message-Id: <20260723153943.D4DC31A923C@mollari.NetBSD.org>
Date: Thu, 23 Jul 2026 15:39:43 +0000 (UTC)
From: kuleshovmail@gmail.com
Reply-To: kuleshovmail@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [libkvm] Remove unused macro
X-Send-Pr-Version: www-1.0
X-From4GNATS: "kuleshovmail@gmail.com via gnats" <gnats-admin@NetBSD.org>

>Number:         60483
>Category:       lib
>Synopsis:       [libkvm] Remove unused macro
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    thorpej
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 23 15:40:00 +0000 2026
>Last-Modified:  Thu Jul 23 17:38:11 +0000 2026
>Originator:     ALEXANDR KULESHOV
>Release:        11.0_RC7
>Organization:
>Environment:
NetBSD netbsd 11.0_RC7 NetBSD 11.0_RC7 (GENERIC) #0: Wed Jul 22 05:26:24 UTC 2026  mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC amd64

>Description:
lib/libkvm/kvm_sun3x.c defines two file-local macros - _kvm_kvas_size() and _kvm_nkptes() which are not referenced anywhere in the file.

They seems appear to be leftovers from an earlier version of the address translation code.

A little patch attached to remove dead macros.
>How-To-Repeat:
Code inspection of lib/libkvm/kvm_sun3x.c
>Fix:
Index: ./libkvm/kvm_sun3x.c
===================================================================
RCS file: /cvsroot/src/lib/libkvm/kvm_sun3x.c,v
retrieving revision 1.12
diff -u -r1.12 kvm_sun3x.c
--- ./libkvm/kvm_sun3x.c	14 Sep 2011 12:37:55 -0000	1.12
+++ ./libkvm/kvm_sun3x.c	23 Jul 2026 15:33:06 -0000
@@ -70,10 +70,6 @@
 	_kvm_sun3x_kvatop,
 	_kvm_sun3x_pa2off };

-#define	_kvm_kvas_size(h)	\
-	(-((h)->kernbase))
-#define	_kvm_nkptes(h, v)	\
-	(_kvm_kvas_size((h)) >> (v)->pgshift)
 #define	_kvm_pg_pa(pte, h)	\
 	((pte) & (h)->pg_frame)


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: lib-bug-people->thorpej
Responsible-Changed-By: thorpej@NetBSD.org
Responsible-Changed-When: Thu, 23 Jul 2026 17:38:11 +0000
Responsible-Changed-Why:
I'll handle this one; I have other changes for sun2/sun3 libkvm in the
works anyway.


>Unformatted:

Home	PR Database Search