NetBSD Problem Report #60691

From www@netbsd.org  Tue Sep  8 09:59:40 2026
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.netbsd.org", Issuer "YR1" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 5E1411A923B
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  8 Sep 2026 09:59:40 +0000 (UTC)
Message-Id: <20260908095939.4E8091A923C@mollari.NetBSD.org>
Date: Tue,  8 Sep 2026 09:59:39 +0000 (UTC)
From: raytran08@gmail.com
Reply-To: raytran08@gmail.com
To: gnats-bugs@NetBSD.org
Subject: WSKBDIO_COMPLEXBELL discards the requested volume and always passes 100
X-Send-Pr-Version: www-1.0
X-From4GNATS: "raytran08@gmail.com via gnats" <gnats-admin@NetBSD.org>

>Number:         60691
>Category:       port-mac68k
>Synopsis:       WSKBDIO_COMPLEXBELL discards the requested volume and always passes 100
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    nat
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 08 10:00:00 +0000 2026
>Closed-Date:    Thu Oct 15 15:31:17 +0000 2026
>Last-Modified:  Thu Oct 15 15:31:17 +0000 2026
>Originator:     Ray Tran
>Release:        11.0
>Organization:
Diamond Creek Digital
>Environment:
NetBSD 11.0 (Q650WSMUX) #22: Mon Sep  7 10:03:36 UTC 2026
>Description:
kbd_ioctl()'s WSKBDIO_COMPLEXBELL case passes a hard-coded 100 as the
volume argument to mac68k_ring_bell(), discarding the volume the caller
asked for.  The existing comment says as much ("volume ignored").  The
consequence is that wsconsctl(8) bell.volume has no effect on mac68k,
whatever sound hardware is fitted.

Pitch and period are passed through correctly; only volume is dropped.
>How-To-Repeat:
wsconsctl -w bell.volume=10, then ring the bell.  It is as loud as before.
>Fix:
One line: pass d->volume instead of the literal.  Tested on a Centris 650.

Applies with "patch -p1" from the top of usr/src; verified with -F0
(no fuzz) against NetBSD-current 11.99.8 (20260830003849Z) and 11.0.

--- a/sys/arch/mac68k/dev/akbd.c
+++ b/sys/arch/mac68k/dev/akbd.c
@@ -493,8 +493,9 @@
 		return 0;
 	case WSKBDIO_COMPLEXBELL:
 #define d ((struct wskbd_bell_data *)data)
-		mac68k_ring_bell(d->pitch, d->period * hz / 1000, 100);
-		/* comes in as msec, goes out as ticks; volume ignored */
+		/* period: msec in, ticks out; volume is 0-100 */
+		mac68k_ring_bell(d->pitch, d->period * hz / 1000,
+		    d->volume > 100 ? 100 : d->volume);
 #undef d
 		return (0);
 #ifdef WSDISPLAY_COMPAT_RAWKBD

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: port-mac68k-maintainer->nat
Responsible-Changed-By: nat@NetBSD.org
Responsible-Changed-When: Thu, 10 Sep 2026 11:12:32 +0000
Responsible-Changed-Why:
Take.


From: "Nathanial Sloss" <nat@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/60691 CVS commit: src/sys/arch/mac68k/dev
Date: Wed, 16 Sep 2026 06:10:38 +0000

 Module Name:	src
 Committed By:	nat
 Date:		Wed Sep 16 06:10:38 UTC 2026

 Modified Files:
 	src/sys/arch/mac68k/dev: akbd.c

 Log Message:
 Honor keyboard bell volume.

 Addresses PR port-mac68k/60691.

 Patch and testing by Ray Tran.


 To generate a diff of this commit:
 cvs rdiff -u -r1.30 -r1.31 src/sys/arch/mac68k/dev/akbd.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->pending-pullups
State-Changed-By: nat@NetBSD.org
State-Changed-When: Wed, 14 Oct 2026 06:06:55 +0000
State-Changed-Why:
Pullup -11 #525


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/60691 CVS commit: [netbsd-11] src/sys/arch/mac68k/dev
Date: Wed, 14 Oct 2026 17:58:00 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Wed Oct 14 17:58:00 UTC 2026

 Modified Files:
 	src/sys/arch/mac68k/dev [netbsd-11]: akbd.c

 Log Message:
 Pull up following revision(s) (requested by nat in ticket #525):

 	sys/arch/mac68k/dev/akbd.c: revision 1.31

 Honor keyboard bell volume.

 Addresses PR port-mac68k/60691.

 Patch and testing by Ray Tran.


 To generate a diff of this commit:
 cvs rdiff -u -r1.28 -r1.28.2.1 src/sys/arch/mac68k/dev/akbd.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: nat@NetBSD.org
State-Changed-When: Thu, 15 Oct 2026 15:31:17 +0000
State-Changed-Why:
Pullups complete.  Thanks for the report and patch.


>Unformatted:

Home	PR Database Search