NetBSD Problem Report #60862

From www@netbsd.org  Thu Oct  8 16:24:41 2026
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits)
	 client-signature RSA-PSS (2048 bits))
	(Client CN "mail.netbsd.org", Issuer "YR1" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 8DD741A923B
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  8 Oct 2026 16:24:41 +0000 (UTC)
Message-Id: <20261008162440.B76FE1A923C@mollari.NetBSD.org>
Date: Thu,  8 Oct 2026 16:24:40 +0000 (UTC)
From: joe@ns1.eloisystems.com
Reply-To: joe@ns1.eloisystems.com
To: gnats-bugs@NetBSD.org
Subject: no rump tests for procedures in NPF
X-Send-Pr-Version: www-1.0
X-From4GNATS: "joe@ns1.eloisystems.com via gnats" <gnats-admin@NetBSD.org>

>Number:         60862
>Category:       bin
>Synopsis:       no rump tests for procedures in NPF
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 08 16:25:00 +0000 2026
>Last-Modified:  Fri Oct 30 23:40:01 +0000 2026
>Originator:     Emmanuel Nyarko
>Release:        NetBSD current
>Organization:
NetBSD
>Environment:
amd64 x86_64
>Description:

in as much as we need live tests for NPF, most features are missing tests in RUMP
especially for procedures.

this helps us catch some hidden bugs early.
>How-To-Repeat:

code inspection
>Fix:


Get all procedures in RUMP.

>Audit-Trail:
From: "Emmanuel" <joe@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/60862 CVS commit: src
Date: Fri, 30 Oct 2026 23:36:16 +0000

 Module Name:	src
 Committed By:	joe
 Date:		Fri Oct 30 23:36:16 UTC 2026

 Modified Files:
 	src/sys/net/npf: npf_conf.c npf_impl.h
 	src/sys/rump/net/lib/libnpf: Makefile
 	src/usr.sbin/npf/npftest: npftest.c npftest.conf npftest.h
 	src/usr.sbin/npf/npftest/libnpftest: Makefile npf_test.h
 	    npf_test_subr.c
 Added Files:
 	src/usr.sbin/npf/npftest/libnpftest: npf_ext_test.c

 Log Message:
 PR bin/60862

 rump tests for NPF rule procedures

 for logging, we check if it loads successfuly and packet traverses it
 for routing, we also check if packet treversal returns successfuly
 for normalization, we check the packet for the fragment bit, the new maxmss
 and the ttl set.

 in reload, and fini, we "init" the module and also "fini" the module.

 atf-run and you see the reults.


 To generate a diff of this commit:
 cvs rdiff -u -r1.19 -r1.20 src/sys/net/npf/npf_conf.c
 cvs rdiff -u -r1.87 -r1.88 src/sys/net/npf/npf_impl.h
 cvs rdiff -u -r1.28 -r1.29 src/sys/rump/net/lib/libnpf/Makefile
 cvs rdiff -u -r1.31 -r1.32 src/usr.sbin/npf/npftest/npftest.c
 cvs rdiff -u -r1.18 -r1.19 src/usr.sbin/npf/npftest/npftest.conf
 cvs rdiff -u -r1.20 -r1.21 src/usr.sbin/npf/npftest/npftest.h
 cvs rdiff -u -r1.14 -r1.15 src/usr.sbin/npf/npftest/libnpftest/Makefile
 cvs rdiff -u -r0 -r1.1 src/usr.sbin/npf/npftest/libnpftest/npf_ext_test.c
 cvs rdiff -u -r1.24 -r1.25 src/usr.sbin/npf/npftest/libnpftest/npf_test.h
 cvs rdiff -u -r1.19 -r1.20 \
     src/usr.sbin/npf/npftest/libnpftest/npf_test_subr.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home	PR Database Search