NetBSD Problem Report #996

From gnats  Tue Apr 25 23:54:49 1995
Received: from pain.lcs.mit.edu (pain.lcs.mit.edu [128.52.46.239]) by sun-lamp.cs.berkeley.edu (8.6.10/8.6.10) with ESMTP id XAA04037 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Tue, 25 Apr 1995 23:54:48 -0700
Message-Id: <199504260653.CAA08056@azathoth>
Date: Wed, 26 Apr 1995 02:53:39 -0400
From: Mike Long <mike.long@analog.com>
Reply-To: Mike Long <mike.long@analog.com>
To: gnats-bugs@NetBSD.ORG
Subject: audio driver nits
X-Send-Pr-Version: 3.2

>Number:         996
>Category:       kern
>Synopsis:       some minor things with the audio drivers
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 26 00:05:02 +0000 1995
>Closed-Date:    Wed Apr 26 21:48:10 +0000 1995
>Last-Modified:  
>Originator:     Mike Long
>Release:        4/25/95
>Organization:
	We don't need no steenking organization!
>Environment:
System: NetBSD azathoth 1.0A NetBSD 1.0A (AZATHOTH) #2: Sun Mar 26 06:39:10 EST 1995 root@azathoth:/usr/src/sys/arch/i386/compile/AZATHOTH i386

>Description:
	Just a few minor things in the audio driver that have been
bothering me:

1) change #include so pss.c will compile
2) add/update driver descriptions to files.isa
3) SB DSP minor version # is always two digits: 2.01 instead of 2.1

>How-To-Repeat:
	build a kernel?

>Fix:

--- /sys/dev/isa/pss.c~ Tue Apr 18 06:16:41 1995
+++ /sys/dev/isa/pss.c  Sun Apr 23 19:03:23 1995
@@ -67,7 +67,7 @@
 #include <dev/audio_if.h>

 #include <dev/isa/isavar.h>
-#include <dev/isa/dmavar.h>
+#include <dev/isa/isadmavar.h>
 #include <i386/isa/icu.h>                      /* XXX BROKEN; WHY? */

 #include <dev/isa/ad1848var.h>


--- /sys/dev/isa/files.isa~     Thu Apr 20 06:18:47 1995
+++ /sys/dev/isa/files.isa      Wed Apr 26 02:06:49 1995
@@ -173,11 +173,11 @@
 device pas at isa: audio, isadma, sbdsp
 file   dev/isa/pas.c                   pas needs-flag

-# ad1848 (XXX what is it?) chip spport; used by other drivers
+# AD1848 (CS4248, CS4231, AD1845) audio codec support; used by other drivers
 define ad1848
 file   dev/isa/ad1848.c                ad1848

-# (XXX what is this?)
+# Audio systems based on Echo Speech Corp. ESC61[45] ASICs
 device pss at isa {[port = -1], [size = 0],
                    [iomem = -1], [iosiz = 0],
                    [irq = -1], [drq = -1]}


--- /sys/dev/isa/sbdsp.c~       Tue Apr 18 06:16:44 1995
+++ /sys/dev/isa/sbdsp.c        Wed Apr 26 01:48:37 1995
@@ -188,7 +188,7 @@
                for (i = 0; i < SB_NDEVS; i++)
                    sc->gain[i] = sbdsp_stereo_vol(SBP_MAXVOL, SBP_MAXVOL);
        }
-       printf(": dsp v%d.%d\n",
+       printf(": dsp v%d.%02d\n",
               SBVER_MAJOR(sc->sc_model), SBVER_MINOR(sc->sc_model));
 }

>Release-Note:
>Audit-Trail:
Applied the suggested patch.

State-Changed-From-To: open->closed 
State-Changed-By: brezak 
State-Changed-When: Wed Apr 26 14:48:10 PDT 1995 
State-Changed-Why:  
Resolved - applied the suggested patch 
>Unformatted:

Home	PR Database Search