NetBSD Problem Report #52390
From www@NetBSD.org Mon Jul 10 19:00:33 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id D62BD7A21F
for <gnats-bugs@gnats.NetBSD.org>; Mon, 10 Jul 2017 19:00:33 +0000 (UTC)
Message-Id: <20170710190032.7E97F7A28E@mollari.NetBSD.org>
Date: Mon, 10 Jul 2017 19:00:32 +0000 (UTC)
From: bacon4000@gmail.com
Reply-To: bacon4000@gmail.com
To: gnats-bugs@NetBSD.org
Subject: current fails to bootstrap on CentOS 6
X-Send-Pr-Version: www-1.0
>Number: 52390
>Category: pkg
>Synopsis: current fails to bootstrap on CentOS 6
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Jul 10 19:05:00 +0000 2017
>Closed-Date: Sun Dec 03 01:27:57 +0000 2017
>Last-Modified: Sun Dec 03 01:27:57 +0000 2017
>Originator: Jason Bacon
>Release: pkgsrc-current 2017-07-10
>Organization:
UW Milwaukee
>Environment:
Linux centosdev.local 2.6.32-696.3.2.el6.x86_64 #1 SMP Tue Jun 20 01:26:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linu
>Description:
Bootstrap is failing as follows:
cc -O2 -D_GNU_SOURCE=1 -D_FORTIFY_SOURCE=2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-uninitialized -Wreturn-type -Wcast-qual -Wpointer-arith -Wwrite-strings -Wswitch -Wshadow -Werror -DHAVE_NBCOMPAT_H=1 -I/home/bacon/Pkgsrc/pkg-2017-07-10/work/wrk/pkgtools/cwrappers/work/libnbcompat -DNEED_MI_VECTOR_HASH -c fixup-libtool.c
cc1: warnings being treated as errors
fixup-libtool.c: In function 'process_option':
fixup-libtool.c:247: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result
fixup-libtool.c: In function 'process_variable':
fixup-libtool.c:275: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result
fixup-libtool.c: In function 'fixup_libtool_la':
fixup-libtool.c:348: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result
fixup-libtool.c:354: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result
fixup-libtool.c:372: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result
fixup-libtool.c:382: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result
*** [fixup-libtool.o] Error code 1
bmake: stopped in /home/bacon/Pkgsrc/pkg-2017-07-10/work/wrk/pkgtools/cwrappers/work/cwrappers-20170611
1 error
bmake: stopped in /home/bacon/Pkgsrc/pkg-2017-07-10/work/wrk/pkgtools/cwrappers/work/cwrappers-20170611
*** Error code 2
Stop.
bmake[1]: stopped in /home/bacon/Pkgsrc/pkgsrc-2017-07-10/pkgtools/cwrappers
*** Error code 1
Stop.
bmake: stopped in /home/bacon/Pkgsrc/pkgsrc-2017-07-10/pkgtools/cwrappers
===> exited with status 1
aborted.
This is a recent regression, as I have bootstrapped current on the same machine up to about a week ago.
>How-To-Repeat:
Bootstrap current on a pristine CentOS 6 installation.
>Fix:
>Release-Note:
>Audit-Trail:
From: Joerg Sonnenberger <joerg@bec.de>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Wed, 12 Jul 2017 22:46:01 +0200
On Mon, Jul 10, 2017 at 07:05:00PM +0000, bacon4000@gmail.com wrote:
> This is a recent regression, as I have bootstrapped current on the same machine up to about a week ago.
This is most likely the fortify change.
Joerg
From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Thu, 13 Jul 2017 12:54:14 +0000
newer glibc no longer does this.
2012-04-11 Jim Meyering <meyering@redhat.com>
[BZ #11959]
* libio/stdio.h (fwrite, fwrite_unlocked): Remove __wur.
It is not necessarily an error to ignore fwrite's return
value. One can reliably use ferror to test for errors after
the fact.
What to do about older?
From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org, bacon4000@gmail.com
Cc:
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Thu, 13 Jul 2017 09:22:26 -0400
On Jul 13, 12:55pm, coypu@sdf.org (coypu@sdf.org) wrote:
-- Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
| The following reply was made to PR pkg/52390; it has been noted by GNATS.
|
| From: coypu@sdf.org
| To: gnats-bugs@NetBSD.org
| Cc:
| Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
| Date: Thu, 13 Jul 2017 12:54:14 +0000
|
| newer glibc no longer does this.
|
| 2012-04-11 Jim Meyering <meyering@redhat.com>
|
| [BZ #11959]
| * libio/stdio.h (fwrite, fwrite_unlocked): Remove __wur.
| It is not necessarily an error to ignore fwrite's return
| value. One can reliably use ferror to test for errors after
| the fact.
|
| What to do about older?
There are ugly solutions...
in a header file:
#undef fwrite
static inline size_t
fwrite_checked(const void * restrict ptr, size_t size, size_t nmemb,
FILE * restrict stream)
{
size_t nw = fwrite(ptr, size, nmemb, stream);
assert(nw == nmemb);
return nw;
}
#define fwrite(a, b, c, d) fwrite_checked((a), (b), (c), (d))
christos
From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Fri, 14 Jul 2017 02:30:04 +0000
Please drop -Werror from anything related to bootstrap.
The systems we expect to see on pkgsrc don't always have perfect
headers.
From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Sun, 16 Jul 2017 16:11:29 +0000
--Q68bSM7Ycu6FN28Q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
How about this (the alternative being not using bsd.prog.mk)?
--Q68bSM7Ycu6FN28Q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=cwrappers-werror
Index: bin/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/cwrappers/files/bin/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- bin/Makefile 9 Dec 2016 22:25:28 -0000 1.5
+++ bin/Makefile 16 Jul 2017 15:42:27 -0000
@@ -32,6 +32,9 @@
WARNS= 4
NOMAN=
+NOGCCERROR= yes
+NOCLANGERROR= yes
+
CLEANFILES+= .work-new.log \
transform-gcc-rules-fixed.map \
transform-gcc-rules-fixed1.c \
--Q68bSM7Ycu6FN28Q--
From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Sun, 16 Jul 2017 16:52:25 +0000
Please try the following, thanks
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/cwrappers/files/bin/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile 9 Dec 2016 22:25:28 -0000 1.5
+++ Makefile 16 Jul 2017 16:52:08 -0000
@@ -32,6 +32,10 @@
WARNS= 4
NOMAN=
+.if ${OPSYS} == "Linux"
+CFLAGS+= -Wno-error=unused-result
+.endif
+
CLEANFILES+= .work-new.log \
transform-gcc-rules-fixed.map \
transform-gcc-rules-fixed1.c \
From: Jason Bacon <bacon4000@gmail.com>
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org
Cc:
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Sun, 16 Jul 2017 12:29:20 -0500
On 07/16/17 11:55, coypu@sdf.org wrote:
> The following reply was made to PR pkg/52390; it has been noted by GNATS.
>
> From: coypu@sdf.org
> To: gnats-bugs@NetBSD.org
> Cc:
> Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
> Date: Sun, 16 Jul 2017 16:52:25 +0000
>
> Please try the following, thanks
>
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/pkgtools/cwrappers/files/bin/Makefile,v
> retrieving revision 1.5
> diff -u -r1.5 Makefile
> --- Makefile 9 Dec 2016 22:25:28 -0000 1.5
> +++ Makefile 16 Jul 2017 16:52:08 -0000
> @@ -32,6 +32,10 @@
> WARNS= 4
> NOMAN=
>
> +.if ${OPSYS} == "Linux"
> +CFLAGS+= -Wno-error=unused-result
> +.endif
> +
> CLEANFILES+= .work-new.log \
> transform-gcc-rules-fixed.map \
> transform-gcc-rules-fixed1.c \
>
Unfortunately, that flag is not present in GCC 4.4.7:
Linux sciprog2.ceas bacon ~ 405: (pkgsrc): gcc -Wno-error=unused-result
junk.c
cc1: error: -Werror=unused-result: No option -Wunused-result
Linux sciprog2.ceas bacon ~ 408: (pkgsrc):
Pkgsrc/pkg-2017Q1/gcc49/bin/gcc -Wno-error=unused-result junk.c
Linux sciprog2.ceas bacon ~ 409: (pkgsrc):
It would have been a nice solution...
--
Earth is a beta site.
From: Jason Bacon <bacon4000@gmail.com>
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org
Cc:
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Sun, 16 Jul 2017 14:17:52 -0500
On 07/16/17 11:15, coypu@sdf.org wrote:
> The following reply was made to PR pkg/52390; it has been noted by GNATS.
>
> From: coypu@sdf.org
> To: gnats-bugs@NetBSD.org
> Cc:
> Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
> Date: Sun, 16 Jul 2017 16:11:29 +0000
>
> --Q68bSM7Ycu6FN28Q
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
>
> How about this (the alternative being not using bsd.prog.mk)?
>
>
> --Q68bSM7Ycu6FN28Q
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: attachment; filename=cwrappers-werror
>
> Index: bin/Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/pkgtools/cwrappers/files/bin/Makefile,v
> retrieving revision 1.5
> diff -u -r1.5 Makefile
> --- bin/Makefile 9 Dec 2016 22:25:28 -0000 1.5
> +++ bin/Makefile 16 Jul 2017 15:42:27 -0000
> @@ -32,6 +32,9 @@
> WARNS= 4
> NOMAN=
>
> +NOGCCERROR= yes
> +NOCLANGERROR= yes
> +
> CLEANFILES+= .work-new.log \
> transform-gcc-rules-fixed.map \
> transform-gcc-rules-fixed1.c \
>
> --Q68bSM7Ycu6FN28Q--
>
This works for me. I did a quick test by adding
MAKE_ENV+= NOGCCERROR=true
to cwrappers/Makefile.
NOGCCERROR=yes in the environment during bootstrap also works, although
the same in cwrappers/Makefile does not for reasons I haven't tracked
down yet.
Thanks for digging into this,
JB
--
Earth is a beta site.
From: Joerg Sonnenberger <joerg@bec.de>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
bacon4000@gmail.com
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Mon, 17 Jul 2017 12:14:37 +0200
On Sun, Jul 16, 2017 at 05:30:00PM +0000, Jason Bacon wrote:
> The following reply was made to PR pkg/52390; it has been noted by GNATS.
>
> From: Jason Bacon <bacon4000@gmail.com>
> To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
> pkgsrc-bugs@netbsd.org
> Cc:
> Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
> Date: Sun, 16 Jul 2017 12:29:20 -0500
>
> On 07/16/17 11:55, coypu@sdf.org wrote:
> > The following reply was made to PR pkg/52390; it has been noted by GNATS.
> >
> > From: coypu@sdf.org
> > To: gnats-bugs@NetBSD.org
> > Cc:
> > Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
> > Date: Sun, 16 Jul 2017 16:52:25 +0000
> >
> > Please try the following, thanks
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvsroot/pkgsrc/pkgtools/cwrappers/files/bin/Makefile,v
> > retrieving revision 1.5
> > diff -u -r1.5 Makefile
> > --- Makefile 9 Dec 2016 22:25:28 -0000 1.5
> > +++ Makefile 16 Jul 2017 16:52:08 -0000
> > @@ -32,6 +32,10 @@
> > WARNS= 4
> > NOMAN=
> >
> > +.if ${OPSYS} == "Linux"
> > +CFLAGS+= -Wno-error=unused-result
> > +.endif
> > +
> > CLEANFILES+= .work-new.log \
> > transform-gcc-rules-fixed.map \
> > transform-gcc-rules-fixed1.c \
> >
>
> Unfortunately, that flag is not present in GCC 4.4.7:
>
> Linux sciprog2.ceas bacon ~ 405: (pkgsrc): gcc -Wno-error=unused-result
> junk.c
> cc1: error: -Werror=unused-result: No option -Wunused-result
>
> Linux sciprog2.ceas bacon ~ 408: (pkgsrc):
> Pkgsrc/pkg-2017Q1/gcc49/bin/gcc -Wno-error=unused-result junk.c
> Linux sciprog2.ceas bacon ~ 409: (pkgsrc):
>
> It would have been a nice solution...
-Wno-unused-result, not -Wno-error=unused-result.
Joerg
From: Jason Bacon <bacon4000@gmail.com>
To: Joerg Sonnenberger <joerg@bec.de>, gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Mon, 17 Jul 2017 08:45:21 -0500
On 07/17/17 05:14, Joerg Sonnenberger wrote:
> On Sun, Jul 16, 2017 at 05:30:00PM +0000, Jason Bacon wrote:
>> The following reply was made to PR pkg/52390; it has been noted by GNATS.
>>
>> From: Jason Bacon <bacon4000@gmail.com>
>> To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
>> pkgsrc-bugs@netbsd.org
>> Cc:
>> Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
>> Date: Sun, 16 Jul 2017 12:29:20 -0500
>>
>> On 07/16/17 11:55, coypu@sdf.org wrote:
>> > The following reply was made to PR pkg/52390; it has been noted by GNATS.
>> >
>> > From: coypu@sdf.org
>> > To: gnats-bugs@NetBSD.org
>> > Cc:
>> > Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
>> > Date: Sun, 16 Jul 2017 16:52:25 +0000
>> >
>> > Please try the following, thanks
>> >
>> > Index: Makefile
>> > ===================================================================
>> > RCS file: /cvsroot/pkgsrc/pkgtools/cwrappers/files/bin/Makefile,v
>> > retrieving revision 1.5
>> > diff -u -r1.5 Makefile
>> > --- Makefile 9 Dec 2016 22:25:28 -0000 1.5
>> > +++ Makefile 16 Jul 2017 16:52:08 -0000
>> > @@ -32,6 +32,10 @@
>> > WARNS= 4
>> > NOMAN=
>> >
>> > +.if ${OPSYS} == "Linux"
>> > +CFLAGS+= -Wno-error=unused-result
>> > +.endif
>> > +
>> > CLEANFILES+= .work-new.log \
>> > transform-gcc-rules-fixed.map \
>> > transform-gcc-rules-fixed1.c \
>> >
>>
>> Unfortunately, that flag is not present in GCC 4.4.7:
>>
>> Linux sciprog2.ceas bacon ~ 405: (pkgsrc): gcc -Wno-error=unused-result
>> junk.c
>> cc1: error: -Werror=unused-result: No option -Wunused-result
>>
>> Linux sciprog2.ceas bacon ~ 408: (pkgsrc):
>> Pkgsrc/pkg-2017Q1/gcc49/bin/gcc -Wno-error=unused-result junk.c
>> Linux sciprog2.ceas bacon ~ 409: (pkgsrc):
>>
>> It would have been a nice solution...
> -Wno-unused-result, not -Wno-error=unused-result.
>
> Joerg
Also not supported in 4.4.7.
I had searched the GCC man page for "unused-result" and came up empty.
I just tried it anyway:
Linux sciprog2.ceas bacon ~ 429: (pkgsrc): gcc -O2 -Wno-unused-result
-D_FORTIFY_SOURCE=2 -Werror warn.c
cc1: warnings being treated as errors
warn.c: In function ‘main’:
warn.c:9: error: ignoring return value of ‘fwrite’, declared with
attribute warn_unused_result
At top level:
cc1: error: unrecognized command line option "-Wno-unused-result"
It is documented and functional in GCC 4.8 and later:
Linux sciprog2.ceas bacon ~ 436: (pkgsrc):
Pkgsrc/pkg-2017Q1/gcc48/bin/gcc -O2 -Wno-unused-result
-D_FORTIFY_SOURCE=1 -Werror warn.c
Linux sciprog2.ceas bacon ~ 437: (pkgsrc):
Interestingly, on CentOS at least, without _FORTIFY_SOURCE, the flag
seems to be silently ignored:
Linux sciprog2.ceas bacon ~ 438: (pkgsrc): gcc -O2 -Wno-unused-result
-Werror warn.c
Linux sciprog2.ceas bacon ~ 439: (pkgsrc):
Thanks anyway,
JB
--
Earth is a beta site.
From: Joerg Sonnenberger <joerg@bec.de>
To: Jason Bacon <bacon4000@gmail.com>
Cc: Joerg Sonnenberger <joerg@bec.de>, gnats-bugs@NetBSD.org,
pkg-manager@netbsd.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Mon, 17 Jul 2017 17:09:47 +0200
On Mon, Jul 17, 2017 at 08:45:21AM -0500, Jason Bacon wrote:
> > -Wno-unused-result, not -Wno-error=unused-result.
>
> Also not supported in 4.4.7.
F**k: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509
OK, I guess that makes it "disable fortify for GCC 4.4 on Linux". I'm
not willing to disable all warnings just they couldn't get their act
together.
Joerg
From: Jason Bacon <bacon4000@gmail.com>
To: Joerg Sonnenberger <joerg@bec.de>
Cc: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Mon, 17 Jul 2017 10:44:41 -0500
On 07/17/17 10:09, Joerg Sonnenberger wrote:
> On Mon, Jul 17, 2017 at 08:45:21AM -0500, Jason Bacon wrote:
>>> -Wno-unused-result, not -Wno-error=unused-result.
>> Also not supported in 4.4.7.
> F**k: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509
>
> OK, I guess that makes it "disable fortify for GCC 4.4 on Linux". I'm
> not willing to disable all warnings just they couldn't get their act
> together.
>
> Joerg
Or disable -Werror for GCC 4.4 on Linux. This seems to be sufficient
based on my tests.
I'm not sure exactly how much less invasive it is than disabling
fortify. At least warnings from fortify are still shown and if we're
using _FORTIFY_SOURCE=2, runtime errors can still be caught.
Linux sciprog2.ceas bacon ~ 405: (pkgsrc): gcc -O2 -D_FORTIFY_SOURCE=2
warn.c
warn.c: In function main:
warn.c:9: warning: ignoring return value of fwrite, declared with
attribute warn_unused_result
At top level:
cc1: warning: unrecognized command line option "-Wno-unused-result"
Linux sciprog2.ceas bacon ~ 406: (pkgsrc): ./a.out
Hello, world!
Linux sciprog2.ceas bacon ~ 410: (pkgsrc): gcc -O2 -D_FORTIFY_SOURCE=2
-Werror warn.c
cc1: warnings being treated as errors
warn.c: In function ���main���:
warn.c:9: error: ignoring return value of ���fwrite���, declared with
attribute warn_unused_result
Linux sciprog2.ceas bacon ~ 411: (pkgsrc): ./a.out
./a.out: Command not found.
Thanks,
JB
--
Earth is a beta site.
From: Joerg Sonnenberger <joerg@bec.de>
To: Jason Bacon <bacon4000@gmail.com>
Cc: Joerg Sonnenberger <joerg@bec.de>, gnats-bugs@NetBSD.org,
pkg-manager@netbsd.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org
Subject: Re: pkg/52390: current fails to bootstrap on CentOS 6
Date: Mon, 17 Jul 2017 17:50:46 +0200
On Mon, Jul 17, 2017 at 10:44:41AM -0500, Jason Bacon wrote:
> On 07/17/17 10:09, Joerg Sonnenberger wrote:
> > On Mon, Jul 17, 2017 at 08:45:21AM -0500, Jason Bacon wrote:
> > > > -Wno-unused-result, not -Wno-error=unused-result.
> > > Also not supported in 4.4.7.
> > F**k: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509
> >
> > OK, I guess that makes it "disable fortify for GCC 4.4 on Linux". I'm
> > not willing to disable all warnings just they couldn't get their act
> > together.
> >
> > Joerg
>
> Or disable -Werror for GCC 4.4 on Linux. This seems to be sufficient based
> on my tests.
I prefer getting warnings for real things than some security voodoo.
Given that glibc systems have a well known history of requiring special
magic for asprintf for example, that's a much more real concern.
Joerg
From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/52390 CVS commit: pkgsrc/pkgtools/bootstrap-mk-files
Date: Wed, 2 Aug 2017 09:38:06 +0000
Module Name: pkgsrc
Committed By: maya
Date: Wed Aug 2 09:38:06 UTC 2017
Modified Files:
pkgsrc/pkgtools/bootstrap-mk-files: Makefile
pkgsrc/pkgtools/bootstrap-mk-files/files: bsd.sys.mk
pkgsrc/pkgtools/bootstrap-mk-files/files/mods: HPUX.sys.mk IRIX.sys.mk
OSF1.sys.mk SunOS.bsd.sys.mk
Log Message:
Remove -Werror from bootstrap path. It makes the cwrappers build
fail unnecessarily on some edge cases such as older glibc.
PR pkg/52390: current fails to bootstrap on CentOS 6
ok pkgsrc-pmc@
To generate a diff of this commit:
cvs rdiff -u -r1.52 -r1.53 pkgsrc/pkgtools/bootstrap-mk-files/Makefile
cvs rdiff -u -r1.3 -r1.4 pkgsrc/pkgtools/bootstrap-mk-files/files/bsd.sys.mk
cvs rdiff -u -r1.4 -r1.5 \
pkgsrc/pkgtools/bootstrap-mk-files/files/mods/HPUX.sys.mk \
pkgsrc/pkgtools/bootstrap-mk-files/files/mods/SunOS.bsd.sys.mk
cvs rdiff -u -r1.5 -r1.6 \
pkgsrc/pkgtools/bootstrap-mk-files/files/mods/IRIX.sys.mk
cvs rdiff -u -r1.2 -r1.3 \
pkgsrc/pkgtools/bootstrap-mk-files/files/mods/OSF1.sys.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->feedback
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Fri, 03 Nov 2017 19:51:13 +0000
State-Changed-Why:
There was a commit, did it help?
From: Jason Bacon <bacon4000@gmail.com>
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org,
gnats-admin@netbsd.org, bsiegert@NetBSD.org
Cc:
Subject: Re: pkg/52390 (current fails to bootstrap on CentOS 6)
Date: Fri, 1 Dec 2017 10:02:09 -0600
On 11/03/17 14:51, bsiegert@NetBSD.org wrote:
> Synopsis: current fails to bootstrap on CentOS 6
>
> State-Changed-From-To: open->feedback
> State-Changed-By: bsiegert@NetBSD.org
> State-Changed-When: Fri, 03 Nov 2017 19:51:13 +0000
> State-Changed-Why:
> There was a commit, did it help?
>
>
>
Yep, it's fine now.
--
Earth is a beta site.
State-Changed-From-To: feedback->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 03 Dec 2017 01:27:57 +0000
State-Changed-Why:
Fixed, thanks for the report and sorry for the delay.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home