NetBSD Problem Report #53725

From www@NetBSD.org  Sun Nov 11 21:42:07 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 963D27A10D
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 11 Nov 2018 21:42:07 +0000 (UTC)
Message-Id: <20181111214205.9224D7A1E8@mollari.NetBSD.org>
Date: Sun, 11 Nov 2018 21:42:05 +0000 (UTC)
From: js-pkgsrc@heap.zone
Reply-To: js-pkgsrc@heap.zone
To: gnats-bugs@NetBSD.org
Subject: cross/aarch64-none-elf-gcc does not build on NetBSD
X-Send-Pr-Version: www-1.0

>Number:         53725
>Category:       pkg
>Synopsis:       cross/aarch64-none-elf-gcc does not build on NetBSD
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    leot
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 11 21:45:00 +0000 2018
>Closed-Date:    Fri Nov 16 10:07:24 +0000 2018
>Last-Modified:  Fri Nov 16 10:10:00 +0000 2018
>Originator:     Jonathan Schleifer
>Release:        HEAD
>Organization:
>Environment:
NetBSD/amd64 8.0
>Description:
.tar needs to be extracted using bsdtar, but EXTRACT_USING is missing.
PLIST is incomplete.
>How-To-Repeat:
Try to build on NetBSD
>Fix:
The following patch makes it build:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/cross/aarch64-none-elf-gcc/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile	22 Aug 2018 09:43:10 -0000	1.4
+++ Makefile	11 Nov 2018 21:41:32 -0000
@@ -9,6 +9,7 @@
 SITES.newlib-${NEWLIBVER}.tar.gz=ftp://sources.redhat.com/pub/newlib/
 DISTFILES=		${DISTNAME}${EXTRACT_SUFX} \
 			newlib-${NEWLIBVER}.tar.gz
+EXTRACT_USING=		bsdtar

 MAINTAINER=		port-arm@NetBSD.org
 HOMEPAGE=		# none
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/cross/aarch64-none-elf-gcc/PLIST,v
retrieving revision 1.1
diff -u -r1.1 PLIST
--- PLIST	1 Sep 2017 20:56:43 -0000	1.1
+++ PLIST	11 Nov 2018 21:41:33 -0000
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.1 2017/09/01 20:56:43 jmcneill Exp $
+@comment $NetBSD$
 cross-aarch64-none-elf/aarch64-none-elf/include/_ansi.h
 cross-aarch64-none-elf/aarch64-none-elf/include/_newlib_version.h
 cross-aarch64-none-elf/aarch64-none-elf/include/_syslist.h
@@ -352,6 +352,7 @@
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/binomial_heap_/constructors_destructor_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/binomial_heap_/debug_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/binomial_heap_base_/binomial_heap_base_.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/binomial_heap_base_/constructors_destructor_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/binomial_heap_base_/debug_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/binomial_heap_base_/erase_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/binomial_heap_base_/find_fn_imps.hpp
@@ -363,6 +364,9 @@
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/cc_hash_table_map_/cc_ht_map_.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/cc_hash_table_map_/cmp_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/cc_hash_table_map_/cond_key_dtor_entry_dealtor.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/cc_hash_table_map_/constructor_destructor_fn_imps.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/cc_hash_table_map_/constructor_destructor_no_store_hash_fn_imps.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/cc_hash_table_map_/constructor_destructor_store_hash_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/cc_hash_table_map_/debug_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/cc_hash_table_map_/debug_no_store_hash_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/cc_hash_table_map_/debug_store_hash_fn_imps.hpp
@@ -388,6 +392,9 @@
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/debug_map_base.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/eq_fn/eq_by_less.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/eq_fn/hash_eq_fn.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/gp_hash_table_map_/constructor_destructor_fn_imps.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/gp_hash_table_map_/constructor_destructor_no_store_hash_fn_imps.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/gp_hash_table_map_/constructor_destructor_store_hash_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/gp_hash_table_map_/debug_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/gp_hash_table_map_/debug_no_store_hash_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/gp_hash_table_map_/debug_store_hash_fn_imps.hpp
@@ -422,12 +429,16 @@
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/hash_fn/sample_ranged_hash_fn.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/hash_fn/sample_ranged_probe_fn.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/const_iterator.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/constructors_destructor_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/debug_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/erase_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/info_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/insert_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/iterators_fn_imps.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/left_child_next_sibling_heap_.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/node.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/point_const_iterator.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/policy_access_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/left_child_next_sibling_heap_/trace_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/list_update_map_/constructor_destructor_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/list_update_map_/debug_fn_imps.hpp
@@ -487,6 +498,7 @@
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/rb_tree_map_/rb_tree_.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/rb_tree_map_/split_join_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/rb_tree_map_/traits.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/rc_binomial_heap_/constructors_destructor_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/rc_binomial_heap_/debug_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/rc_binomial_heap_/erase_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/rc_binomial_heap_/insert_fn_imps.hpp
@@ -494,8 +506,10 @@
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/rc_binomial_heap_/rc_binomial_heap_.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/rc_binomial_heap_/split_join_fn_imps.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/rc_binomial_heap_/trace_fn_imps.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/resize_policy/cc_hash_max_collision_check_resize_trigger_imp.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/resize_policy/hash_exponential_size_policy_imp.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/resize_policy/hash_load_check_resize_trigger_imp.hpp
+cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/resize_policy/hash_load_check_resize_trigger_size_base.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/resize_policy/hash_prime_size_policy_imp.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/resize_policy/hash_standard_resize_policy_imp.hpp
 cross-aarch64-none-elf/aarch64-none-elf/include/c++/${PKGVERSION}/ext/pb_ds/detail/resize_policy/sample_resize_policy.hpp

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->leot
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Fri, 16 Nov 2018 10:01:00 +0000
Responsible-Changed-Why:
Also take the original PR!
(not the duplicated and closed one!)


State-Changed-From-To: open->analyzed
State-Changed-By: leot@NetBSD.org
State-Changed-When: Fri, 16 Nov 2018 10:01:00 +0000
State-Changed-Why:
The package probably always worked by accident (i.e. the extra
*.hpp that are extracted with bsdtar were not used).
Patch proposed looks good and will be committed in the next few
minutes (because the PLIST is changed the package also needs a
PKGREVISION bump).


State-Changed-From-To: analyzed->closed
State-Changed-By: leot@NetBSD.org
State-Changed-When: Fri, 16 Nov 2018 10:07:24 +0000
State-Changed-Why:
Patch committed (I have also bumped the PKGREVISION because
PLIST was changed).

Thank you very much Jonathan for the PR and patch!


From: "Leonardo Taccari" <leot@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53725 CVS commit: pkgsrc/cross/aarch64-none-elf-gcc
Date: Fri, 16 Nov 2018 10:06:23 +0000

 Module Name:	pkgsrc
 Committed By:	leot
 Date:		Fri Nov 16 10:06:23 UTC 2018

 Modified Files:
 	pkgsrc/cross/aarch64-none-elf-gcc: Makefile PLIST

 Log Message:
 aarch64-none-elf-gcc: Use bsdtar to install some missing .hpp files

 Several .hpp files were not extracted and installed, always use
 `bsdtar' to extract and install also the missing .hpp.

 Bump PKGREVISION.

 Patch from Jonathan Schleifer via PR pkg/53725.  Thank you Jonathan!


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/cross/aarch64-none-elf-gcc/Makefile
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/cross/aarch64-none-elf-gcc/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search